Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <318470ce-1631-4c46-b425-755c877dda65@amd.com>
Date:   Sun, 10 Dec 2023 15:21:44 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 11/11] ASoC: SOF: topology: Add new DAI type entry for
 SOF_DAI_AMD_BT
Content-Language: en-US
To:     Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Alper Nebi Yasak <alpernebiyasak@gmail.com>,
        Syed Saba Kareem <Syed.SabaKareem@amd.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        Marian Postevca <posteuca@mutex.one>,
        Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
        V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>,
        Mastan Katragadda <Mastan.Katragadda@amd.com>,
        Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
Cc:     linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
        sound-open-firmware@alsa-project.org, kernel@collabora.com
References: <20231209205351.880797-1-cristian.ciocaltea@collabora.com>
 <20231209205351.880797-12-cristian.ciocaltea@collabora.com>
 <fad8a055-eabb-4087-94d5-9e1de00933e4@amd.com>
 <aa830670-e544-43a2-9ba9-a64f1964a9f5@collabora.com>
From:   Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
In-Reply-To: <aa830670-e544-43a2-9ba9-a64f1964a9f5@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHdMZHVkU1pDdTkzcUxJVGZVTWRyS0cyaUhaUklxVjBEUWZSVFJZT3hCQmUv?=
 =?utf-8?B?Vm1CMlM2SXBmenI4NklxbDJnRGQxYXNWM2x2ZmRtUWVoZ2RyclRrTllkWGFF?=
 =?utf-8?B?QnRKbmZ1RWxrNlV6OHpsQm9BaFpFMzJBT2d6aFBKUzdlOHFyQXBNaWc0T2Ey?=
 =?utf-8?B?Vnk2eFhkTzhPblRLWlFvM1B6YnVvR3VGK0hoMUhRMklvMStDT1pmbEVDb1Uz?=
 =?utf-8?B?MGkvdG5yV2dMQVI2aFl2MWdGRSs0c0NvSm9uL2pBWHlDa2ZlR2VGRW1iZ1lV?=
 =?utf-8?B?ejNVZ1QyeGgxOHF5REEwZFlFbEJIUlBJV21UYzMxZUFzaW5HWVlyZldOU2dQ?=
 =?utf-8?B?ZEFUNE5tMGNSYkVJSnpPcytSRU4xcUdMTmx4RFlxRFlMMFh0KzlaWW4ySTVw?=
 =?utf-8?B?MWFqVEFEbWg5amlxSFdlbmVVQkw3U1RsZmp3M0VEUTB2b1hId1ZGeVlCZ3VQ?=
 =?utf-8?B?SzZPNDdhOVdCeHJTUnpIZ2dVU0h5N1JOcGhkV1ZXVGU2cHAyeFpWenpNSEhq?=
 =?utf-8?B?SXNub3BlcFRaRGhadHNrN1QrSlBrZjJ4RXprUU95WFVkaTB6ck12dXdGSnZz?=
 =?utf-8?B?a3o4ZWRaSnRqUEt2ZEprMlFVR2dLbHk4cisxbXZldGFpd2NsTVlMaGpFOGdK?=
 =?utf-8?B?RjBNMWxmc3Y4RHVCbkYyVDUwbkdHM0VETFA0WXNCbE5VcG9Sd3YyUCtUU3Yx?=
 =?utf-8?B?aDFOTGFNZ0gzVDJRSUNzSitaYjZkZlRwTHVnaW1aTlV1MXQ4OE9OYW8wWXpn?=
 =?utf-8?B?T21DdnNSeUY4YS9PM3VBckFWWjE1SlZWZk9lTUljTzNNK01SWVJUY1ZrSFdV?=
 =?utf-8?B?VGlnMDVuUldPWTNGZktKZ2tSVS8ybnZqOXlaWTZZK3YvUnhudk5EYWl4N3Nt?=
 =?utf-8?B?ZW80eXBoQVgwUlliR2UxWTlJN05UOHhCSVk0VmJNMlV5Qjg1L0JQby9zdndQ?=
 =?utf-8?B?WG5HR1YreE11RnV3aWhQdXNMWklBWDFGQkV1VHVQbllqZ2hVd1pXc2RLanU0?=
 =?utf-8?B?LzhaOHVRL01ET0QyeEpPTW90dEJ5M0Yrc2tQTThjV1h2QzJSN1NwSU1uUXRU?=
 =?utf-8?B?Q0pvMlJXUDJHdUd2ajBPTk9KYmxhMDZuUUo2dXp5QUNyUnNmZmVCYU1mWWRB?=
 =?utf-8?B?SWF4d09hZUdpSStZY2VzMlRMMDRqeWcyS0dzcFp1Nzg0aEw2RGsweXMySWtl?=
 =?utf-8?B?cGQzemdwbmU3RzRjenhDSVovZCtrK0NWRVQ3SWNXTjFhbkh3S05XV081QXh3?=
 =?utf-8?B?a2F0dm0zdUE4Rk44NXRUMWgrcHowUnZMcU9XdDdCeDl1a0kwTDhFZ3ZERUtR?=
 =?utf-8?B?T0RQa2RFQ1FHTi9rdVV4dHlrUTY2ZElTQWpnb2poWVFCYjF5SUZMMkh5Z2FB?=
 =?utf-8?B?d1A0VUZadmhZNEwrcWhxaXd6WjBqTno1OUVtSmRXbnltbEI3QmJuN0Rkbkpp?=
 =?utf-8?B?T081Sy9lcGJxMzhZd24zbXRKZWxHRFpHTG93YU1Yd3gzZmtjbFVJV1hqQStp?=
 =?utf-8?B?cXpvbVREdmRzcU04OUNlVVBzRkMrOTlrdlp0K1hFSFFBa010RFFIYTRKRDBV?=
 =?utf-8?B?QitPZFhkZE1IZTZHS0w0L0xuTTIyWU02aDkwaU1HWTF2Q0RQSnFoVjV4UUda?=
 =?utf-8?B?V1Q0SWRKZ0lEc2JPZDJXZWJwNHVld2VuM3VaWTlPYnNCMnlxWXMzT3NVY29z?=
 =?utf-8?B?OE9PQTVQLzVkak9mOWpNNjM2cVBONFJ0N1hDUUpxczVvTDI1MFpSZ09DZSti?=
 =?utf-8?B?SEVyMVZYNHRUY1JnTW85aEFkenNubDFkcHdDZEpiWnpZMjZod1B2RXY3QWFv?=
 =?utf-8?B?VkRLUnUzUmFjU0FBQ0dWMFpyaG1vZlhzUzJlYUdzRWtpL2FkQTJkckVFUW8y?=
 =?utf-8?B?Z1htY1RLQ0RjZUJQSFFHS0ZqMXVNTzVrdk8wdlozZkYvYytNWlVmemNXOW83?=
 =?utf-8?B?Q1AyMjhQalRqOWh4RW4yTHNuOG1WcWFsZGlRU2pxd2tPSmpickN6a1RNTHpB?=
 =?utf-8?B?Wnlyd01GQ0dDb0R3bVI5aS9OcWU4Zk9LT0Z1Nlh1TDZaeHBrQVdiZzRWYTlP?=
 =?utf-8?B?clV2S0RINUc0Q1JRU2FlWGZuUzBhcTROc3NVV3R3ZTdTZUg1dDNVWWFiNnMx?=
 =?utf-8?Q?NDsIAZsqAZ3lbOw4nrI6Fng3E?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cdd72d50-d6e7-4d89-63eb-08dbf965a449
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5951.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2023 09:51:54.9829
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QlieGtXmA6N9Vm2OHF+Zjl3Fhw8gnUMa/2uEn4xFM99n/3Yw5AF/E/UfPzo4NA+Xy98qAOqD67ZFH8NAkgIyQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6574
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Sun, 10 Dec 2023 01:55:34 -0800 (PST)


On 12/10/23 14:38, Cristian Ciocaltea wrote:
> On 12/10/23 05:30, Venkata Prasad Potturu wrote:
>> On 12/10/23 02:23, Cristian Ciocaltea wrote:
>>> Commit efb931cdc4b9 ("ASoC: SOF: topology: Add support for AMD ACP
>>> DAIs") registered "ACP" name for SOF_DAI_AMD_BT DAI type.  However, some
>>> boards, i.e. Steam Deck OLED, seem to require "ACPBT" for the same type:
>>>
>>> [  467.489680] snd_sof_amd_vangogh 0000:04:00.5: ipc tx error for
>>> 0x30030000 (msg/reply size: 16/0): -22
>>> [  467.492775] snd_sof_amd_vangogh 0000:04:00.5: sof_ipc3_route_setup:
>>> route ACPBT2.IN -> BUF5.0 failed
>>> [  467.495839] snd_sof_amd_vangogh 0000:04:00.5:
>>> sof_ipc3_set_up_all_pipelines: route set up failed
>>> [  467.499128] snd_sof_amd_vangogh 0000:04:00.5: error: tplg component
>>> load failed -22
>>> [  467.502210] snd_sof_amd_vangogh 0000:04:00.5: error: failed to load
>>> DSP topology -22
>>> [  467.505289] snd_sof_amd_vangogh 0000:04:00.5: ASoC: error at
>>> snd_soc_component_probe on 0000:04:00.5: -22
>>> [  467.508430] sof_mach nau8821-max: ASoC: failed to instantiate card -22
>>> [  467.511725] sof_mach nau8821-max: error -EINVAL: Failed to register
>>> card(sof-nau8821-max)
>>> [  467.514861] sof_mach: probe of nau8821-max failed with error -22
>>>
>>> Add "ACPBT" alias for "ACP" SOF DAI type.
>>>
>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>>> ---
>>>    sound/soc/sof/topology.c | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
>>> index e3e7fbe40fa6..73bf791e7520 100644
>>> --- a/sound/soc/sof/topology.c
>>> +++ b/sound/soc/sof/topology.c
>>> @@ -290,6 +290,7 @@ static const struct sof_dai_types sof_dais[] = {
>>>        {"SAI", SOF_DAI_IMX_SAI},
>>>        {"ESAI", SOF_DAI_IMX_ESAI},
>>>        {"ACP", SOF_DAI_AMD_BT},
>>> +    {"ACPBT", SOF_DAI_AMD_BT},
>> No need to create the alias name, we can directly modify ACP to ACPBT as
>> ACP is not using anywhere.
> Great, thanks, will do in v2.
This should send to SOF git repo for rewiew, once SOF reviewers approved 
this, again need to send to broonie git.
All the changes in sound/soc/sof/ path should go to SOF git.
>
>>>        {"ACPSP", SOF_DAI_AMD_SP},
>>>        {"ACPDMIC", SOF_DAI_AMD_DMIC},
>>>        {"ACPHS", SOF_DAI_AMD_HS},