Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753745AbXLDWVb (ORCPT ); Tue, 4 Dec 2007 17:21:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751240AbXLDWVW (ORCPT ); Tue, 4 Dec 2007 17:21:22 -0500 Received: from rv-out-0910.google.com ([209.85.198.185]:4085 "EHLO rv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbXLDWVW (ORCPT ); Tue, 4 Dec 2007 17:21:22 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=cStOz8mGGKYaFiq98LqbZVRyq6fCctj0/wIDoCEsDLQs4/+QBhPxATWVG2J2wH5SWltERC7p2J/lO+Gor+uW01HhZ1Jv3FQr/iBh73txaqZ0do6PTbSY5pELkP6mGyam3b81Q4seXsAtYNvmoKgCbgVvl/FnMSDK6f3A2v1XZTk= Subject: Re: [RFC PATCH] x86: Unify include/asm-x86/linkage_[32|64].h From: Harvey Harrison To: Ingo Molnar Cc: "H. Peter Anvin" , Thomas Gleixner , LKML In-Reply-To: <20071204213247.GA11216@elte.hu> References: <1196801629.10408.26.camel@brick> <20071204213247.GA11216@elte.hu> Content-Type: text/plain Date: Tue, 04 Dec 2007 14:21:08 -0800 Message-Id: <1196806868.10408.33.camel@brick> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 27 On Tue, 2007-12-04 at 22:32 +0100, Ingo Molnar wrote: > * Harvey Harrison wrote: > > > I'm not sure if the definition of asmlinkage and prevent_tail_call can > > be omitted as well and let the linux/linkage.h version get picked up > > instead. > > no, we cannot remove them - asmlinkage is needed for the syscall entry > (and other entry code) to work, the and the prevent_tail_call works > around a compiler bug. (which might or might not be fixed in latest gcc > - but we generally dont remove workarounds unless we are really sure > it's fine.) OK, but if this patch is acceptable, then there is no more places in the tree that define the FASTCALL macro, other than the empty default in include/linux/linkage.h. So I think a second step would be to start to get rid of FASTCALL callers elsewhere in the tree...thoughts? Cheers, Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/