Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Sun, 10 Dec 2023 11:39:05 +0100
From:   Guilherme Amadio <amadio@gentoo.org>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] x86/nmi: Rate limit unknown NMI messages
Message-ID: <ZXWVSXqAkOGRs3UG@gentoo.org>
References: <20231209015211.357983-1-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231209015211.357983-1-namhyung@kernel.org>
Precedence: bulk

On Fri, Dec 08, 2023 at 05:52:11PM -0800, Namhyung Kim wrote:
> On some AMD machines, unknown NMI messages were printed on the console
> continuously when using perf command with IBS.  It was reported that it
> can slow down the kernel.  Let's ratelimit the unknown NMI messages.
> 
> Cc: Ravi Bangoria <ravi.bangoria@amd.com>
> Cc: Guilherme Amadio <amadio@gentoo.org>

The rate of messages on the console were proportional to the sampling frequency
when I noticed this happening, so this is a welcome change. Thank you!

Acked-by: Guilherme Amadio <amadio@gentoo.org>

Best regards,
-Guilherme

> Cc: Stephane Eranian <eranian@google.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  arch/x86/kernel/nmi.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c
> index 17e955ab69fe..d23867901186 100644
> --- a/arch/x86/kernel/nmi.c
> +++ b/arch/x86/kernel/nmi.c
> @@ -303,13 +303,13 @@ unknown_nmi_error(unsigned char reason, struct pt_regs *regs)
>  
>  	__this_cpu_add(nmi_stats.unknown, 1);
>  
> -	pr_emerg("Uhhuh. NMI received for unknown reason %02x on CPU %d.\n",
> -		 reason, smp_processor_id());
> +	pr_emerg_ratelimited("Uhhuh. NMI received for unknown reason %02x on CPU %d.\n",
> +			     reason, smp_processor_id());
>  
>  	if (unknown_nmi_panic || panic_on_unrecovered_nmi)
>  		nmi_panic(regs, "NMI: Not continuing");
>  
> -	pr_emerg("Dazed and confused, but trying to continue\n");
> +	pr_emerg_ratelimited("Dazed and confused, but trying to continue\n");
>  }
>  NOKPROBE_SYMBOL(unknown_nmi_error);
>  
> -- 
> 2.43.0.472.g3155946c3a-goog
>