Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3373294rdb; Sun, 10 Dec 2023 03:13:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IFILWgdxWYKYyqKorILvssmzaYbcvcesS5EqJ4kYGhZcBWfMtoagRh2GYHTyoLJ+kr6JKoS X-Received: by 2002:a05:6a20:3c8d:b0:18f:97c:976c with SMTP id b13-20020a056a203c8d00b0018f097c976cmr4119259pzj.84.1702206822535; Sun, 10 Dec 2023 03:13:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702206822; cv=none; d=google.com; s=arc-20160816; b=eEiHIjC2B26G/u6DXhTr+k2SnK2GfE3asW5Fh6MyGmcg8TbmxvwEq08Z58ZYWrVTgn OE85RvSfpxWxwNMFDnDPuFz13UtLaxI2M+sp81//CrQXeBS8yobGCAaQXFqWh8OvFLxF AUZfWV5Dm5x4gY/9Et927Y82dcE1M2ZP2P+S39aZCfDhGjv6dymtR59fEL04lsdtncRj FuZGnF4aco5NEowsi4aMhz6LYLo8dGg8H2M7XHwlEhrmzFz4KKy2iGdiUMTu/M7GB1He tOl00HAQfXv41lH3AXcZSLrwjr238cEygwKFSF5AFmqBBFYrvG5VK4Oq/MNGfxi0EC/k 6YAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=hlvSMPPWtkaeBqdtls/V0D5s82FybustbqMBgJOotgk=; fh=sCHgOfb9clrfrtYmVM0lv0/5DcKEVEdCtviECpVTaGY=; b=Hi5Lrid/24+RuWbdG1Ej19KGs6EFrRS8OVJzLWwInzo7Yjo45K1Nh55j+yPkaEhUnS Hd5G/ee27Kdkt5i6M4qG31JP1PNrc0XrCGQCLj624UWZp/zHZLkyn9ySstna7r+WKhGx IW4a/khdMeDBPca10veCPLPWHBkG7swSvaz5mtq1KH9wYbfX42MtEpaBSvkNc/D5mjKK wyp99joBK0pFsLkvASadyU9eux4ZhZ97tnth1BSxuhb2li2Eq+zXne+lNTtBiNBEVuKQ qAZz6puXd0cYjOIhiVUDYWlKb93RQe1JGskGXL0XJK40YSM+bTYHzHNE/StiiIHo7n7G /2aA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J5Trgazb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id e20-20020a656794000000b005c66a9e26f4si4330558pgr.289.2023.12.10.03.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Dec 2023 03:13:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J5Trgazb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 62A5E807CB45; Sun, 10 Dec 2023 03:13:40 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231890AbjLJLNY (ORCPT + 99 others); Sun, 10 Dec 2023 06:13:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbjLJLNX (ORCPT ); Sun, 10 Dec 2023 06:13:23 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0277CE for ; Sun, 10 Dec 2023 03:13:29 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3333fbbeab9so3322815f8f.2 for ; Sun, 10 Dec 2023 03:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702206808; x=1702811608; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hlvSMPPWtkaeBqdtls/V0D5s82FybustbqMBgJOotgk=; b=J5TrgazbG+5aVXdQZ2P/PZiwAyhctG1yfou8ldvb9Mvg/HaQX1V+S+gusUVMAU2QrT lIiJtLUKaU4aNeybsexOK+0nJhifLunufengDUExFOnamuX+srJQHOzTyI55gcl30W/b UEAVl65Yh8zr+GEf42tpKdpB7uVHkwqgOYAOqBKKyZY+YHcuYyelN+Z+NQEa3EBoCqvr SDN6racZ1EFjlpzYh5Gk8TAK5MfnU8NgetstGVxz/SK1jzCQ1iSDdb+n7NhAOECLE9R0 gQZozC9dIURRI7LSiiQ8XNP35OvWiPUGfM8piVCuHslOS7vengOqPkNyXMqOvm7+gX0a ZqAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702206808; x=1702811608; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hlvSMPPWtkaeBqdtls/V0D5s82FybustbqMBgJOotgk=; b=WJC1edoJ0TmJPnosD849KuwmfhWgQWeGwtv/1EppTJseQbl9nAWRN+g4PtxDHc/gxx LFic3jwqyU80KwiM3Wc/TyqQSn/3r+fD1+KZR6hq1F9Vt2abr0H4B+7CIKjjd7GBz+fg 5GEKMlAZQdNkVaikvXM7t4ozco/WoM1Loc8bBroFYoIB5Dceq9hl9bgTQSPAo1pkMDYu u4fzA8PdZ9L/0YLB6zqpHOcZuFlDduvwCbJRJXB4Uy0YDKjD1G+/rM6ueRDvxOHyDM/d vL6zCtvQ85G69cj9r/IxLeEBuqZtiOzzLIyQycIyf0F5scDReofGyy2c+7dJTsDs3ux4 7thw== X-Gm-Message-State: AOJu0YygOL6gKGzTBaszVjmQSM0sjMI2NDqYZz76OmlICiGRJFskiqja 2YEqcl55h8hZ8mG8zBHO0MpcoA== X-Received: by 2002:a5d:4411:0:b0:333:4862:8520 with SMTP id z17-20020a5d4411000000b0033348628520mr1319482wrq.138.1702206808225; Sun, 10 Dec 2023 03:13:28 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id l6-20020a5d4bc6000000b00333381c6e12sm6158472wrt.40.2023.12.10.03.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Dec 2023 03:13:27 -0800 (PST) Message-ID: <32b6437f-0e56-439d-8ebb-465e5230b18f@linaro.org> Date: Sun, 10 Dec 2023 12:13:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] arm64: dts: rockchip: Add support for rk3588s based board Cool Pi 4B Content-Language: en-US To: Andy Yan , heiko@sntech.de Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20231210080313.1667013-1-andyshrk@163.com> <20231210080547.1667421-1-andyshrk@163.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231210080547.1667421-1-andyshrk@163.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 10 Dec 2023 03:13:40 -0800 (PST) On 10/12/2023 09:05, Andy Yan wrote: > CoolPi 4B is a rk3588s based SBC. > Specification: > - Rockchip RK3588S > - LPDDR4 2/4/8/16 GB > - TF scard slot ... > +&i2c6 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c6m3_xfer>; > + status = "okay"; > + > + hym8563: rtc@51 { > + compatible = "haoyu,hym8563"; > + reg = <0x51>; > + #clock-cells = <0>; > + clock-frequency = <32768>; > + clock-output-names = "hym8563"; > + pinctrl-names = "default"; > + pinctrl-0 = <&hym8563_int>; > + interrupt-parent = <&gpio0>; > + interrupts = ; > + status = "okay"; My comments about redundant statues applies to all places, not only to one specific place... Best regards, Krzysztof