Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3375286rdb; Sun, 10 Dec 2023 03:18:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqR3+qYr4wj4e6FWNdK2LY5KSx5zk6yxf1ITYbVonEmul5UuflF43hcXHESiUTLS6qgaBW X-Received: by 2002:a05:6358:3393:b0:170:87e:8325 with SMTP id i19-20020a056358339300b00170087e8325mr3217028rwd.26.1702207113550; Sun, 10 Dec 2023 03:18:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702207113; cv=none; d=google.com; s=arc-20160816; b=qOwhfeJO1nTRoXla9KaQPN+rSOlAxk7NmIO5iDJhpFVNFdme4s/0lgwzOT3btkW4vN bpYz6BoKRgA42eyC6t96DM57FydKtNBYvRSgzTNGNCSvj+GKkuF5ZEDuyTS6WUr2vnnu 8Ta6FsjxG7OdWWGo8mct3x7M4af+DwhiQv64SwSv0cvnZIPBsufVvSsjEWczG5wzEUxE sTbLxaDbLvv54fmJ/u8RSMQzdKCo0RhzKK/rDnILZmL1HZmqn71NCe90i6/IUG+09CKL 2JG7Pl/Bg05zoLLWaC6g1QVHxnvNr0BZnz4azxFrKcwA/iMkgQisuD0UPYy2VButigph LPsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jPaNOXBoYCNpb+XRD4UhGj1uYAc8uzCHauTz8P60stI=; fh=P4WBa0AcsSAiexjDotw8XXwznjp7al+ZkUqpzOpDkec=; b=CIPrxOnZRZKLMqKatbh+GB9XzhtqnME1u3s7jhEa8f6TYn+nmiz00qc+WNg5iVxseM jns6n8q7adz7OTcLKFqx0seglWqN6VFELLOX3lFnBYCue0sf6aj8g59Fu2o+O0JZbq+0 T0eZEqxZXdzP61c98jgVn2fm3khKbE6CEra0/nD5VJ5Fhqe4lMjgRtwboF6XzQiSUPHg 8SuzrZJamvZl5NQc5ij25gf+gt9iJSe+mOKlynSpq0FoiyUYZZiZB7JJsYqwEs3YBvNw BGnB3SoTN3JmhuKrnIzeHadvyzvTFe1EZBaQsZuUoIDI0p0p1UiSmeBUIhDHMBt/sC+z WXtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q76oVVW2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id f5-20020a17090a700500b00286482dce1dsi5752730pjk.156.2023.12.10.03.18.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Dec 2023 03:18:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q76oVVW2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7314480658E4; Sun, 10 Dec 2023 03:18:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229611AbjLJLSV (ORCPT + 99 others); Sun, 10 Dec 2023 06:18:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjLJLSV (ORCPT ); Sun, 10 Dec 2023 06:18:21 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACBE6CE for ; Sun, 10 Dec 2023 03:18:27 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8FD7C433C9; Sun, 10 Dec 2023 11:18:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702207107; bh=Mw5kA6PMe+ZvyKQlipStk5punFjg+9Pr9d05A2L1hbo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q76oVVW2iIehrIoEA8eEUlj4ummxe3MSsPsc1RnGJGzbjkLTCA2+LkOjVd6rIKS+a t5Shq2mZJisdNP24G1xOmOzqHNEqLxZIE4qxCgIczs/4bKZL8iK1OPqPdzuk5BgQvt N0zUEvy3kgn3ULpvf8JbbakhYocahqZoNVpaaoVGBdKKYHXMwJJb8R5U5QcEl14mYo zwhIqjNnN9XyNLS021RboG0NHHkBBQZe8acGheiLFMkRX4ublkaXEFFvOKRs5riUaP x+R+NS2vZqOlUvEgqCIosMUIGKiZ+4W77mhY9CPi1C9e6xQ4y13kBKJqySCctGwngb NUF5DV6D00qPA== Date: Sun, 10 Dec 2023 11:18:20 +0000 From: Simon Horman To: Shinas Rasheed Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, hgani@marvell.com, vimleshk@marvell.com, egallen@redhat.com, mschmidt@redhat.com, pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net, wizhao@redhat.com, konguyen@redhat.com, Veerasenareddy Burru , Sathesh Edara , Eric Dumazet , Abhijit Ayarekar , Satananda Burla Subject: Re: [PATCH net v3] octeon_ep: explicitly test for firmware ready value Message-ID: <20231210111820.GE5817@kernel.org> References: <20231208055646.2602363-1-srasheed@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231208055646.2602363-1-srasheed@marvell.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 10 Dec 2023 03:18:32 -0800 (PST) On Thu, Dec 07, 2023 at 09:56:46PM -0800, Shinas Rasheed wrote: > The firmware ready value is 1, and get firmware ready status > function should explicitly test for that value. The firmware > ready value read will be 2 after driver load, and on unbind > till firmware rewrites the firmware ready back to 0, the value > seen by driver will be 2, which should be regarded as not ready. > > Fixes: 10c073e40469 ("octeon_ep: defer probe if firmware not ready") > Signed-off-by: Shinas Rasheed Reviewed-by: Simon Horman