Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3428257rdb; Sun, 10 Dec 2023 05:32:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGsnKm9JcywueFYKFf/yHxCHVIFL29maPpbcQBgdBl8BpUv7F0CRDZtYOLzDJYxoLpCwq/i X-Received: by 2002:a05:6808:10cc:b0:3b2:f500:c1e5 with SMTP id s12-20020a05680810cc00b003b2f500c1e5mr4593252ois.29.1702215165604; Sun, 10 Dec 2023 05:32:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702215165; cv=none; d=google.com; s=arc-20160816; b=bcjNuZNWXILCRq0wNzB6qcW2bXfm6XFvvHhWHyaUhKy7Lc31OYL/lm8NWeunXglPvM eRJhwdqawPMv07mUXvxNbe0NTnSu8hUhO9YtjAS0ry42QAgd9MOqfrQGQdQ/F4ck5XEm T/SMqwp1Ob4DIIzPJDcQ+6I93HpHSms8+DQmmzNjzEgDK0Tl3x97coVTjdV1nL4uOVX1 FYjo0x7lZMBH9vEgXaGLocf0QKuP6odSwuWUvZDIIXQJuvGc3/MFeiJaPuBVq+Ma7dPP FKAMLZC8FXHCoxH03rUglPPZc+lP0y18hyiOByaOOPMA+noU8nx9+tjH0C6StFIXsE/i H7XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=f9I6f2NbtmngUvLct/eZ0vv/+LbPWM+zgIT4PIeBvIU=; fh=1oqsWjDVdDGf/gH/OPn52TNjca1ZCJSEn883HLj2yvo=; b=O9iqz2rKlotX9Q5GHT87yvEg50DPXOVLHNV8xeUkEM/aMfDAnXVJaQGm62wsnDUZGw /EjdgltmhAw+N3SvDCCnrOXNAkyn/iVS0OOy1dLToUH0FVZ0XZgVgduI1wvFEMO/t6L7 oR5vgCa2M+R8zSTMNQxylnHGn2W5I0W0eh+GsEX5QalAI4lHAA/+wnFSpLwyhYwc94Rw 4qB/eZUB/W3/z0Kheq/VUlRHzoT1S9fHb1Twv9AE11GmmRgEFauW+FhPfLijaj76wmMw nJAgMfDR2WTxt3e7BRBjR0zWkNKlvzBZ1eWHhfpYH69WzYSWTL420JJnQ4rAyMdwFsaV wqnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pMDWKvtF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id bw42-20020a056a0204aa00b005be00212aa7si4633258pgb.663.2023.12.10.05.32.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Dec 2023 05:32:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pMDWKvtF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 2FE5B80687D8; Sun, 10 Dec 2023 05:32:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232146AbjLJNc3 (ORCPT + 99 others); Sun, 10 Dec 2023 08:32:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229584AbjLJNc2 (ORCPT ); Sun, 10 Dec 2023 08:32:28 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D64CDF for ; Sun, 10 Dec 2023 05:32:35 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47975C433C8; Sun, 10 Dec 2023 13:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702215154; bh=648SWHIYNJDT/+aiucrXnkcL7Mil/8x5gJTHL49sKWY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pMDWKvtF+c+gtQLFvWS7ZcoEriiLmbqJDSvCnPeAuqmNmIs6jVsQrCrFItuDo+o0u XKsWQeK2qjQInSI+oT9SGX2cLtX8onqoETF2EldZuU1uWUOgjP3UF3Uvb2ztp0VXvr qlVlrvRGYbtkzSR6q5N+s/0710ZAiGWs1KywxDmJK9XnWlFkMaPh4T1hI8uGj2OIWO DrQmxNzCxuAtMjk9z4H/nertu0v9pHWH952DH3W3rkkUoKWVeI6yFK/Fcq08gbQUrk puPyFEDILYjoqEHwz0Gdw8CFwo11Act6UIVgJ/1GMEW4f3jl7mBhqPF+VnE3Q6Fnsc jodWG3KoIWGxg== Date: Sun, 10 Dec 2023 13:32:28 +0000 From: Jonathan Cameron To: Dinghao Liu Cc: Lars-Peter Clausen , Alexandru Ardelean , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: core: fix memleak in iio_device_register_sysfs Message-ID: <20231210133228.5fd425ea@jic23-huawei> In-Reply-To: <20231208073119.29283-1-dinghao.liu@zju.edu.cn> References: <20231208073119.29283-1-dinghao.liu@zju.edu.cn> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 10 Dec 2023 05:32:43 -0800 (PST) On Fri, 8 Dec 2023 15:31:19 +0800 Dinghao Liu wrote: > When iio_device_register_sysfs_group() fails, we should > free iio_dev_opaque->chan_attr_group.attrs to prevent > potential memleak. > > Fixes: 32f171724e5c ("iio: core: rework iio device group creation") > Signed-off-by: Dinghao Liu Hi. Looks good to me, but I'd like to leave this one on the list a little longer to see if anyone else has comments. Jonathan > --- > drivers/iio/industrialio-core.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c > index c77745b594bd..e6d3d07a4c83 100644 > --- a/drivers/iio/industrialio-core.c > +++ b/drivers/iio/industrialio-core.c > @@ -1581,10 +1581,13 @@ static int iio_device_register_sysfs(struct iio_dev *indio_dev) > ret = iio_device_register_sysfs_group(indio_dev, > &iio_dev_opaque->chan_attr_group); > if (ret) > - goto error_clear_attrs; > + goto error_free_chan_attrs; > > return 0; > > +error_free_chan_attrs: > + kfree(iio_dev_opaque->chan_attr_group.attrs); > + iio_dev_opaque->chan_attr_group.attrs = NULL; > error_clear_attrs: > iio_free_chan_devattr_list(&iio_dev_opaque->channel_attr_list); >