Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Fri, 8 Dec 2023 20:22:54 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Nikolay Borisov <nik.borisov@suse.com>
Cc:     X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2] x86/ia32: State that IA32 emulation is disabled
Message-ID: <20231208192254.GCZXNtDjT73Z4L06h/@fat_crate.local>
References: <20231130155213.1407-1-bp@alien8.de>
 <20231130160903.GJZWizn+dPaaViFVKN@fat_crate.local>
 <20231206172022.GCZXCtVoZtt4t2TLpe@fat_crate.local>
 <4f232dfb-a112-4271-8f43-f85a02c4abeb@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4f232dfb-a112-4271-8f43-f85a02c4abeb@suse.com>
Precedence: bulk

On Fri, Dec 08, 2023 at 08:42:29PM +0200, Nikolay Borisov wrote:
> > +static inline bool ia32_enabled_verbose(void)
> > +{
> > +	bool enabled = ia32_enabled();
> > +
> > +	if (IS_ENABLED(CONFIG_IA32_EMULATION) && !enabled)
> 
> nit: But why check config_ia32_emulation explicitly, its state should
> already be accounted for in ia32_enabled's value? So this check can simply
> be 'if (!enabled)'
> 
> > +		pr_notice_once("32-bit emulation disabled. You can reenable with ia32_emulation=on\n");
				^^^^^^^^^^

If CONFIG_IA32_EMULATION is disabled, is there any 32-bit emulation to
be enabled, at all?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette