Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3578558rdb; Sun, 10 Dec 2023 11:11:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IFo4+r9uls9/L1orXPET63YJKlRpJb1gD7Z3ZWvNzUmYkMrKe4UMxVPjXz7hYPLFc+SJa4j X-Received: by 2002:a17:902:ef89:b0:1d0:6ffd:ce9e with SMTP id iz9-20020a170902ef8900b001d06ffdce9emr1137747plb.87.1702235472486; Sun, 10 Dec 2023 11:11:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702235472; cv=none; d=google.com; s=arc-20160816; b=os3WaaGnYKS6tsivhMKgpSoIQwhUg4w8BYdzEeuABAXOZ1MMvXi3R3CuhXUYZ9LP0s BJ0sxkCB8sGFZ+SqjvUviAlEBbdrJPoT3Y6d/1pAhweK6ukP1bQSl03gZTQ03XjPEVCU q6R1opULdBWurCk1XKdfiN1J/0Ta1IzwwX7HHdx6aIsvS9k9OZ5rWMvfmcK5ZvRigsxs Ulz+JcnStt0Gv4abLmQz+5xOgxCUJFCHKqLlrqLVSroFw3+l4J9b2K0JLA9KT9xeLZyp 0uJvSFnu+Q6j8ox+nY4PYKlbe2g2wy5dtBJODN1VTlb74Dlh1w2H/8x9TbxIivQRqsF9 UDkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=ow3hqxbK8D2XRGKcf8C0jdJKU1gOV0op1HCzfhViGjM=; fh=1iKl4dcUMiuhDgwX/SC/1rvW5RZF+C4ynlVvofhmSPw=; b=n3bCV4hpBKiHOVRhYyq++usf7N7+7LsB44t1QTwpXURbUewaQHzlt+M3PK+dXf/eVu U2PlvgKHfllb+b3TkmfmlZPtLZqUTUShyo72vcgbaCMuvcwce+3N1fjmbg5H8VTKXfC8 YPCb5ZWJWNtyvNJsa64g2HLYq7JuXFFKBLO90EVl48qo5vilKE41osZliAeSwJIIohyN E0JNfVJ9dFSN6J5Wb2ozIHbM6hBO71szxOzkxQFnJ8WwCfUTQYh6wjKMx30gpFtTWmIV FmFjlYSj0m1EzMSuRozRHq7hvDqAIcTmT/zFy5zfBk7teIN+0bu+MwY02DqT67gMvYAa Go0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NL2apv8f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id i6-20020a170902eb4600b001d0b6caddbbsi4840686pli.545.2023.12.10.11.11.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Dec 2023 11:11:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NL2apv8f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id E94898080EE1; Sun, 10 Dec 2023 11:11:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232027AbjLJTKW (ORCPT + 99 others); Sun, 10 Dec 2023 14:10:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231486AbjLJTKT (ORCPT ); Sun, 10 Dec 2023 14:10:19 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 095D7ED for ; Sun, 10 Dec 2023 11:10:25 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPS id 78E99C433CA; Sun, 10 Dec 2023 19:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702235424; bh=eQ0/407KP3HhnrTVlfGnfnwd1/ssbYotrJsWIdFbWhU=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=NL2apv8f160BY5bvo8LX+976+HJNoGlmwgKPzn4+GB2GwtUCa5L0Fg+XjIksXp+zy iKlbAdsvpc8Ccw0SbYWcGt7BKUlu8iPgVBAu/NL47WptmhFN3wjqzW0OickVEzWUib Mi8xckIizx++hO1BvZ2NHNd623vv9gXWBveTVf/KncV6zQplMkhFfQS+wqkmCHPZki qvqe72evzaq1YfS4Bb0mL8McEvbFapBryCVeC1T+2OWhiy1LUVZlB7Q44pk7Xe2vNS q6GOGxy5AZiuWwQ21SDlxt5BeypA6YZxA0IsXFfbQRsQ0nsJC3SPUA9PCctWJlzP8J 4THE2FO5yITBA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 5EED9C595D2; Sun, 10 Dec 2023 19:10:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] qlcnic: replace deprecated strncpy with strscpy From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170223542438.32670.7822552798580562858.git-patchwork-notify@kernel.org> Date: Sun, 10 Dec 2023 19:10:24 +0000 References: <20231207-strncpy-drivers-net-ethernet-qlogic-qlcnic-qlcnic_83xx_init-c-v2-1-eb1a20a91b2a@google.com> In-Reply-To: <20231207-strncpy-drivers-net-ethernet-qlogic-qlcnic-qlcnic_83xx_init-c-v2-1-eb1a20a91b2a@google.com> To: Justin Stitt Cc: shshaikh@marvell.com, manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 10 Dec 2023 11:11:10 -0800 (PST) Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Thu, 07 Dec 2023 21:42:22 +0000 you wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We expect fw_info->fw_file_name to be NUL-terminated based on its use > within _request_firmware_prepare() wherein `name` refers to it: > | if (firmware_request_builtin_buf(firmware, name, dbuf, size)) { > | dev_dbg(device, "using built-in %s\n", name); > | return 0; /* assigned */ > | } > ... and with firmware_request_builtin() also via `name`: > | if (strcmp(name, b_fw->name) == 0) { > > [...] Here is the summary with links: - [v2] qlcnic: replace deprecated strncpy with strscpy https://git.kernel.org/netdev/net-next/c/f8dd2412ba66 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html