Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Mon, 11 Dec 2023 00:08:09 +0000
From:   Qais Yousef <qyousef@layalina.io>
To:     Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        Lukasz Luba <lukasz.luba@arm.com>, Wei Wang <wvw@google.com>,
        Rick Yiu <rickyiu@google.com>,
        Chung-Kai Mei <chungkai@google.com>,
        Hongyan Xia <hongyan.xia2@arm.com>
Subject: Re: [PATCH 2/4] sched/uclamp: Remove rq max aggregation
Message-ID: <20231211000809.qostlrd5bka6cvak@airbuntu>
References: <20231208015242.385103-1-qyousef@layalina.io>
 <20231208015242.385103-3-qyousef@layalina.io>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231208015242.385103-3-qyousef@layalina.io>
Precedence: bulk

On 12/08/23 01:52, Qais Yousef wrote:

> +/* Request freq update on context switch if necessary */
> +static inline void uclamp_context_switch(struct rq *rq)
>  {
> -	return static_branch_likely(&sched_uclamp_used);
> +	unsigned long uclamp_min;
> +	unsigned long uclamp_max;
> +	unsigned long util;
> +
> +	/* Only RT and FAIR tasks are aware of uclamp */
> +	if (!rt_policy(current->policy) && !fair_policy(current->policy))
> +		return;

We have a dependency on min_granularity_ns (or base_slice_ns) here that
I forgot to add before posting.

If our base_slice_ns is smaller than dvfs_update_delay, then tasks won't run
long enough for the hardware to apply their performance hints before they get
context switched out.

Beside the new proposed sched_runtime being able to request a smaller slice; in
practice default base_slice_ns is okay-ish.

> +
> +	uclamp_min = uclamp_eff_value(current, UCLAMP_MIN);
> +	uclamp_max = uclamp_eff_value(current, UCLAMP_MAX);
> +	util = rq->cfs.avg.util_avg;
> +
> +	if (uclamp_min > util || uclamp_max < util)
> +		cpufreq_update_util(rq, SCHED_CPUFREQ_PERF_HINTS);
>  }