Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <05b90060-9bee-42db-a49b-eb73dce0d59c@amd.com>
Date:   Sun, 10 Dec 2023 20:03:22 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ASoC: Enable built-in microphone on Lenovo ThinkPad P14s
 Gen 4 (AMD)
To:     "Michael T. Kloos" <michael@michaelkloos.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Jeremy Soller <jeremy@system76.com>,
        Syed Saba Kareem <Syed.SabaKareem@amd.com>,
        August Wikerfors <git@augustwikerfors.se>,
        Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc:     linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231211015325.6793-1-michael@michaelkloos.com>
Content-Language: en-US
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20231211015325.6793-1-michael@michaelkloos.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUxvMnhxUE4yZnRTVkQ0QmNCZjJKazR5Zi9DaXdpQjg5UmQrY2Q1a0taSmM3?=
 =?utf-8?B?M1FUTVl3V2xqaVlDT2RUajRPTmtZY0sxR0hxWnZhcmRYVzI3cS9KcWFGWkdK?=
 =?utf-8?B?L0Q1S0lYdFNFZllVazl4NzEwRVlReUdsc2FrYjFEb0xlVDBta2ZET0Q1UzQx?=
 =?utf-8?B?L0FiNUZjQUd2Ry8reVI5SFZLcml5cHdMSk9nV3E3dTljdGFKWENIbVgydmdz?=
 =?utf-8?B?bUJDNkJ5amI5MGJNaWdMYXE4WjQ2RmRLWmt1UEVnaWh6d1VBeWJ0Z0VNbnFi?=
 =?utf-8?B?aDZFWE5Fc3NMRmNHZXJ1RTV2dUFPcXdCZG9JYWtndmR0eEFUTHU0T3JBcVMr?=
 =?utf-8?B?K09LL2E4bitEN3pNT0wxQzBibFVESVVqUUNWV0xvMkE3QjV3aUptc1N0TDQ4?=
 =?utf-8?B?QkV3V3VTbWc4VGU4SU56TnliOU9VWU1HeURMU1NKKzBLNFVXT3AyTWZnNkxq?=
 =?utf-8?B?ODZDMG9RcWNIRDdVM0R3dVE3YThJSzBxTkdzS2lJck9HWkM2bHRaWXY5NG5K?=
 =?utf-8?B?U2tSVVJhbGY0S2JoNi9XQ01PQWN2MlZ4MkJsektVU2RMd0dYVzJJQmhMVDlF?=
 =?utf-8?B?cy9wOGJ0UitiODBpWng3bWpVQmhNZlUyVFk1RkVhWFRQaFJUWXRiclI4U3pR?=
 =?utf-8?B?bERVTVVzWEs4dVYwSUlHRnIvYkNFbUphQysyL3ZWendtd0srVHY0TUlDN1cy?=
 =?utf-8?B?ZDBQdGVOR1lsMEV1UHhlQ2VEd1ljdXN5eCtBOW5PQUdHcEUreDlwK2pOc2I1?=
 =?utf-8?B?bmV3MXZMay9DbTR6STV0NWJac1VubC9xSllaS2xPM0JvellqSWMrSitVLzQ1?=
 =?utf-8?B?SUlpckhuVEU2Mlh2c1Nhb1AxbG5GbiszQkw0alpjbGdVNkdnaC9SVllIWWhp?=
 =?utf-8?B?dGF0d2kyYUlTNWFKQ2ZHODZmRGtxakJBYVlncGpxVURJdEpRUllaSXgwMnp3?=
 =?utf-8?B?VzBkbmo4TzRGZXo0TVJMMEhoT1ZZT01UT0ZaK0M5YlNkK21kbXJmSkV6eWNZ?=
 =?utf-8?B?VENxTWFPbDI2Zk5JbDhrYlhaOGs3dUVIVktxd1hzWXJ3YXpZenlWQ3o2STZT?=
 =?utf-8?B?d1dMTVUzM3plMURiTUJ3UlNjVEpxN0lWR3FOdGhaNkVZU0VTN0dCNFdkckxL?=
 =?utf-8?B?RisvTTNGUXExL05ncXUxL2MxUlYrTmQwYnJZZFNRSi9hVUFZaENuQTIwcDc4?=
 =?utf-8?B?RzJFYWxTNFVyLytIaTdGdTloUlo1S2tlNHBLRzVISDQ2Zlp2dmlUZ25NaWRn?=
 =?utf-8?B?dXlWNjgySTlvME1HRzhXb1ROZWNpVTFRdmZmZUxtbERad1QzR0Y5RFk5UHdB?=
 =?utf-8?B?d1hNUFdCcTZia0RpVjdIQUZFWTI5amdHSW81VVNMM2k3ODB5c3FqemxPZ2ZQ?=
 =?utf-8?B?eW5LNG4rQ0xUeEsvV0Zrby8xN2Vta0RYbXVtcjhHNXlGeTd3QWtUQnBqSXN2?=
 =?utf-8?B?ckNOTlpuM1ZyM2FJSjQyT25EY2g4bUU1YW5FMGVHVUYwN0RFR2lqZGdGL08r?=
 =?utf-8?B?Q1VjS21aT2ZUZms3RlhjQ0YxV0Ixa1U4NGZBWnhGOWpOM3Bia1cxcG10RlN4?=
 =?utf-8?B?OVJ0cUJQdlZUZnl4MVFjdmdqUVhTVlNMMmlweW1NbWJzS0RHVExTZTVwRXpn?=
 =?utf-8?B?YkZnNkc1Nm9NdFR2Yi9yVGd3M1QxMGhXQU1pUmVWOXJhWjlqRFRhb2V6R3Zv?=
 =?utf-8?B?TFVZU1ZTMHp4eG8zdUtrbVRYbTR5Y0s2cUIwSGtSUWdnUWVQYTZDa3JrNHFC?=
 =?utf-8?B?TWdDQzRRQ3oyRmV5NnY1S0VjdjJQWklTS1dnNTZYVnpFZGUrRXAza25FYW5O?=
 =?utf-8?B?ZHZRQlVwNmhseE5ndHRYWVlRRnJaWjZhb3ViMllDa2xjbjdCUVA1SlhWYnZt?=
 =?utf-8?B?QlQ1NWZ0dGJaN0h6YzRlRU1rWVFMaHlHZm92Vjh5ZHdCZ05UT2dRTVhlK2Zw?=
 =?utf-8?B?TkI1ZjJCYWlaM0Y4L2doVnd4L1gxTzVkdml2N1FKanc3RFpNdzFmc1V5a0RK?=
 =?utf-8?B?eFd1dEhmdGt1eGN2TWZBVHdNazcvUzJFMUJXbHM2bDQxUGd1RlNGSzI1NlRW?=
 =?utf-8?B?bVV6NElFbFhSeHNHcE9nQVFuU3dlT2liSmxSVldPaTZlSlRjL0RCK21IRVBV?=
 =?utf-8?Q?chGgjWaKimtRGsrKJfg9+iOln?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54f704ea-f246-4595-6edc-08dbf9ed5c12
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 02:03:25.2643
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PEw5EkMfAYy1OS1UhgsmjGBuLal6OEI/UBjivgDLt09/xNHgjTHF7r+IqP4VC9PhO0zkmeEDR64KmbsA9DSMVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4569
X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 10 Dec 2023 18:03:46 -0800 (PST)

On 12/10/2023 19:52, Michael T. Kloos wrote:
> Added System Board to Quirks List using model number prefix.
> Replaced/Removed a duplicate entry in the list.
> Added Yellow Carp Coprocessor Revision number to PCI revision check.
> 
> Signed-off-by: Michael T. Kloos <michael@michaelkloos.com>

NAK.

This is supposed to be supported by ACP 6.3 (Pink Sardine).  Did you 
enable that driver?

Can you please share more about your problem?

> ---
>   sound/soc/amd/yc/acp6x-mach.c | 2 +-
>   sound/soc/amd/yc/pci-acp6x.c  | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index d83cb6e4c62a..c08605d99bc9 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -56,7 +56,7 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>   		.driver_data = &acp6x_card,
>   		.matches = {
>   			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> -			DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21K5"),
>   		}
>   	},
>   	{
> diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
> index 7af6a349b1d4..694b8e313902 100644
> --- a/sound/soc/amd/yc/pci-acp6x.c
> +++ b/sound/soc/amd/yc/pci-acp6x.c
> @@ -162,6 +162,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
>   	/* Yellow Carp device check */
>   	switch (pci->revision) {
>   	case 0x60:
> +	case 0x63:
>   	case 0x6f:
>   		break;
>   	default: