Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3720343rdb; Sun, 10 Dec 2023 18:46:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEl5/iG9q9vcZaobGszvnd5eahrXf9fYWYbVBAZ/5AouD0RzU5d8ZkLZWr/fyClslG5VoQ X-Received: by 2002:a05:6870:b155:b0:1f5:cd12:260f with SMTP id a21-20020a056870b15500b001f5cd12260fmr5654245oal.26.1702262799329; Sun, 10 Dec 2023 18:46:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702262799; cv=none; d=google.com; s=arc-20160816; b=FbybdH6SfxMrd0IWZkqCctkTWVx7EHqwW6JUdBCdMTWLrHIp5JH1qDW00rONXDnOgO o351R5fLd7TCD0eAzMogOayzvcVnD+7dsX/95OTS7+E3v6GixDQO8mN721p1cPvvT0JK egqUezbMD0xMjd/hGiI9X1ePxT7adhxkC6WAPVAws4Y8/pFh5QW3dOG2t8Uu0KEi+GpC 8ymad5AagkHaxpBRHhXKAltdIjdOfqxFQ6GT3k1msd1s2HVC/vBgz1W4G4p8Apcc8Ea4 5csSFnq0lGEtSw/8nCWThWt4EnC+k2FKedFcuVWpWC9j+ufBFOCHZ6Dk4ZLQfoP9eGQD bnjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=l9qQIoshMkhHAse7aD2AVMS0ndllk3aoWf/hZYyqUTk=; fh=RBJUN28e3bUW3BQOzrokO2BRuv77YS3zXOqoxzq6Bk8=; b=WOBEvD/3R+v7nBJaUZ3o7SO5SP99CU6ncn+mrxPrKFllFxABuJ6jDGSk8dYp1909oA qF/O3Je8Q2N+K8as0bkZhNq+SMOWV0wlB1uhIjAeC3pr/1Jj0eShUP80W2zewuZWDoGr JS8O+RP53CbCS99PIQ4vSibW6kRGC0Tjx+3HGuZkBth+xx4+mCHaafimZ+tmbko7N/Yw 0kNMNd5AqrOfpSKxXamxuzCCQMIvrV1i6O28KULjrSECeJDE7/xzIPjQrnrpm4W/1Zz2 Jm1/5j9skJkRf0NREIZBDI0Aa4znuIIgGhYWTYjWXzsjUg2733cFhgvTU6hA2hBTfhrw 21dQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id a3-20020a631a43000000b005c6c9572a4esi5199224pgm.582.2023.12.10.18.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Dec 2023 18:46:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id D368380622B0; Sun, 10 Dec 2023 18:46:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229589AbjLKCqV (ORCPT + 99 others); Sun, 10 Dec 2023 21:46:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbjLKCqU (ORCPT ); Sun, 10 Dec 2023 21:46:20 -0500 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32CAFCD; Sun, 10 Dec 2023 18:46:20 -0800 (PST) X-UUID: 604e44b7d04e4017b11d88a4d764afb4-20231211 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.33,REQID:66b8a00f-9032-47dd-b89f-1d95c3541f3d,IP:15, URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:-5 X-CID-INFO: VERSION:1.1.33,REQID:66b8a00f-9032-47dd-b89f-1d95c3541f3d,IP:15,UR L:0,TC:0,Content:-5,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-5 X-CID-META: VersionHash:364b77b,CLOUDID:799ea173-1bd3-4f48-b671-ada88705968c,B ulkID:231211104556XNYUBAOC,BulkQuantity:0,Recheck:0,SF:44|66|38|24|17|19|1 02,TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,CO L:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 604e44b7d04e4017b11d88a4d764afb4-20231211 X-User: chentao@kylinos.cn Received: from vt.. [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 302373159; Mon, 11 Dec 2023 10:45:53 +0800 From: Kunwu Chan To: andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kunwu Chan , Kunwu Chan Subject: [PATCH] net: dsa: vsc73xx: Add null pointer check to vsc73xx_gpio_probe Date: Mon, 11 Dec 2023 10:45:49 +0800 Message-Id: <20231211024549.231417-1-chentao@kylinos.cn> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 10 Dec 2023 18:46:37 -0800 (PST) devm_kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Cc: Kunwu Chan Signed-off-by: Kunwu Chan --- drivers/net/dsa/vitesse-vsc73xx-core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/vitesse-vsc73xx-core.c b/drivers/net/dsa/vitesse-vsc73xx-core.c index e6f29e4e508c..f136eb5aea69 100644 --- a/drivers/net/dsa/vitesse-vsc73xx-core.c +++ b/drivers/net/dsa/vitesse-vsc73xx-core.c @@ -1135,6 +1135,10 @@ static int vsc73xx_gpio_probe(struct vsc73xx *vsc) vsc->gc.label = devm_kasprintf(vsc->dev, GFP_KERNEL, "VSC%04x", vsc->chipid); + if (!vsc->gc.label) { + dev_err(vsc->dev, "Fail to allocate memory\n"); + return -ENOMEM; + } vsc->gc.ngpio = 4; vsc->gc.owner = THIS_MODULE; vsc->gc.parent = vsc->dev; -- 2.39.2