Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3724004rdb; Sun, 10 Dec 2023 19:00:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHtJDPbEhesIixCcTVJdq3+AYycgpKPiTr8JFku51FuyQhgLqFxvms5KTpfW2+5cRQC+knM X-Received: by 2002:a05:6808:1710:b0:3b8:b063:5d77 with SMTP id bc16-20020a056808171000b003b8b0635d77mr3736383oib.94.1702263601014; Sun, 10 Dec 2023 19:00:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702263600; cv=none; d=google.com; s=arc-20160816; b=JDV3yKF4BPZAYOPBi3nxi4u3OQ5j/P4zraKXDGczuH5BA/fThfeY59quCdNh3d3BvH KbpvHwu08mekdFwHJor/dWkz/8sI0i+eooiBhEzaKBgMZ3UhiStBIfI5g6QO1rsTJmTv SoWnWn6y9JQY6OHaiUwTbRtZQDB1fuRMI3Nu+g0GdiiXXmsGquKShiaUkpKqMHX0LU9a vBbZbK3nkjFQRhfMHad14dbtqCyxJjmfE4Suasos2uU7RhXCVrLuhjc9YsBLh8tdQ4pc FutI6TVN0+GEEU74/2w93OhPgegfSiTOOdE/xT1vBxcXqNdkzX+FLoK3zYEUPUfv5SCL JuCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=uogfaX9VHI7SqZmmGTRoaY28x7c0ryHA0O9azwdMUpY=; fh=BGRxrkfGVuH1vwaTE7h7o0qAEHz+H7n7hzW6m74zBa0=; b=kRdJlQJkx731OgoovO2AcgdmHnwFLsgE9vyxPY5TESiKFtKgNZAUGVgbE2dtT+1lhm QsPjkpTEwT4PH2NcGacWjnD3Wx0FIPW8DxHZqfxDk4WMAEg5iypjcFxb9zg7l702WtzZ XHSaCr7JexVDed0PmbBSr44fneZgejd30Ivx8lePdaX23HuejM0ScxGHF2WGiK4DplNt I27ftnUIqJh6m5krBP7lwRhnTqEiy/7Y6JOHYSSOjnoQ2c/xyBfr5blUXekMFdZukLac h/t9YYGAmeUd3Ju4NbuXXpwisaI/X/dXODQ94FDrQXZ03xtgJx9EVb3k4SB2O4bELqI1 2VRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id p20-20020a63fe14000000b0059d48c43152si5436706pgh.40.2023.12.10.19.00.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Dec 2023 19:00:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id D683D805E11B; Sun, 10 Dec 2023 18:59:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbjLKC7p (ORCPT + 99 others); Sun, 10 Dec 2023 21:59:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjLKC7o (ORCPT ); Sun, 10 Dec 2023 21:59:44 -0500 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0327ECE; Sun, 10 Dec 2023 18:59:49 -0800 (PST) X-UUID: 0b105c8e154d4308be340be35614f20c-20231211 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.33,REQID:19a20f34-c316-4582-9f89-476ca1073edf,IP:5,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-10 X-CID-INFO: VERSION:1.1.33,REQID:19a20f34-c316-4582-9f89-476ca1073edf,IP:5,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:-10 X-CID-META: VersionHash:364b77b,CLOUDID:931283fd-4a48-46e2-b946-12f04f20af8c,B ulkID:231211105935IA61I4Z6,BulkQuantity:0,Recheck:0,SF:38|24|17|19|44|66|1 02,TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,CO L:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FSD,TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS X-UUID: 0b105c8e154d4308be340be35614f20c-20231211 X-User: chentao@kylinos.cn Received: from vt.. [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1052257917; Mon, 11 Dec 2023 10:59:34 +0800 From: Kunwu Chan To: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: jacob.e.keller@intel.com, przemyslaw.kitszel@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kunwu Chan , Kunwu Chan Subject: [PATCH] iavf: Fix null pointer dereference in iavf_print_link_message Date: Mon, 11 Dec 2023 10:59:27 +0800 Message-Id: <20231211025927.233449-1-chentao@kylinos.cn> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 10 Dec 2023 18:59:59 -0800 (PST) kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Fixes: 1978d3ead82c ("intel: fix string truncation warnings") Cc: Kunwu Chan Signed-off-by: Kunwu Chan --- drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c index 64c4443dbef9..1b50d351f28b 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c @@ -1444,6 +1444,8 @@ static void iavf_print_link_message(struct iavf_adapter *adapter) speed = kasprintf(GFP_KERNEL, "%d Mbps", link_speed_mbps); } + if (!speed) + return; netdev_info(netdev, "NIC Link is Up Speed is %s Full Duplex\n", speed); kfree(speed); } -- 2.39.2