Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <ffcacd0f-85a3-4c9f-9d0d-50425fec4775@os.amperecomputing.com>
Date:   Mon, 11 Dec 2023 11:09:08 +0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/2] i2c: aspeed: Handle the coalesced stop conditions
 with the start conditions.
Content-Language: en-CA
To:     Andi Shyti <andi.shyti@kernel.org>
Cc:     Brendan Higgins <brendan.higgins@linux.dev>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@codeconstruct.com.au>,
        Wolfram Sang <wsa@kernel.org>,
        Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
        Guenter Roeck <linux@roeck-us.net>, linux-i2c@vger.kernel.org,
        openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        Cosmo Chou <chou.cosmo@gmail.com>,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>
References: <20231208033142.1673232-1-quan@os.amperecomputing.com>
 <20231208033142.1673232-2-quan@os.amperecomputing.com>
 <20231209202810.r7kkz2hlaonyibha@zenone.zhora.eu>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <20231209202810.r7kkz2hlaonyibha@zenone.zhora.eu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1paRmlnaEJibVFIWEx1OFJSUkNTL3F6NGZrWG8xRWRVSlh2c3dHQjlMUE85?=
 =?utf-8?B?OGNRU0FFNlNLdWROUlJJY3NzVk9RTnozMzRUOTZ0d0Q0MG81eENTMm41ZjZJ?=
 =?utf-8?B?ZHQ4OVdKL2tPN3BBeUNRYWpHNGM3eUtGUkQ4dk1xYVB3UGhYSFIxbXFRTE5p?=
 =?utf-8?B?WjJNd0tiSnVWd0RkdWh1c3NoaVBPSnZ2TkdZeUdnUTJvMGNnS1NjZzlhMkVS?=
 =?utf-8?B?dUNJcDhPNlJ5ZW82VmZBK1h0T3VxSWdJa1VKdE4zRG5hTHJERXBsTVluV2VR?=
 =?utf-8?B?R2lMMG5KZjNNNUNwaC9uMHRjaHdWekpzUTkyVUp6ZEY3ajVQM2V3RDhPdVpq?=
 =?utf-8?B?aWZxd1NEM0FDRGZqS2h2S1pxOWZvL2FoSnJYbDJOOFB5c2poUTRDamFaalVt?=
 =?utf-8?B?aHFlKzlna256dGcyQ2ZvamM1ZU1jOHVkOFB2M2RlTWQra3U1UnppMkZWaGZv?=
 =?utf-8?B?RkRSeGYvTWJxM2FoK0tYcUgrNjFoWFA0V3F5TXo4eFNKMWR6VWpyb1RLamVR?=
 =?utf-8?B?Tk5zbGVENThuOXBQeEk4UyswS1Q4eHZCdUFiaWNueGV1WHdoZUlEQUNVaWxR?=
 =?utf-8?B?M3pka2hXR2hTM2l6Q3pSbjE2Ky9lSUMzUUtSWStxQ1VNaVdoQ0pEaUpNYnBV?=
 =?utf-8?B?MzB2dFRMQm42OGJMZmVaZEExYjNuQzczUkIyclN3UEx2MWwvMWNIV212QjlL?=
 =?utf-8?B?bEhCMnJYbEtkalRYV3E0VnNIc20vVDFEcEZOdmtDLzFJMDd1T043V2hlTUo4?=
 =?utf-8?B?WERWRDRXY1VEVHFSRWxQYnRFSHFVN0VoZER2UStYOW9TY3JUNlNnaFd4dVp2?=
 =?utf-8?B?MytLclFmTU5RZTN6eHRNZVUxZDk1a3J1SlRJMnVaYkJSanE5dy9UcFpZcW5K?=
 =?utf-8?B?c2V6amhVYm9HMmdmNHIyZ0NtUUpwT0hyT1Y4VmwwTU9LTXhNS1V3Y21uRDl5?=
 =?utf-8?B?cEF4NmlHenFJRDZtZVNYYTAwNXY5dVNKUWtpNEtzRXl0WWt5ZC9udXNNY041?=
 =?utf-8?B?d1FGVSttd0hBQnE5OW1ZUlJxeS9keldXdWcyWlRNQWxrYWVXV2c0OXZZaUZZ?=
 =?utf-8?B?d0gxdEN4QUdqR1d1ZDcrU2drOGgyQ0s5cU5iK2orT2Zvd0F3Z2pObk0yREM4?=
 =?utf-8?B?a25GMlpuRVo0SFFidWwvT2tPcHp1Tm5WbW5rY1pKQW9VRlVVdllBbE1VRjN3?=
 =?utf-8?B?dnVDTjEyTnlETEtvSyszSk5VTjJsMVZJME1taUgzNTlvYkFTMWpYTXA3cDd5?=
 =?utf-8?B?L0g5eXljbHZNajdUdWxIa1ZnNko4UWphQnhzVVBEelovd2tDZ2N6ei9obEp3?=
 =?utf-8?B?UkxVU0thVkdxK1hXN2FDakt3UVpSdDE3emptQUJjV1RmblBjY3pvbmNyejlp?=
 =?utf-8?B?WUFGRHNkSDF5RmM2YjJ4YUhVY1NPZVdFUlVUT2U5djdscys3SUhQT200R0dG?=
 =?utf-8?B?WFF2b045eTZvMmR5anl5azByVjdseUxsOVhmaW0rRmlESUtzYzVKYW5oN1c5?=
 =?utf-8?B?M3M1N2xHVmVQd2hhODNFLytOQk9aYlF4dUlEeVFOVTltN1d6bzQ0MzFkY1dW?=
 =?utf-8?B?dFZhNmJMcU9GRmdhQStsWS9GeUJvbGYyVEl3blZDa0RsR2N5aTIyMWJ1Smhm?=
 =?utf-8?B?azhINzVSMlovZFBxQnVyMmNnUVZCTWQ3M1FBSGNJcmovRUo4RHI5UHY4MEdS?=
 =?utf-8?B?b1pvR0VyYU00NHRKcVZQNnVMZE8vN0c1NWdEdG5ZbHRBeW54NURSTEV0UFFw?=
 =?utf-8?B?M09PS2I5OGdWVnNoTkkrUHo2WU1hblNhRFdCYysvMk0yZ01tODdLSXZaREoz?=
 =?utf-8?B?d0R5emw4T3dBUW1lQXlobmpxcWNsTWNzcklUbnZpTEFYWmgxYXFOTjBhVlFo?=
 =?utf-8?B?VGxQTVBCTzBIWVZWSVVyZkY0OTVDUTl5dGJibXQwZ1VzWW1sbndCN25YMktU?=
 =?utf-8?B?eFY5K1dNMWFpVUdzM3M0NndiM0szTFBUaFpMeHgxYmpIaTVpQktzNjJnbkx4?=
 =?utf-8?B?dW5VdkNJdnZscW1DRzdidCtGZ0x2MnJhdGt2dXJ3aHNzd1paa3M5M0R1UXMw?=
 =?utf-8?B?d2ZIb3pzUG1xRzJPNWx5ZDZHbEliTFlEVWlJQitaU1pmVmpGR2t3c1ZGNmVk?=
 =?utf-8?B?b2xBWjlOMDZFbDQrRVY4T1g2UlV2d2ZaWXArRGV6QUN0aDd6R1pjNTNSOHVG?=
 =?utf-8?Q?mInS04JkJaXZfDfouRhzBV4=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 278a8f74-20d0-4787-fd98-08dbf9feeff1
X-MS-Exchange-CrossTenant-AuthSource: SN4PR01MB7455.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 04:09:14.7235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AnFPXQs/zQ3AshaZUiQBiLfjTRDXYzs7ab866CNoy+eOJFvVzJ0B9zoNLWdUDtNsB/W3CR0QJNl1X3mlrLpxqChdu43HdDzDXoaJ1oGaOb4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7821
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sun, 10 Dec 2023 20:09:29 -0800 (PST)


On 10/12/2023 03:28, Andi Shyti wrote:
> Hi Quan,
> 
> On Fri, Dec 08, 2023 at 10:31:41AM +0700, Quan Nguyen wrote:
>> Some masters may drive the transfers with low enough latency between
>> the nak/stop phase of the current command and the start/address phase
>> of the following command that the interrupts are coalesced by the
>> time we process them.
>> Handle the stop conditions before processing SLAVE_MATCH to fix the
>> complaints that sometimes occur below.
>>
>> "aspeed-i2c-bus 1e78a040.i2c-bus: irq handled != irq. Expected
>> 0x00000086, but was 0x00000084"
>>
>> Fixes: f9eb91350bb2 ("i2c: aspeed: added slave support for Aspeed I2C driver")
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> 
> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
> 

Thanks Andi,
I'll add your Reviewed-by in v4

Thanks,
- Quan