Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3813242rdb; Sun, 10 Dec 2023 23:59:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFOdgTFpELPrptEvC91A+HZe4Xw0oXEITvB0zIW6Vhl+pg9pY1XzRJvxVZ/ZFJ7QMHP/L8r X-Received: by 2002:a05:6a20:7287:b0:190:3c84:7187 with SMTP id o7-20020a056a20728700b001903c847187mr1955732pzk.67.1702281561232; Sun, 10 Dec 2023 23:59:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702281561; cv=none; d=google.com; s=arc-20160816; b=ab8/UtfSJJfNpG9Vjp5gMjHT2cqXgsS5/f3IcNv0coBmgH3Nz2YayiNiX6AHhisraj ZJUz9CYoIMe3a3DAwWbmxswWnYDpadIxOFpXzA5iTm1YhJ7nIx/j3CshkqCy/+7IDGkn LPyt9HLh2L+uy8m7btln2d5iu64LGNTmxqrI+jhgEsV1NlO6QtWRDQLdqlyXSgS3EOsS iXvVLTC3SeABKq3b75OAgbUk9rNJhns23f4T4GN9W/2QSTfbmsncvAqJI4fMuTyH/PoB cBp83OusH/c86T9IY9uYmgVGdVskblSs6CzZk1/Hc30G0lJJvEyxPq1XncLUHW3g83sq 44TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature :dkim-signature:dkim-signature; bh=uu6n7mEvnmXbniOla3rPuD+at6mp806bEoBZqpe8Srs=; fh=BKtipKovsCGcWnDysz6K+aSHDcfhPOHqPEDNW3phKx8=; b=e9/gT++totQZRBTvytU23AvvczAgu3J9nixQNjcoqpIyNS9a/UBmqsabPFE9cTJZIo yz5ThJKRHG7Dd8uoYQtUAnhiCi/uLdelbtO+KcOpqB+B7FQAFc/BknSXKdIwr1XIixRx 6KWH40UcjPnws2f2zPpI8nziIDtrvGILvtEFkMBCD71t83aXuosUtaLs1R5eYxYJsK9Q lq8v1LgBBowXtN2avFhJIesSHS7D5nj1BNtgWMfgCYSEotWtj4l1RZnOBg5eZK/lvqTK UjxPcDvlWwRDZSrypJBSVt0PJcBP0F0xhSfw0r/o1Pn+KyXkzJtbA3Ig2tBgeGLhIY+w nG5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=F2EXEQKF; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=F2EXEQKF; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id i1-20020a17090332c100b001d0259167f4si5860586plr.287.2023.12.10.23.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Dec 2023 23:59:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=F2EXEQKF; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=F2EXEQKF; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id AC74E80A1E3C; Sun, 10 Dec 2023 23:59:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229853AbjLKH7F (ORCPT + 99 others); Mon, 11 Dec 2023 02:59:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbjLKH7E (ORCPT ); Mon, 11 Dec 2023 02:59:04 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE6F3CD; Sun, 10 Dec 2023 23:59:10 -0800 (PST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1B90D1FB6C; Mon, 11 Dec 2023 07:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702281549; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uu6n7mEvnmXbniOla3rPuD+at6mp806bEoBZqpe8Srs=; b=F2EXEQKFjaL8rqwVqqdQBU9hMTkZcxVRfsFW6uSowHHxfUb6IKM5rUc5vyH1u+nz5Gu0Qy c40XaN2A62IIVciP3J+v37MzCtnwTQTQaolpzUO8jfCwFudytNhcgJgDPymwqHGUXV0Gum IS1xPDJ7lZgF1CpgSe05vGUPx5oATRg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702281549; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uu6n7mEvnmXbniOla3rPuD+at6mp806bEoBZqpe8Srs=; b=ZVxx0YFRxMokq+KnjclNVrUIaH9LdO+mntagvBMf6y1V//puLAuAZW+AxTunPqt8UsfUr6 BsAvAzr9si24LnAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702281549; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uu6n7mEvnmXbniOla3rPuD+at6mp806bEoBZqpe8Srs=; b=F2EXEQKFjaL8rqwVqqdQBU9hMTkZcxVRfsFW6uSowHHxfUb6IKM5rUc5vyH1u+nz5Gu0Qy c40XaN2A62IIVciP3J+v37MzCtnwTQTQaolpzUO8jfCwFudytNhcgJgDPymwqHGUXV0Gum IS1xPDJ7lZgF1CpgSe05vGUPx5oATRg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702281549; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uu6n7mEvnmXbniOla3rPuD+at6mp806bEoBZqpe8Srs=; b=ZVxx0YFRxMokq+KnjclNVrUIaH9LdO+mntagvBMf6y1V//puLAuAZW+AxTunPqt8UsfUr6 BsAvAzr9si24LnAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CE16D132DA; Mon, 11 Dec 2023 07:59:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id UcQTMUzBdmXlHwAAD6G6ig (envelope-from ); Mon, 11 Dec 2023 07:59:08 +0000 Date: Mon, 11 Dec 2023 08:59:08 +0100 Message-ID: <874jgp5fw3.wl-tiwai@suse.de> From: Takashi Iwai To: Gergo Koteles Cc: Shenghao Ding , Kevin Lu , Baojun Xu , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/tas2781: handle missing EFI calibration data In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Level: X-Spam-Score: -3.10 Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -3.09 X-Spamd-Result: default: False [-3.09 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.17)[-0.867]; RCPT_COUNT_SEVEN(0.00)[9]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.81)[99.19%] X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 10 Dec 2023 23:59:17 -0800 (PST) On Mon, 11 Dec 2023 00:37:33 +0100, Gergo Koteles wrote: > > The code does not properly check whether the calibration variable is > available in the EFI. If it is not available, it causes a NULL pointer > dereference. > > Check the return value of the first get_variable call also. > > BUG: kernel NULL pointer dereference, address: 0000000000000000 > Call Trace: > > ? __die+0x23/0x70 > ? page_fault_oops+0x171/0x4e0 > ? srso_alias_return_thunk+0x5/0x7f > ? schedule+0x5e/0xd0 > ? exc_page_fault+0x7f/0x180 > ? asm_exc_page_fault+0x26/0x30 > ? crc32_body+0x2c/0x120 > ? tas2781_save_calibration+0xe4/0x220 [snd_hda_scodec_tas2781_i2c] > tasdev_fw_ready+0x1af/0x280 [snd_hda_scodec_tas2781_i2c] > request_firmware_work_func+0x59/0xa0 > > Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver") > CC: stable@vger.kernel.org > Signed-off-by: Gergo Koteles Thanks, applied now. Takashi