Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <1bbcd4e612a1577d83456a5c88ad633547e59e9b.camel@maquefel.me>
Subject: Re: [PATCH v5 39/39] dma: cirrus: remove platform code
From:   Nikita Shubin <nikita.shubin@maquefel.me>
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     Vinod Koul <vkoul@kernel.org>,
        Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Date:   Mon, 11 Dec 2023 15:10:51 +0300
In-Reply-To: <ZV30llA4yDUs2G-Z@smile.fi.intel.com>
References: <20231122-ep93xx-v5-0-d59a76d5df29@maquefel.me>
         <20231122-ep93xx-v5-39-d59a76d5df29@maquefel.me>
         <ZV30llA4yDUs2G-Z@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
Precedence: bulk

Hello Andy!

On Wed, 2023-11-22 at 14:31 +0200, Andy Shevchenko wrote:
> On Wed, Nov 22, 2023 at 12:00:17PM +0300, Nikita Shubin wrote:
> > Remove DMA platform header, from now on we use device tree for dma
>=20
> DMA
>=20
> > clients.
>=20
> ...
>=20
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (device_is_compatible(cha=
n->device->dev, "cirrus,ep9301-
> > dma-m2p"))
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0return true;
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return !strcmp(dev_name(chan=
->device->dev), "ep93xx-dma-
> > m2p");
>=20
> Haven't you introduced an inliner with the similar flow? Why not
> reuse it?

It's the same, i moved it from platform header file into driver itself,
as i am removing "include/linux/platform_data/dma-ep93xx.h" completely.

>=20
> ...
>=20
> > +/**
> > + * ep93xx_dma_chan_direction - returns direction the channel can
> > be used
> > + * @chan: channel
> > + *
> > + * This function can be used in filter functions to find out
> > whether the
> > + * channel supports given DMA direction. Only M2P channels have
> > such
> > + * limitation, for M2M channels the direction is configurable.
>=20
> I believe
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0scripts/kernel-doc -v -no=
ne -Wall ...
>=20
> against this file (and maybe others!) will complain ("no return
> section"
> or alike).
>=20
> > + */
>=20

Agree, dropped doc style comment and converted it to simple comment, it
is internal to driver now, so no point putting it into docs.