Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Rodrigo CADORE CATALDO <rodrigo.cadore@l-acoustics.com>
To:     Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Rodrigo Cataldo via B4 Relay 
        <devnull+rodrigo.cadore.l-acoustics.com@kernel.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Aravindhan Gunasekaran <aravindhan.gunasekaran@intel.com>,
        Mallikarjuna Chilakala <mallikarjuna.chilakala@intel.com>
CC:     "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kurt Kanzenbach <kurt@linutronix.de>
Subject: RE: [PATCH iwl-net] igc: Fix hicredit calculation
Thread-Topic: [PATCH iwl-net] igc: Fix hicredit calculation
Thread-Index: AQHaKecFHk6smFyQW0il44pqHqUJh7CgIKqAgAOvtWA=
Date:   Mon, 11 Dec 2023 09:21:06 +0000
Message-ID: <PR0P264MB1930850228C3F58EE8B7F9FAC88FA@PR0P264MB1930.FRAP264.PROD.OUTLOOK.COM>
References: <20231208-igc-fix-hicredit-calc-v1-1-7e505fbe249d@l-acoustics.com>
 <871qbwry9y.fsf@intel.com>
In-Reply-To: <871qbwry9y.fsf@intel.com>
Accept-Language: en-US, fr-FR
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VBSXMZnUKBtkcZvu7m2bNqOnTpTyzD3Tf37eyvO8G88Xjvr9AVPcUXjq/YcV?=
 =?us-ascii?Q?2O5WAqY1pMzbsNfpwk4aeYVXKkDC3Xk4uv4/2+SYdJcIjv2HbaOKol3pY6An?=
 =?us-ascii?Q?z10AWp4UoElysByiePBzvv9+YBhVH4yTolNSMyze2XOSUA1q7p/OS7VvJk58?=
 =?us-ascii?Q?D4A/1XRXznqjzs9v7VO4Ld9hN8tGmGvghUw5jr2kI2g0hoKvK9LmMa0Ixqqj?=
 =?us-ascii?Q?pr3px1Ffp9S+pW86mIxVjFMuvOhnwBnW/Tv29+uVJuaUZH1zpU0ceCj+4EMC?=
 =?us-ascii?Q?tEm5IQDYXZhMy1ESB8fkzacoFE7Elbqsa9dHCdYYTcqgyVLoAqygC0CAMmmB?=
 =?us-ascii?Q?h3TiYVSZbhoCqK4l4kXIyq/09sdZ/WgqRI+9OVMVHAf+uhwkXyBhB/NQnRh0?=
 =?us-ascii?Q?uoTHAwTKjaO6eZrmi2ubEBhiZWo0KQHmOjPYTAyHv9XRWB9o7GU0/wIAjrZs?=
 =?us-ascii?Q?3Qj5lkia22xXXPMNCNKcVQiZFmLlSpVEJYnaP+b14VvKTbqPzIxbWnPM5D4X?=
 =?us-ascii?Q?K0JFsDEOom9CMv6xxZHz5Sis7JV+8FHYdSmwTYTsWN+1YdNTe81agfVRDdlu?=
 =?us-ascii?Q?5ni2atVZnOi5CHAwkP6/HAFhc2D6w+0/BsB8BPfyzxbeWWrdO0Ci5WLfRAvE?=
 =?us-ascii?Q?xj/zEKFpSuNHkPlZ3asOUqCPSw/x8Gz9vi8445NJELpST7DRuCg/gJyF0ykw?=
 =?us-ascii?Q?INvBdtnD68FmrYknyY3Uj2zcmDfp5DRgXBC99DUhTF3F8+2bv2ChtG9Sdozt?=
 =?us-ascii?Q?l+Ruc3LwgzcwacVMN3JjZQlKkzlSSVWLAnUX10MJysQ3ocXuXXb3vnXvoEAW?=
 =?us-ascii?Q?wmnfweTubxf08FRoV+aMRWT21aqR22pOVNqBNROKxTR50R+y4KH9yIM10wiW?=
 =?us-ascii?Q?EKcJUAJ/S3RlTV/dwszLlHvPEroLIa7cK5FQEuTfKEdWqjEAXmRyZu1N8ngz?=
 =?us-ascii?Q?sx8UQIGg9WQsDbNxk0O3ba7pv+8WjSYgrtqg2TR6eOO6h8LlLmkYNcC9kc3h?=
 =?us-ascii?Q?GCt8torB/dCQlzlclolAHgZu0vs4sNtfRI4Hn/BmpVLb3OjjzIpGbmLFTLc2?=
 =?us-ascii?Q?oh84ZYOUoXOp+yklwhkmGtsaQWgzw7HYLJCG1+morz7NYkd/ST5gopZWWgJo?=
 =?us-ascii?Q?aivkuqri8Ek1rLuBYnQcwlJJoylXbs4AfqeJyvIgltUjDsFiR7ESDOSM6XcT?=
 =?us-ascii?Q?fNy6re+6FMPvy+NAr0WvLcqFDZ6vRbRoazG7sEN+eDI2h9rP+XLkdlAbLuhy?=
 =?us-ascii?Q?Z/ZTTJu0kqOl9P/iOJ31ZN4VLdMI0zAVAwt2P9hZVfGUasjDCjOf9es5AgSw?=
 =?us-ascii?Q?jHg+Nb+AoQwDCpg1X/1b5BS2CRa6Mreys8X2xpvl14zrR93B3dX97u8MctkD?=
 =?us-ascii?Q?6ho2aCPbO1WrnyV22nPSERJZnK7p0gWjX2hhpF8560/cghr34tz5foRfrs3m?=
 =?us-ascii?Q?aXx8BBrz9YeXIyKsyDOQpz7hd84lbfzaDiwBFWam8BXCGAGXeUHtIcoknzSk?=
 =?us-ascii?Q?pq2sUwH1dgPOWSsG39XchyZnCUb8PFzrOuwdjMcLy6wvDY9iaBSw69ClRaqd?=
 =?us-ascii?Q?oQMqeirl2ihWMEmeKu5JXOWtfx85uGChh+gd4wPjj+kp+knzDTA/6quuDZkh?=
 =?us-ascii?Q?2A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: l-acoustics.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PR0P264MB1930.FRAP264.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: c8d76467-707b-4ad4-63a9-08dbfa2a8148
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2023 09:21:06.7155
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 68e431e8-d632-483e-ae79-f28a7b4c69e6
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BIubNvrBLx31+S2mEAu2McHrsEn8e3zHteKhDAXR0Cl5ZhXoxN2OYi3VBUV+55nxEm8aPBq/o8lVKIja4Xv8Kc7/oztH3Mvg0nlXi6h3Oqg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR0P264MB1675
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 11 Dec 2023 01:21:23 -0800 (PST)

> -----Original Message-----
> From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>=20
> Rodrigo Cataldo via B4 Relay
> <devnull+rodrigo.cadore.l-acoustics.com@kernel.org> writes:
>=20
> > From: Rodrigo Cataldo <rodrigo.cadore@l-acoustics.com>
> >
> > According to the Intel Software Manual for I225, Section 7.5.2.7,
> > hicredit should be multiplied by the constant link-rate value, 0x7736.
> >
> > Currently, the old constant link-rate value, 0x7735, from the boards
> > supported on igb are being used, most likely due to a copy'n'paste, as
> > the rest of the logic is the same for both drivers.
> >
> > Update hicredit accordingly.
> >
> > Fixes: 1ab011b0bf07 ("igc: Add support for CBS offloading")
> > Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
> > Signed-off-by: Rodrigo Cataldo <rodrigo.cadore@l-acoustics.com>
> > ---
>=20
> Very good catch.
>=20
> Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>=20
> Just for curiosity, my test machines are busy right now, what kind of
> difference are you seeing?
>=20

Hello Vinicius, thank you for the ACK.

For our internal setup, this does not make a difference. My understanding i=
s=20
that hicredit is used for non-SR traffic mixed with SR traffic (i.e., hicre=
dit is
directly related to the max non-SR frame size). But our setup does not mix
them (q0 is used only for milan audio/clock SR class A).

Let me know if you think we need a testcase for this.

> > This is a simple fix for the credit calculation on igc devices
> > (i225/i226) to match the Intel software manual.
> >
> > This is my first contribution to the Linux Kernel. Apologies for any
> > mistakes and let me know if I improve anything.
> > ---
> >  drivers/net/ethernet/intel/igc/igc_tsn.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c
> b/drivers/net/ethernet/intel/igc/igc_tsn.c
> > index a9c08321aca9..22cefb1eeedf 100644
> > --- a/drivers/net/ethernet/intel/igc/igc_tsn.c
> > +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c
> > @@ -227,7 +227,7 @@ static int igc_tsn_enable_offload(struct igc_adapte=
r
> *adapter)
> >                       wr32(IGC_TQAVCC(i), tqavcc);
> >
> >                       wr32(IGC_TQAVHC(i),
> > -                          0x80000000 + ring->hicredit * 0x7735);
> > +                          0x80000000 + ring->hicredit * 0x7736);
> >               } else {
> >                       /* Disable any CBS for the queue */
> >                       txqctl &=3D ~(IGC_TXQCTL_QAV_SEL_MASK);
> >
> > ---
> > base-commit: 2078a341f5f609d55667c2dc6337f90d8f322b8f
> > change-id: 20231206-igc-fix-hicredit-calc-028bf73c50a8
> >
> > Best regards,
> > --
> > Rodrigo Cataldo <rodrigo.cadore@l-acoustics.com>
> >
>=20
> Cheers,
> --
> Vinicius

Best Regards,
Rodrigo Cataldo