Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Feedback-ID: ifd894703:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069
MIME-Version: 1.0
Message-Id: <9bdcd491-5ee5-48b3-844c-d6c0092bfc73@app.fastmail.com>
In-Reply-To: <93b41b72-a6ac-4d7f-95f0-ba42399729fc@loongson.cn>
References: <20230616103127.285608-1-krzysztof.kozlowski@linaro.org>
 <20230616-activity-shed-be3c13e5ac71@spud>
 <93b41b72-a6ac-4d7f-95f0-ba42399729fc@loongson.cn>
Date:   Mon, 11 Dec 2023 09:17:54 +0000
From:   "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To:     "Yanteng Si" <siyanteng@loongson.cn>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
        "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
        "Andrew Lunn" <andrew@lunn.ch>, "Conor Dooley" <conor@kernel.org>
Cc:     "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        "Conor Dooley" <conor+dt@kernel.org>,
        "Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
        "Alexandre Torgue" <alexandre.torgue@foss.st.com>,
        "Jose Abreu" <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>,
        "Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
        devicetree@vger.kernel.org,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible
 fallback
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


=E5=9C=A82023=E5=B9=B412=E6=9C=8810=E6=97=A5=E5=8D=81=E4=BA=8C=E6=9C=88 =
=E4=B8=8A=E5=8D=886:48=EF=BC=8CYanteng Si=E5=86=99=E9=81=93=EF=BC=9A
> =E5=9C=A8 2023/6/17 02:52, Conor Dooley =E5=86=99=E9=81=93:
>> On Fri, Jun 16, 2023 at 12:31:26PM +0200, Krzysztof Kozlowski wrote:
>>> Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in =
DTS,
>>> so checking for some other compatible does not make sense.  It canno=
t be
>>> bound to unsupported platform.
>>>
>>> Drop useless, incorrect (space in between) and undocumented compatib=
le.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Might be worth noting that dropping it is required to allow the
>> new loongarch dts stuff to be functional with a sane set of compatibl=
es.
>>
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Thank you Krzysztof for your work. when I am
> adding more devices support to stmmac, I found that your
> two patches seemed to be forgotten.
> Thomas, Jiaxun. Can the two patches get an Acked-by?
> My stmmac patch thread:
> <https://lore.kernel.org/loongarch/cover.1699533745.git=20
> .siyanteng@loongson.cn/T/#md3108d29a5efe71b27f4c5ccf5d0217571bf6586>

Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Better to resend without RFC :-)

Thanks

> Thanks,
> Yanteng
>
>>
>> Cheers,
>> Conor.

--=20
- Jiaxun