Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3853988rdb; Mon, 11 Dec 2023 01:44:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGPu1kWh++12PK2aUNWy7vrXSSpbykIh6qdz4B3izOZrbbLpel5ts2dqA6Xt3wMEeDG7dBR X-Received: by 2002:a05:6358:2612:b0:170:5522:597b with SMTP id l18-20020a056358261200b001705522597bmr6994998rwc.56.1702287866804; Mon, 11 Dec 2023 01:44:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702287866; cv=none; d=google.com; s=arc-20160816; b=xaBHHRuF0k3W8A64aMujZro7t5qgs96E5Yq7sz36tjIEVh7EGhJBTzuFTlyewhA8dv j3w4E+apoOz6Dop9MlHaLTRjckBkI56gqwenPen4fKPN8aGiuQ5ouifnG0cCiG8RQrbV h25KEgO+6XTdayp03yFuTJJuN+tSYLmuQnApoqvmFnRnQKPJcdFF1SA0oiLPP1/MrYAa 6O4SFt6oeJSV/8XCUwDtjNzxf/aVzs/BIQ19Z3nfYHRbHFlMNmv10ztOVuMwVKrJir/7 UfSD1m5H3JTKrR64rdRW1NxOGRE4vJ1vG2/sd1ZnD8hcjQg+t5TrOqT5LE/VVmbKEbgI Qqlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=Db6FeaCKS9ZeGRKTPQiDaIkGqDMRDuo5kau+LZBn9Bk=; fh=BGcxQC/wSuI9hlqX89KpNlWof8tYvz1lSDYpmWakagc=; b=ezxY56fIOwOFaMJBJaB8OgWMAmZEkZCaN7EQUjN49rEuaSDG8g03JiH2Clzz9nXFml F95cY+62bkaHaO1qh/fFbCH0ZdurLcRlAjk3U4mXUrHMZj9ZNb6DqijJvaLvL8IqIBkW aRwIxXP0Am12JpNW9GUcOyt/VJPJz0EP9X4v9FjXJKlZt+39gnxcKnEl8sCVaMmRh+ju TCopcTMmD/E6HuAg9VMAa6XYzsU9Aogcms0VqoWVyqWVJbXjURf7sBTwxGIGme0izyPj Nz3Ke4pFMqL7FrLB4NzIYMInnTygwVTx5C20takc36SwUVzXg7EC1ZLITUAV8DAAmzi4 W9jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WOT7Qzoo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id fh6-20020a056a00390600b006cdfa76e7e8si5840755pfb.299.2023.12.11.01.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 01:44:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WOT7Qzoo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 8238F8079C93; Mon, 11 Dec 2023 01:44:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234473AbjLKJoJ (ORCPT + 99 others); Mon, 11 Dec 2023 04:44:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbjLKJoI (ORCPT ); Mon, 11 Dec 2023 04:44:08 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E56AD1; Mon, 11 Dec 2023 01:44:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702287855; x=1733823855; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=e9UzSq7u1+T3BYIBBw3mpsXLdJcC9xa15mmoGy5LqpE=; b=WOT7Qzoot4znoqzAuxe23yOBIwk2dxAVz/rVKsUG95I8NNtxRoLUkKSz WMIuMmqPG1KbC0gkK5hfI0Ep1q/wGwLJ2q59yZGgICNvEuE+5MAgb1gLd bURikV4AnlC9nQs0vdyqhHlvNBz8DcEeudCBCGnAZ/TzpAFtDeoaWSjCZ EOZ0+SU7GS95+/l6g8Nk8m+KlDVdqmJzY7NM6uC+KA1lhAz5iqmVPFv2Q WRa0FuyF8IqCUnRCqTiCeflzkkQk6+tHGOa2wyShw0LZTSRH9MvLrL/uD CPXE0wIw3kXctNO2uTHzxokyqRc90QGMyXX6iioUGE9Rdfcnu2pQYrbso A==; X-IronPort-AV: E=McAfee;i="6600,9927,10920"; a="16172824" X-IronPort-AV: E=Sophos;i="6.04,267,1695711600"; d="scan'208";a="16172824" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2023 01:44:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10920"; a="838963603" X-IronPort-AV: E=Sophos;i="6.04,267,1695711600"; d="scan'208";a="838963603" Received: from lmckeon-mobl.ger.corp.intel.com ([10.252.48.111]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2023 01:44:12 -0800 Date: Mon, 11 Dec 2023 11:44:01 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Andy Shevchenko cc: platform-driver-x86@vger.kernel.org, LKML , Hans de Goede Subject: Re: [PATCH v1 1/1] clk: x86: lpss-atom: Drop unneeded 'extern' in the header In-Reply-To: <20231208165238.3309058-1-andriy.shevchenko@linux.intel.com> Message-ID: <2fd750c3-1f57-3d71-386b-9e6e57d5133@linux.intel.com> References: <20231208165238.3309058-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-2115513837-1702287853=:1867" X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 11 Dec 2023 01:44:24 -0800 (PST) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2115513837-1702287853=:1867 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Fri, 8 Dec 2023, Andy Shevchenko wrote: > 'extern' for the functions is not needed, drop it. > > Signed-off-by: Andy Shevchenko > --- > include/linux/platform_data/x86/clk-lpss.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/platform_data/x86/clk-lpss.h b/include/linux/platform_data/x86/clk-lpss.h > index 41df326583f9..7f132029316a 100644 > --- a/include/linux/platform_data/x86/clk-lpss.h > +++ b/include/linux/platform_data/x86/clk-lpss.h > @@ -15,6 +15,6 @@ struct lpss_clk_data { > struct clk *clk; > }; > > -extern int lpss_atom_clk_init(void); > +int lpss_atom_clk_init(void); Reviewed-by: Ilpo J?rvinen -- i. --8323329-2115513837-1702287853=:1867--