Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3859474rdb; Mon, 11 Dec 2023 01:59:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+7dOwJeXM7f2X3x0NiHWfcARCoLvaKjxUHYV/wW2uiNpfQv6OfYJyBButEENetjL1bqwt X-Received: by 2002:a17:90a:46cc:b0:286:a73d:4133 with SMTP id x12-20020a17090a46cc00b00286a73d4133mr1374565pjg.35.1702288755340; Mon, 11 Dec 2023 01:59:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702288755; cv=none; d=google.com; s=arc-20160816; b=rENLehPERmD2wCB43chxMscwlm/3mo3vM4jfoUYnpvqBnSq3TKMxu+Jl/nuPXP3kLq EPlr3HzuiGAY2sQ7iqYRgM0nDH+BIxx7dUmb8EQjBtqmAPPZs5RyeTn7MLP4hA3n72M0 gkVE+EdxHoT2PYmlkSru2MWjvCraYNS3i97kaeTKQkM/TZC4pik5+uF1C8KRhHNdKDax MUQVhoIqR23Zs9rt1FUe/lK9XzMTcI2Khzu8k8qTLbZsXpQUCI3MAdfgH8ET2t+smVq4 rwVtqdUoZjClZuR2LL2boUTGd+vwt9dSiA1ePvyFPW/lWWpvwoFGYrdxtndkAS7cZXFy vdgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=+8ZYGpDqXB7DKk7WEUaqFLKAG8Tztk8Kini09NyiSQw=; fh=vSAhmp8T9WmHLb2JxZIg7uYugRgektP5Vkg6oiMlhpI=; b=swErbeWdQhvw9zgXaYN0/51HHTi53PyhD18pFSmVTX0coHBV+D+5sfRhZHfc8zTfGO wWR8DGrmZAL6CqFSc59C/Ci9C2c1czm4kVS9ZRew1iq9dlViWOJUjNutt/4BMiY0Akra nEX2EjR1Uc955mTyWIR+uA29c/8zTTWin13rHbfgsf40ddVUvE33jb3j/30xLR9qudAZ Jy/DChZaNPaIpXSyjUpqCZwwgTfQoz9TdGM4G6/lm7FCwMeDWLH0wZHiL4eGeaXKEozT 2R9n9Yp/6emDe60WZn02b2tQ9ZKOeOwlrr9eJ7Z2ZfjZY/YJB6u5NOsFYPjlq8LzPP0y pE9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Bq2xxpud; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id n7-20020a17090a73c700b00278eb61c0ebsi7159607pjk.118.2023.12.11.01.59.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 01:59:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Bq2xxpud; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EC50D807C542; Mon, 11 Dec 2023 01:59:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234709AbjLKJ67 (ORCPT + 99 others); Mon, 11 Dec 2023 04:58:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234646AbjLKJ65 (ORCPT ); Mon, 11 Dec 2023 04:58:57 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D9B5C5 for ; Mon, 11 Dec 2023 01:59:03 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-336210c34ebso808397f8f.1 for ; Mon, 11 Dec 2023 01:59:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702288742; x=1702893542; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=+8ZYGpDqXB7DKk7WEUaqFLKAG8Tztk8Kini09NyiSQw=; b=Bq2xxpudojIRDR9Axi0Zynr7a6N+FxOhR+CodkBmuIwUxWsC5Mqy6G89z4y6zNenqX h9gJMuHnHtdyigi0qTPiSGZuch1h9w/0P88TxdCg6ModcHuIEvFolIERF+1P4a7GQlUF e4T93f9dKzpbqLH0p3vA3yWcLuDuGP3vjST83P/4rG+g3jBnKVopN9AYdYUfIfnUd0+M jSOYGr1pqBaPetfZy8JhQOqimavhkY7poLWsd2Tx9uROn1lCGCjn5spp8FKlJ9UkdqSa 2Uf+PPHzkWvGOzv1pVmPowgn4uZzuWK1l2XgoW3HyKOVP6c3EuSRHuJ5gJFZct/pnJsY jCQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702288742; x=1702893542; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+8ZYGpDqXB7DKk7WEUaqFLKAG8Tztk8Kini09NyiSQw=; b=VAlT7CE2N2fgjAjeC3XTCjsfcdDMNfS1fKQUZErFJ/iUugDTFlr7JzS9yruWiw5gUw 78F2X2vhU3WhYva2GmzXusF9nSZLJOVWsxQIMh6/CJiqcnKXrbaohTy/v2gxlScGlh6d D+paYY5kQQBRXjaMhpqPFrzQtLIJQuaJkezV6fyTvT3Xwb+geB0pTf72H/j9hCnAHHTE R+x36G+e+lMmhanzcc+kKRTUGB8AvDx9Ms55cOhBDaR+8H/KnuBC4gsysDah/1/Mn4oO nKqvxXOwTpG3F4rj6SJ8+X2R3/pW4tA4aOLZhNf6e6K3C9U5NYj5AySHYzaDAWqRDcxU CCBA== X-Gm-Message-State: AOJu0Yya9ZBJ/xmsehsMWQ69XuEkPvrJyYc+5TyzvQUvFyYlyxn6E0SW MSZXpR0pZvAhDBgirnq6lqLd7dVdW7UzFrzWtps= X-Received: by 2002:a05:6000:1b06:b0:334:b160:7e00 with SMTP id f6-20020a0560001b0600b00334b1607e00mr1483847wrz.151.1702288741937; Mon, 11 Dec 2023 01:59:01 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id g12-20020adfa48c000000b003335eded7f5sm8206605wrb.68.2023.12.11.01.59.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 01:59:01 -0800 (PST) Message-ID: Date: Mon, 11 Dec 2023 10:58:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] arm64: dts: rockchip: Add support for rk3588 based board Cool Pi CM5 EVB To: Andy Yan Cc: heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20231210080313.1667013-1-andyshrk@163.com> <20231210080629.1667589-1-andyshrk@163.com> <2b58450a-1bde-424b-ab69-a3834914522c@linaro.org> <14ab4c8c.4fa1.18c58488bf2.Coremail.andyshrk@163.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <14ab4c8c.4fa1.18c58488bf2.Coremail.andyshrk@163.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 11 Dec 2023 01:59:13 -0800 (PST) On 11/12/2023 10:49, Andy Yan wrote: >>> + >>> + backlight: backlight { >>> + compatible = "pwm-backlight"; >>> + power-supply = <&vcc12v_dcin>; >>> + pwms = <&pwm2 0 25000 0>; >>> + enable-gpios = <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&bl_en>; >>> + status = "okay"; >> >> This is a friendly reminder during the review process. >> >> It seems my or other reviewer's previous comments were not fully >> addressed. Maybe the feedback got lost between the quotes, maybe you >> just forgot to apply it. Please go back to the previous discussion and >> either implement all requested changes or keep discussing them. > > Yes， it seems that the comments were lost， I didn't get any comments about PATCH 5 in my V1. > Anyway, I will check this patch again, and fix the issue I find by myself. I don't have to repeat the same comment for every same thing to fix. It's your task to fix all occurrences of the same issue. Best regards, Krzysztof