Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <175daa6f-5778-4138-afdf-6475c11bfb3c@redhat.com>
Date:   Mon, 11 Dec 2023 11:04:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/2] platform/x86: Convert to platform remove callback
 returning void (part II)
Content-Language: en-US, nl
To:     =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
        Corentin Chary <corentin.chary@gmail.com>,
        =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Rishit Bansal <rishitbansal0@gmail.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Jonathan Singer <jes965@nyu.edu>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        SungHwan Jung <onenowy@gmail.com>
Cc:     acpi4asus-user@lists.sourceforge.net,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
References: <cover.1701726190.git.u.kleine-koenig@pengutronix.de>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <cover.1701726190.git.u.kleine-koenig@pengutronix.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 12/4/23 22:52, Uwe Kleine-König wrote:
> Hello,
> 
> back when I sent a series to convert all platform drivers below
> drivers/platform to use .remove_new()[1] I missed the two drivers
> converted here.
> 
> The two patches have no dependency, so each can be picked individually
> if needed by the driver maintainers. (But I won't say no if Hans picks
> up both patches together :-)

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
> 
> Best regards
> Uwe
> 
> [1] https://lore.kernel.org/r/20230927081040.2198742-1-u.kleine-koenig@pengutronix.de
> 
> 
> Uwe Kleine-König (2):
>   platform/x86: asus-wmi: Convert to platform remove callback returning
>     void
>   platform/x86: hp-wmi: Convert to platform remove callback returning
>     void
> 
>  drivers/platform/x86/asus-wmi.c  | 5 ++---
>  drivers/platform/x86/hp/hp-wmi.c | 6 ++----
>  2 files changed, 4 insertions(+), 7 deletions(-)
> 
> base-commit: 629a3b49f3f957e975253c54846090b8d5ed2e9b