Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <b9c33092-6268-ef89-4401-0cf438ee8a4a@intel.com>
Date:   Mon, 11 Dec 2023 11:12:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] ice: Fix some null pointer dereference issues in
 ice_ptp.c
Content-Language: en-US
To:     Kunwu Chan <chentao@kylinos.cn>, <jesse.brandeburg@intel.com>,
        <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <richardcochran@gmail.com>, <jacob.e.keller@intel.com>,
        <karol.kolacinski@intel.com>
CC:     <michal.michalik@intel.com>, <intel-wired-lan@lists.osuosl.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Kunwu Chan <kunwu.chan@hotmail.com>
References: <20231211062649.247148-1-chentao@kylinos.cn>
 <447d130a-e1ac-02f6-e168-b04bfa9c6004@intel.com>
 <3231a5d7-29bc-4464-a26c-803b95774f86@kylinos.cn>
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <3231a5d7-29bc-4464-a26c-803b95774f86@kylinos.cn>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzB2WmxPQ3hiSGVZZjI0YitsTXN3SnhRRFhUNVZ3UTMvQzB1L0UvRFFpUUZY?=
 =?utf-8?B?dVdObXROMHcvU29TdURRVU1rV0tJaTdQMnNoN0dhWjdYdzI0MmdpMjRqNjNJ?=
 =?utf-8?B?VE9UNUVUWkJxRlgzS2xjZGZjbkR3QmNIdVlnSHZTTSt5LytqQVlRRDRhMytL?=
 =?utf-8?B?bHZ6RS9yY3JJUEYvWGlrdTM3UEd5cWc4M1Z2VHdNeE5MY1NsNWU3Y1ZRcWNE?=
 =?utf-8?B?OXNzNjc4OHhBSnQ3bnNHNDRJZzhxMlRYeCtTYnRzMmJsQ3Myd0NsQmZ3b3hU?=
 =?utf-8?B?U1ZmdllBemtJVXZTUHpKT1Rkd3Z3OHNXTmNVd0Q1RC9Iei8xQ0I3SmZpNEJn?=
 =?utf-8?B?Q3Y3RUlCVXF5cHplRmNTbWlqdjR3VGNUb1EvMlk5Z0VtMDA0UGd0UHc4N3Zk?=
 =?utf-8?B?aEZUWTZ4dk1BbWxFRWJnZWVRbGI1Z0VuaGRKSUYzR1hCdkJmbDh4OEozTGQw?=
 =?utf-8?B?TmR6aXdzSHZGUjljUjBmTXk2Q2doSGx4Z2Y4VzdYVkhER0tIWHBUWHNoMnlU?=
 =?utf-8?B?M3RqTmUvR3VmN2ZrRkVSWWwvWS9sa2dXVEgvaDh3RWJnNE1oTlljUzJPbFh6?=
 =?utf-8?B?d1BTb29BbS9LVHlmYis2YVNOc0tkZzE5Qll6Y2JFK0dyZnhkNzVDdlFZUFpM?=
 =?utf-8?B?TW1FVVo4YnZaNzJpWmJCSHNJZ3F5aWo0Mnc0RUlsZlZRa1l5ZnU4UHVvY3Zt?=
 =?utf-8?B?bFVGRHZOY2lJUmMvV0N1V25ldjRLaUNONlc0T2cvOWlKZjM1c0prNWRHUFhv?=
 =?utf-8?B?Sk9mQjhGQlNPZW9YMDBPMTNUYVgzWjBDclNmQTRZeitpSUNLZC9lb1c0b1cx?=
 =?utf-8?B?ZG9IMk01MkRDSzVXM29ZaVZ2TzR0NVhtcEpRQXdpbGc4TS9VcWd4Uk14K2RQ?=
 =?utf-8?B?cmdEcHFVM2FuWngyYUNtOUFEaXJiUXZhWDdjUUVrdXVoU3FCbzd0K1VvZ0lT?=
 =?utf-8?B?SDNrTHhhb1Rjb1ZKdkZEZGt5cVdkZnA1dFhXNzV6Qy8zMEdhZWs5alBHQ0Fo?=
 =?utf-8?B?aEZaZDBCZzFSN05LTlF1aENaVlRCNjNoY2VBZGptYnViT1duTmkzK3ZSOTVq?=
 =?utf-8?B?V1hjWEVxc1g4V0dWNGZHR0k1NG03ZjhIc0JNbXpnZGNzcVR6aWZQclVYekgz?=
 =?utf-8?B?aG1nOWU2OGtybWRHVXVGbVRDQnNMMXJMazBjRE9lY0F6MTdNRDVCRmszbHU1?=
 =?utf-8?B?YXRFNm5JRFNCb0VNaFdSdm4wRXZ2WVEzY0N3Z0dCNmN6L0VIMDFrUHBIR0Zy?=
 =?utf-8?B?V0tadW1VRjZsRnZsTDhCR2VsNFkwS2U3SVI0WDJTS0t4REVHTno0VW15dmVG?=
 =?utf-8?B?TjlFKzJBVTJYbmRaS0V2eUFlMUZDOStVOTZuVURCUWQ4Wk1wd012M2pSUGdS?=
 =?utf-8?B?UXhsOEJKZnl6eGJjS1J6NHZYRk1wRzdyZnlicG43MWEvSDBMVGt1cE9ZSEZ6?=
 =?utf-8?B?ZUpmalYyR0s5N0l1QmVjMVh0Qmh1RFNxRGRhbkNHMkdtZlA0Z2Vaa2ZoMTBO?=
 =?utf-8?B?YkQwRlhESDZKUjhCc3gyT20wT2xqdlh3VFp2d3hBanp5b1EzbFhPRmZZVEJQ?=
 =?utf-8?B?OUJ1TFlnanM3VS9qZ3A2anNqUVZHZE9pT3lFanNRZUNlNUcrWFlZQnlWS01l?=
 =?utf-8?B?SGpzb04vRi8xdjFyaGdMZ2F3MFFrbDhQQVlad0luV1h4dTFUd0hYRU5FQmRP?=
 =?utf-8?B?UTlvS1JSWTRpUHdVb1VkZGszMVYvWDVCWGdvdWtyNTFzRCt6NWNiNFlOb2Zi?=
 =?utf-8?B?Zk8zeGdaSnc4Tyt5L1JSSStlZSsyS2lxYnJPRWpPWC9OUGlDM0M4K01sMzJP?=
 =?utf-8?B?U0VCZ0dGR0g3K3ZYc2VsbUFwQXFUVndxNmpkcVJ5R1E2emxZczhmUTdSME9l?=
 =?utf-8?B?eWhZT0pyd2Z1blBLN0FmUlFiZDFuK1BoQ3ZCSGwzM1BEa3Z5SnZlck0xdjdq?=
 =?utf-8?B?Y2hVc2JsV09jcWI1bkNtQjB0dnJsWjlNWEtsQytLQUZLeGRsUklBcVVLYkZC?=
 =?utf-8?B?VG5XQkMxNjdNM1ZjYU14UkFOMnhFQVJXSmdRMzhDVHI5Szgvb3pDVkVJUU14?=
 =?utf-8?B?RjlONEpHU2lMQkJheVZqdmhneGJYYzNCSERXTzg0cGk3RzZUR21zSHRkREtr?=
 =?utf-8?B?S1JHTlRuTWxCWi9vMEFMSGgxOXVjNXlUTFcyRlNYcmRiUC9IQkU2ejhsSTRp?=
 =?utf-8?B?a3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c201c8e-2f1d-41f3-35b1-08dbfa31bbd1
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:12:51.6294
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YZpinkLvnrnugchrQGSNn7XuE56St4HxHh1e28H+daaMcPWQ06AgvaHOsdXvhhyQ91SD295EsXuwcCMecUOZZ0lHI/435Wv+ccJLtks2Y1Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7038
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 11 Dec 2023 02:13:25 -0800 (PST)

On 12/11/23 10:32, Kunwu Chan wrote:
> Thanks for your suggestion.
> 
> I made the patch based on linux-next.git(tag:next-20231211).
> 
> Our code is just self-similar, i didn't override the old name.
> I keep the logic as it was before.
> The newest code is:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/intel/ice/ice_ptp.c#n2747
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/intel/ice/ice_ptp.c#n2993
> 

sure, I just checked those, no huge benefit of dedup

> I'll update v2 patch with:
> 1. update suject prefix to "[PATCH v2 iwl-next]"
> 2. remove 'dev_err'
> 
> 
> Thanks again,
> Kunwu

Thank you too

> 
> On 2023/12/11 15:15, Przemek Kitszel wrote:
>> On 12/11/23 07:26, Kunwu Chan wrote:
>>> devm_kasprintf() returns a pointer to dynamically allocated memory
>>> which can be NULL upon failure.
>>>
>>> Fixes: d938a8cca88a ("ice: Auxbus devices & driver for E822 TS")
>>> Cc: Kunwu Chan <kunwu.chan@hotmail.com>
>>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>>
>> I would suggest adding "iwl-net" as a target here
>>
>>> ---
>>>   drivers/net/ethernet/intel/ice/ice_ptp.c | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c 
>>> b/drivers/net/ethernet/intel/ice/ice_ptp.c
>>> index 1eddcbe89b0c..59794ce4f243 100644
>>> --- a/drivers/net/ethernet/intel/ice/ice_ptp.c
>>> +++ b/drivers/net/ethernet/intel/ice/ice_ptp.c
>>> @@ -2668,6 +2668,8 @@ static int 
>>> ice_ptp_register_auxbus_driver(struct ice_pf *pf)
>>>       name = devm_kasprintf(dev, GFP_KERNEL, "ptp_aux_dev_%u_%u_clk%u",
>>>                     pf->pdev->bus->number, PCI_SLOT(pf->pdev->devfn),
>>>                     ice_get_ptp_src_clock_index(&pf->hw));
>>> +    if (!name)
>>> +        return -ENOMEM;
>>>       aux_driver->name = name;
>>>       aux_driver->shutdown = ice_ptp_auxbus_shutdown;
>>> @@ -2929,6 +2931,10 @@ static int ice_ptp_create_auxbus_device(struct 
>>> ice_pf *pf)
>>>       name = devm_kasprintf(dev, GFP_KERNEL, "ptp_aux_dev_%u_%u_clk%u",
>>>                     pf->pdev->bus->number, PCI_SLOT(pf->pdev->devfn),
>>>                     ice_get_ptp_src_clock_index(&pf->hw));
>>> +    if (!name) {
>>> +        dev_err(dev, "Failed to allocate memory\n");
>>
>> Kuba @ [1]:
>> no warnings on allocation failures, there will be a splat for GFP_KERNEL
>> (checkpatch should catch this)
>>
>> [1] https://lore.kernel.org/netdev/20231206195304.6226771d@kernel.org/T/
>>
>> so just "return -ENOMEM" would be sufficient
>>
>>> +        return -ENOMEM;
>>> +    }
>>>       aux_dev->name = name;
>>>       aux_dev->id = id;
>>
>> I didn't checked but having same code in two places raises questions.
>> Are you overwriting old name here, or our code is just self similar?
>