Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Quan Nguyen <quan@os.amperecomputing.com>
To:     Brendan Higgins <brendan.higgins@linux.dev>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Joel Stanley <joel@jms.id.au>,
        Andi Shyti <andi.shyti@kernel.org>,
        Andrew Jeffery <andrew@codeconstruct.com.au>,
        Wolfram Sang <wsa@kernel.org>,
        Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
        Guenter Roeck <linux@roeck-us.net>, linux-i2c@vger.kernel.org,
        openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc:     Cosmo Chou <chou.cosmo@gmail.com>,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>,
        Quan Nguyen <quan@os.amperecomputing.com>
Subject: [PATCH v4 0/2] i2c: aspeed: Late ack Tx done irqs and handle coalesced start with stop conditions
Date:   Mon, 11 Dec 2023 17:22:15 +0700
Message-Id: <20231211102217.2436294-1-quan@os.amperecomputing.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dLVzhlg/mHw+f5A3uVvyr2rrRSrcn1B0ErXVcJLgSm4ZmUyockQxMkfBG//D?=
 =?us-ascii?Q?cspHlK9w8DCqLDNMuC5Wr3MplgrWKWGcesrcQuAmaetNtHd6+ln/fuNos8qr?=
 =?us-ascii?Q?soe4HGWhKZEUPCvglGhfKeD+SbgYF5t8y8SB36hhCP5Zz1SNJ8YL7Qr7z6G0?=
 =?us-ascii?Q?G5IH6PFZWauGE/XZkfd1UpXf2qhiQNN19NHIp6yJLfCAJj3dm/QPuBfKi1BJ?=
 =?us-ascii?Q?nlUGneqWLHld2jMvpBGd4ahJ9qgfjNtoAA++lUC5BjzxJwUHK9UZkvqpFNTV?=
 =?us-ascii?Q?EeGv5g6RGw5Egk6LPmbBZ6qDg9ffhHueNX7j01wYq38Hvh6U/LB9uHCW+92+?=
 =?us-ascii?Q?mtiAQ2Q4aB6VaRWPUcP85uDVhx0crh6LuNk7+fN1M/9RyBpBieRPNa5JrHIW?=
 =?us-ascii?Q?O/WHs6gixoUl7SwbBivKOwmTt+AW+KnBIVbpRQolghhVe8TsSpsYQklZD79f?=
 =?us-ascii?Q?AXcFz/31H3NWttITWCqvBQQoRl2FPWxcftoAi573bCfKFsYvDZemFc2EJVia?=
 =?us-ascii?Q?1xoCpJSl+0BOLVDwaocffKxHRtd9u5l0JzrsR+rpyV6v4TTBktZMgP2YtAy8?=
 =?us-ascii?Q?XJG0oJu71/QXiINLtX4CJMet4PTr90RqFjjrODG/L2wQPel8QOeR9FRcoP+4?=
 =?us-ascii?Q?VP6v6Nmj0bKFSKBaWKVLJ9wrYD8/3ONk+IwW0dhsol+fewFWGiTHYAhWUw+I?=
 =?us-ascii?Q?7TMQZJzyOqd7Pr7PEbRqrZk7tjRQYvjGDHcM1esI3xDiAu6Acj3deOypw1ay?=
 =?us-ascii?Q?xcou6LATJro/JYAcx92bdqlKFnLat85pnYEYuxnZvCPaxGhcwg0zLDwLJqOd?=
 =?us-ascii?Q?v28mFHcHTgOmDW0BzxIER7QJ7axFcX7ChAH5olpqjqlhTApmWwdhoJNeTN+r?=
 =?us-ascii?Q?A5dFRTFN3yOdnoERP2ER2sXbxdQMs/v2vACIzIcfM3OqrPBeHnV2SizYWTw3?=
 =?us-ascii?Q?0t8yHlA4V9UjfVwIzAO+HEp8C/DNc6CTfj3vvUxHNcBbRnSRXcQ2r41OYF0h?=
 =?us-ascii?Q?44ZIJdSX6+arcg72d1F9SQK3cc5CC7d6cNrP9nVDrM70TuYuxNlsONqL6Fg/?=
 =?us-ascii?Q?vuDB9/YUMhT1Ecs+TMCS8/SXvxWBgq+sfna2KdzaBncSXAp0qfFGDVAjxVGe?=
 =?us-ascii?Q?eunSbtBepia5G67koAur9RQo+tyzdiQOAc+pIu3mvlGDOubE0oLkgdGc64rd?=
 =?us-ascii?Q?byJP/Rrjh/ryjLr3oHchTz6CWdCC7Es28aR8d/Esuo4Vy1P/hXHT67cSlnoo?=
 =?us-ascii?Q?khGmqrC8sMeiQ+bGsuNZ7Nm03+7e/9bmZ1gXW4u2LlgVsdkS+48WqdfzbgGg?=
 =?us-ascii?Q?E2gHpm/YEvu4UFOVDjud8LBryAlIQPx41fe24uRXpDTotGp45bGOHKC46gB/?=
 =?us-ascii?Q?/EW1qdCpScHfMn5Eo6iYuEOf9jzGp1LyRp2Yxn30VMldPudAKittkCzzOJ4I?=
 =?us-ascii?Q?Qr2/HIfCZe+4+e6gvK4OHLlm3Cf3RRPNh28KiEhbLYV9VvI4yswhyjsJNqzw?=
 =?us-ascii?Q?ajYmI0xcfbiM1TaqBb+0hWN0fVaDRk2H/wtOar6+AbAxXtwQBbGLGwMMgvUW?=
 =?us-ascii?Q?K9iibTNfL8RNo7/gevzs6Eh3DyfxOk2YifPjIGWLGI5gg5ZajcVCASmIwLTo?=
 =?us-ascii?Q?1m7+xh9jrZ4xvMCzMFScvbc=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 800de197-143e-4aec-65a9-08dbfa3319b9
X-MS-Exchange-CrossTenant-AuthSource: SN4PR01MB7455.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:22:38.9219
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m2MEKC3BKOotvQ+Q0T+nxfOw1CndocZXpznfOpeFVsuKqkYkxOaZdwjqanGAeD0ks2drovNtvQHyaPEwk1t7ODSGnTqJI+cKXOnoL80xSYI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR01MB6568
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 11 Dec 2023 02:22:52 -0800 (PST)

This series consists of two patches to handle the below issues observed
when testing with slave mode:
  + The coalesced stop condition with the start conditions
  + Early ack'ed of Tx done (ACK and NAK) causing "Unexpected Ack on
  read request".

This series was verified with ast2500 and ast2600.

The prior discussion could be found at:
https://lore.kernel.org/all/20231208033142.1673232-1-quan@os.amperecomputing.com/

v4:
  + Switch to use define macro instead of variable             [Andrew]
  + Make the early ack conditionally to avoid unnecessary
writel()/readl()                                                 [Quan]
  + Add an extra empty line before the comment in patch 1      [Andrew]

v3:
  + Fix the unconditional write when ack the irqs              [Andrew]
  + Handle the coalesced stop condition with the
start conditions                                               [Andrew]
  + Refactor the code to enhance code readability                [Quan]
  + Revised commit message                                       [Quan]

v2:
  + Split these patches to separate series                       [Joel]
  + Added the Fixes lines                                        [Joel]
  + Fixed multiline comment                                      [Joel]
  + Refactor irq clearing code                          [Joel, Guenter]
  + Revised commit message                                 [Joel, Quan]

v1:
  + These patches are first introduced from this disscusstion
https://lore.kernel.org/all/20210519074934.20712-1-quan@os.amperecomputing.com/

Quan Nguyen (2):
  i2c: aspeed: Handle the coalesced stop conditions with the start
    conditions.
  i2c: aspeed: Acknowledge Tx done with and without ACK irq late

 drivers/i2c/busses/i2c-aspeed.c | 75 +++++++++++++++++++++++----------
 1 file changed, 52 insertions(+), 23 deletions(-)

-- 
2.35.1