Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <0faa472c-d21d-46df-922b-264d7915f983@intel.com>
Date:   Mon, 11 Dec 2023 12:45:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7][2/4] mmc: Add Synopsys DesignWare mmc cmdq host driver
Content-Language: en-US
To:     =?UTF-8?B?SnlhbiBDaG91IFvlkajoirflrold?= <jyanchou@realtek.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "jh80.chung@samsung.com" <jh80.chung@samsung.com>,
        "riteshh@codeaurora.org" <riteshh@codeaurora.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>
Cc:     "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "briannorris@chromium.org" <briannorris@chromium.org>,
        "doug@schmorgal.com" <doug@schmorgal.com>,
        "tonyhuang.sunplus@gmail.com" <tonyhuang.sunplus@gmail.com>,
        "abel.vesa@linaro.org" <abel.vesa@linaro.org>,
        "william.qiu@starfivetech.com" <william.qiu@starfivetech.com>
References: <20231121091101.5540-1-jyanchou@realtek.com>
 <20231121091101.5540-3-jyanchou@realtek.com>
 <655c5964-0917-4021-b254-7917b368b05f@intel.com>
 <7b4b7219c2b6430b9c320c8d9ac1cc8b@realtek.com>
 <8e7b6ac2-9d92-4f37-97c4-ae295f7cdbd4@intel.com>
 <49d0b19c5ec741638e41ee6f970d057b@realtek.com>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <49d0b19c5ec741638e41ee6f970d057b@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 11/12/23 12:37, Jyan Chou [周芷安] wrote:
> Hi Adrian,
> 
>>>>> +
>>>>> +static irqreturn_t dw_mci_cqe_interrupt(int irq, void *dev_id) {
>>>>> +     struct dw_mci *host = dev_id;
>>>>> +     struct mmc_host *mmc = host->slot->mmc;
>>>>> +     struct cqhci_host *cq_host = NULL;
>>>>> +     int cmd_error = 0, data_error = 0;
>>>>> +
>>>>> +     if (host->pdata && (host->pdata->caps2 & MMC_CAP2_CQE))
>>>>> +             cq_host = mmc->cqe_private;
>>>>> +
>>>>> +     dw_mci_get_int(host);
>>>>> +
>>>>> +     if (host->pdata && (host->pdata->caps2 & MMC_CAP2_CQE)) {
>>>>> +             if (!mmc->cqe_on && !cq_host->activated)
>>>>
>>>> Shouldn't really look at internals like mmc->cqe_on or cq_host->activated.
>>>> There are the cqhci_host_ops ->enable() and ->disable() callbacks to
>>>> keep track of whether cqhci is expecting interrupts.
>>>
>>> Does this means we need to use cqhci_host_ops ->enable() and
>>> ->disable() callbacks instead of mmc->cqe_on && !cq_host->activated?
>> Thanks.
>>
>> Yes.  ->enable() is always called before cqhci operation and ->disable() before
>> non-cqhci operation, so they can be used to determine if an interrupt is for
>> cqhci.
> 
> Thanks for your advice, and I got your point for calling cqhci_host_ops ->enable()
> 
> and ->disable() callbacks, but the reason we used " if (!mmc->cqe_on && !cq_host->activated) "
> 
> is that when sending command like cmd0, 1, 7, 8... in mmc_init_card before mmc_cmdq_enable,
> 
> we need to use interrupt in legacy mode, it is much better to write in this way?
> 
> +	events = mci_readw(host, NORMAL_INT_STAT_R);
> - 	if (host->pdata && (host->pdata->caps2 & MMC_CAP2_CQE)) {
> - 		if (!mmc->cqe_on && !cq_host->activated)
> +	if (mmc->caps2 & MMC_CAP2_CQE) {
> +		if (!(events & CQE_EVENT))
> 			dw_mci_clr_signal_int(host);
> 
> Using CQE_EVENT to determine whether Command Queue enable or not.

Unless you expect CQ interrupts before cqhci_host_ops ->enable()
is called, then you know it is legacy mode.