Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753234AbXLEFgX (ORCPT ); Wed, 5 Dec 2007 00:36:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751267AbXLEFgM (ORCPT ); Wed, 5 Dec 2007 00:36:12 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:3451 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751081AbXLEFgM (ORCPT ); Wed, 5 Dec 2007 00:36:12 -0500 Date: Wed, 5 Dec 2007 16:36:07 +1100 From: Herbert Xu To: Joonwoo Park Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "'David Miller'" Subject: Re: [PATCH] NET: ASSERT_RTNL in __dev_set_promiscuity makes debug warning Message-ID: <20071205053607.GA10589@gondor.apana.org.au> References: <000001c8365a$e0e500c0$9c94fea9@jason> <006001c836ff$f0d59a30$9c94fea9@jason> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <006001c836ff$f0d59a30$9c94fea9@jason> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1168 Lines: 31 On Wed, Dec 05, 2007 at 02:30:10PM +0900, Joonwoo Park wrote: > > @@ -140,9 +147,11 @@ int dev_mc_sync(struct net_device *to, struct net_device *from) > da = next; > } > if (!err) > - __dev_set_rx_mode(to); > + pending = __dev_set_rx_mode(to); > netif_tx_unlock_bh(to); > > + if (pending) > + __dev_set_rx_mode_fini(to); The idea is to not touch the unicast stuff at all on the multicast path. Anyway, this was discussed on netdev so please check the archives because there is more to this than just changing the multicast handling. We also talked about consolidating the driver interface so that all these calls have the same environment rather than the mix-and-match that we have now. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/