Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Mon, 11 Dec 2023 13:19:17 +0000
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Kuan-Wei Chiu <visitorckw@gmail.com>
CC:     <mturquette@baylibre.com>, <sboyd@kernel.org>,
        <duje.mihanovic@skole.hr>, <linux-clk@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: mmp: pxa168: Fix memory leak in pxa168_clk_init()
Message-ID: <20231211-urgent-carol-45ca352a9d2a@wendy>
References: <20231210175232.3414584-1-visitorckw@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="vwICD4jSZexuFxQq"
Content-Disposition: inline
In-Reply-To: <20231210175232.3414584-1-visitorckw@gmail.com>
Precedence: bulk

--vwICD4jSZexuFxQq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 11, 2023 at 01:52:32AM +0800, Kuan-Wei Chiu wrote:
> In cases where mapping of mpmu/apmu/apbc registers fails, the code path
> does not handle the failure gracefully, potentially leading to a memory
> leak. This fix ensures proper cleanup by freeing the allocated memory
> for 'pxa_unit' before returning.
>=20
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>

I dunno why you have CCed me on this tbh, I guess I must have acked a
patch related to this driver's bindings somehow.

I wonder, is there actually any point in freeing these, isn't the system
going to fail to actually boot if these allocations fail?

> ---
>  drivers/clk/mmp/clk-of-pxa168.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/clk/mmp/clk-of-pxa168.c b/drivers/clk/mmp/clk-of-pxa=
168.c
> index fb0df64cf053..c5a7ba1deaa3 100644
> --- a/drivers/clk/mmp/clk-of-pxa168.c
> +++ b/drivers/clk/mmp/clk-of-pxa168.c
> @@ -308,18 +308,21 @@ static void __init pxa168_clk_init(struct device_no=
de *np)
>  	pxa_unit->mpmu_base =3D of_iomap(np, 0);
>  	if (!pxa_unit->mpmu_base) {
>  		pr_err("failed to map mpmu registers\n");
> +		kfree(pxa_unit);
>  		return;
>  	}
> =20
>  	pxa_unit->apmu_base =3D of_iomap(np, 1);
>  	if (!pxa_unit->apmu_base) {
>  		pr_err("failed to map apmu registers\n");
> +		kfree(pxa_unit);
>  		return;
>  	}
> =20
>  	pxa_unit->apbc_base =3D of_iomap(np, 2);
>  	if (!pxa_unit->apbc_base) {
>  		pr_err("failed to map apbc registers\n");
> +		kfree(pxa_unit);
>  		return;
>  	}
> =20
> --=20
> 2.25.1
>=20

--vwICD4jSZexuFxQq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZXcMVAAKCRB4tDGHoIJi
0npnAQDhMi0sOhFCb2XK8e4LHbB01fNeeAnX29yOGRmSBgkI6QD/RL448S6rMuJr
psmgLu7PXSxRaa4u79WAnL996jASxQY=
=0YJF
-----END PGP SIGNATURE-----

--vwICD4jSZexuFxQq--