Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3963224rdb; Mon, 11 Dec 2023 05:21:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IEi609C9RsMKph2jfzM7ERLjvgkFM/kgmgP/mBs7QzY0KTmSoAwXYB4pjbWmkK3b/hkrKWW X-Received: by 2002:a05:6e02:1ca2:b0:35d:7de6:c38b with SMTP id x2-20020a056e021ca200b0035d7de6c38bmr5754798ill.43.1702300860592; Mon, 11 Dec 2023 05:21:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702300860; cv=none; d=google.com; s=arc-20160816; b=alnlxvdRiDczoWGBKym2eJqt3ikVkOYUrVBdnLCNWUGInYBraTM7qbMm0HcWWnbIKj IiagWNtIdGy65Sa5ByjHJnrRThZs8tS+xHct9KfwwhH3YDTCd7umIj0c8gNuoCldZEcl 4vbLsfmGQUtfllD+AZh763fwjsqvqddEocicUd/U845Y0R7HWa8ZRRP2Dj0m+CgKEBzi POs42ajoE+tLVWTEcVnjsS316nCzf5qnBJFUOKKpBkFb5LId2zD5iuXi+ll8P2FTcxSe Rga5qYw4nsqvuNQyhsLD7tQNCgudb/UVQDJWVe/Hj1sR9vSc9aHa15QLN0dRx1ljGVKv KC/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nZVPTK45ZBvIjtWvylxU/GNRF7JFShFA/yzNGtFKH6M=; fh=c2UonIpSz+RNBs3gYdcXq1IHE0DuAq1U9F+gdIzkFK8=; b=k98IeMo9vvVsZB6CyOXPasns8vbgELVYaWM6M/aNYrz1G8aNzrTwro0t8Y++m3Nnnq o3fu5GPP1VD3OGBDlT/YxMD0e378/XeVChsIUAlhP1MQJz7QOMCvtZax7p/G4U/YhhPl XLzVBuyiFJGxVAvBblpFNTX310yyHhXW/MtDNECAn+vyxg6jTZXdhNcH+NQDMv+Ng4eR 7cQI+489/DmrFJNkB5Ru4HTq7IPJHGwO7xBrzlOLvYruXZ78XQk1kp8pmYOgP/5vWyQg oMAtAZKeGHEGeIpN/g80EdXfeuyMaqNczuiekTBtj+TUq+Bj9TAP88MnZf3dz4g3cwS9 btaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MPXvfAwb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id y9-20020a63e249000000b005c1b2d93e52si6151683pgj.368.2023.12.11.05.21.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 05:21:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MPXvfAwb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 4A906807F949; Mon, 11 Dec 2023 05:20:42 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343615AbjLKNU1 (ORCPT + 99 others); Mon, 11 Dec 2023 08:20:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343541AbjLKNUZ (ORCPT ); Mon, 11 Dec 2023 08:20:25 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19A4CD8 for ; Mon, 11 Dec 2023 05:20:31 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC935C433C8; Mon, 11 Dec 2023 13:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702300830; bh=NL2ENmBjIwcpp92HnkgEm9ykKOp6EQ6nvP2PwYBmzhQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MPXvfAwbh8hwH9ldAT97ah+Dne6RHbK0ZuNig1YOpLC+t55X4eYoHwuUdAaaqdqTM WGFT9Tpt0Z59zzIQmiMNJkuku9/WKo8NIY8u4T75iZ04mnEyj8qEer5tPykpp072DA TycX5gHHaqf0ZGER6vu/JXpABZHDqKQn1gqZfi2ow5U686W/Hi6w0m65tIAbuB7SUD aWTxug3ffsCwizNBclY8bZmVAIMJp53/tXOvbZqlaULxn+6MhZaGJCrBQHR4+mw2zZ uZsk7ItY/8cHhZ7Hi8iUfnltXOMkNtBdPvSAZhDSOYgR04NhPGF3aPzpP4nBZUC6xx yMyiEvlMtPupw== Date: Mon, 11 Dec 2023 13:20:25 +0000 From: Mark Brown To: Jianhua Lu Cc: Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC, PATCH 1/2] ASoC: qcom: sdw: Add TDM support Message-ID: <01cbe664-f344-45ee-a049-1c27b78ac9a7@sirena.org.uk> References: <20231211095357.4629-1-lujianhua000@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="76L5gXG0TJhXaYup" Content-Disposition: inline In-Reply-To: <20231211095357.4629-1-lujianhua000@gmail.com> X-Cookie: Better dead than mellow. X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 11 Dec 2023 05:20:42 -0800 (PST) --76L5gXG0TJhXaYup Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 11, 2023 at 05:53:56PM +0800, Jianhua Lu wrote: > + } > +} > +EXPORT_SYMBOL_GPL(qcom_snd_tdm_hw_params); > + Why is this exported? > @@ -125,6 +186,9 @@ int qcom_snd_sdw_hw_params(struct snd_pcm_substream *substream, > *psruntime = sruntime; > } > break; > + case PRIMARY_TDM_RX_0...QUINARY_TDM_TX_7: > + qcom_snd_tdm_hw_params(substream, params); > + break; > } The only caller is in the same file. --76L5gXG0TJhXaYup Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmV3DJgACgkQJNaLcl1U h9Cr+wf/Rh5mzsWfkvyzZL0kVpdllXEeA8Mjsmn1CqPrug3j1L5NGY75yRi15YFa 36Rq1DrvIR+rkp9HNzNRR/ME1rekfzACkvglWhuPWsvw00KrMqp0FuUHlL7z0Q4Q ZRlQCS5qZb+UBbh2R+ePA9ImNeZcqqL/FS2XokbZt4SyFLXWqz68gVbAzVX+z2Ic xJa8JERXDFzpZxSCmTGS1BmvlirtPMBJl1HrkFZzlkfEfp/9n9Ws+KJDCgeHMrxU xC6PjSN/OOk/or784TaG0E8JCBh0zd0KaoDalQpeCB+qy0i5HygEnS2Rkxa6FIrs VW4dV6u1NZ5wyIjoNqaORFiQ5W8TyQ== =ENse -----END PGP SIGNATURE----- --76L5gXG0TJhXaYup--