Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Mon, 11 Dec 2023 09:21:35 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yi Liu <yi.l.liu@intel.com>
Cc:     "Tian, Kevin" <kevin.tian@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
        "Zeng, Xin" <xin.zeng@intel.com>,
        "Zhao, Yan Y" <yan.y.zhao@intel.com>
Subject: Re: [PATCH v6 2/6] iommufd: Add IOMMU_HWPT_INVALIDATE
Message-ID: <20231211132135.GF2944114@nvidia.com>
References: <20231117130717.19875-1-yi.l.liu@intel.com>
 <20231117130717.19875-3-yi.l.liu@intel.com>
 <112383df-3ea3-475f-963f-5c53232a1bf4@intel.com>
 <BN9PR11MB5276283CAEAB7A24871B4B188C8BA@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20231207144208.GJ2692119@nvidia.com>
 <8c05763d-1668-4b99-af35-b43a34e966c2@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8c05763d-1668-4b99-af35-b43a34e966c2@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Sdv7MKXdrSWYFyf1D5Tr6m9jWm+cJ3E7KCnvYYkiyZoOiAe5BCJTIk7vz96x?=
 =?us-ascii?Q?Jgx2bFsGJNhJHl+pncaiFUfx5Z/daKWwkwxghV5MEZD22CIgo2V7LnttQicG?=
 =?us-ascii?Q?2aM9Yj7pwPftbLE9/Ef81OsXTmmOVKboOnzuYzKFtKePdHVsPiruhWZmrNVe?=
 =?us-ascii?Q?BMqERmga7hcC+eb7L1qwOZ6fsD22JlCvfBmGaGCxgqVUSfX8YRgciflxw6R7?=
 =?us-ascii?Q?fxr0B+uiWcaZRaf0lFbf6Lh/inO1ntSJ+P/h+vtkKhKMrwMRAsyisu9biQXQ?=
 =?us-ascii?Q?ukVHZ+q9BqOtye1yvKdXosbEysDf93zSUwc5lniVi3ujlWVmLzl9r1KmUdwN?=
 =?us-ascii?Q?Lg4hLm3M/+6Kcg9202APzue83GfNQWS1IZRzauOpR0d18raB166BWJgDdAGD?=
 =?us-ascii?Q?7qPmAMKgeNHWkUZcdSDS2XPxeYZEVdbgI67tGjs31/liw2m5i2S7DjappJXL?=
 =?us-ascii?Q?gRuijZ2ntLg1IYBQhVRRhlAsA+2t3UUUYea8wzf+NDaSDB/RaInrrfKrnr6a?=
 =?us-ascii?Q?+3RYR4UHEaF31wNDZrnNlkVPxAAO+zTngBY2iGQXRlufESodi+QIhg4DC2g7?=
 =?us-ascii?Q?XTdFff579TBCyxJdk6OhnpR9kaYKfZ+RroC6zL3pXAuVKkgJN+zoJFpWDvjT?=
 =?us-ascii?Q?4LwBCotCPXkaEQnbyrfEE4dLy4TB0D5n+3w61h+TEz+XBS7MXhLh0/2xmLjE?=
 =?us-ascii?Q?ISSkoRb1TjpaZcJRiEGYzt02WvOjTS1FLe2IFu9shNoCZ3XlS1fF4przSNUH?=
 =?us-ascii?Q?s1QqBbPb/ABQbsUsX5XEPLsukrGPJ9g5YNOz3jvvp85TLhntJNhKmJljgypH?=
 =?us-ascii?Q?7Kh7sGcdM/HvmmIwr75F94ysrblQW0bqWe6uKEUGgsyJcQPhIZwuJSnKooxV?=
 =?us-ascii?Q?s9K+SeNCXylN2UzADQffmugCloWsoObhP5Dg0/RR6Bqki5lfFTWP4JdvWeEf?=
 =?us-ascii?Q?KoRrqhm3wi/GNb0lQSj+n0czjiY4vnFdqoK39xxnLtwTRk9vp1rJoQt6DLEU?=
 =?us-ascii?Q?m14ASP0Ut/B8HTUUT/55/hZsThzVnWFcdhuQNm/H8C71VWjenD3eI6qHZDw+?=
 =?us-ascii?Q?p8PjmmNqhnK+ExYe8LqMhGGZryxycHFpGLi6D2QSRDB7RskA7zOiDdVAjYzN?=
 =?us-ascii?Q?yaE8HEeksaVau92xQpyg6NCYDoJOyqU+u2tZAj/z9GFhys5fVbXN26wNW3Up?=
 =?us-ascii?Q?Q7Rhmc8FcT1WWYF16Uxe8XHIs0vFRJfFv0E0hXkLEQhOqtKLeUQDEi33BxM5?=
 =?us-ascii?Q?qXAWbmQXLkvKbVrhpqUhkwFoLFUEne7T6HmlPSTpEhw527XWS0RWeivnsBNv?=
 =?us-ascii?Q?4sLAXTMX4PuWosyKqXC1C5FujKwKPUk2bycObiI4dpYV2bCYGKP87hRdm+3N?=
 =?us-ascii?Q?ELnpu6y2VJQhqfTWxzqeQ6XtE66SgdroK/4H0fWdm+9qSloNmvTYjQnjFAl5?=
 =?us-ascii?Q?lWQMaaXPSQTNkIm14dDrMle0OysjuH1azDlT1usw0u3aFYo0Y438v+kyN2Ft?=
 =?us-ascii?Q?NtOC332D92CwTyBn85KB4o6XG8TVdXnefH1x8KmGJtsJ8FqJZygnK4fFggMV?=
 =?us-ascii?Q?I6qM4rleC2vOLWB/v/LARPN8LeRRI1FUeBJ7EKH+?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db85f659-f780-4562-443c-08dbfa4c1a0f
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 13:21:36.6325
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IPeEVzlaltvTVgqWJ2qAR+eBBtIDz3mLFB54joTh4WfyE7q05soFXZA96hVf3ENF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8884
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 11 Dec 2023 05:22:10 -0800 (PST)

On Mon, Dec 11, 2023 at 03:53:40PM +0800, Yi Liu wrote:

> > >  From that thread Jason mentioned to make the invalidation format
> > > part of domain allocation. If that is the direction to go then there
> > > won't be multiple invalidation formats per hwpt. The user should
> > > create multiple hwpt's per invalidation format (though mixing
> > > formats in one virtual platform is very unlikely)?
> > 
> > I think we could do either, but I have a vauge cleanness preference
> > that the enums are just different? That would follow a pretty typical
> > pattern for a structure tag to reflect the content of the structure.
> 
> Is this still following the direction to make the invalidation format
> part of domain allocation?

I think you should make it seperate

Jason