Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <06e77692-4942-4657-9694-725d6de3e883@raritan.com>
Date:   Mon, 11 Dec 2023 14:31:04 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] stacktrace: check whether task has a stack before saving
 it
Content-Language: en-US
To:     Linus Walleij <linus.walleij@linaro.org>,
        Ronald Wahl <rwahl@gmx.de>
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
References: <20231030175854.12675-1-rwahl@gmx.de>
 <CACRpkdZ2CXiNsnh_VxAy0OK+s_=cDqP8k0PVmNiL4QJ+mMZ+GQ@mail.gmail.com>
From:   Ronald Wahl <ronald.wahl@raritan.com>
In-Reply-To: <CACRpkdZ2CXiNsnh_VxAy0OK+s_=cDqP8k0PVmNiL4QJ+mMZ+GQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkgyMjlpcmVhMUM5NDdmQkw1cHZYeHAzbzRLZk05V3hjOU9KTkFtbGdxWlRj?=
 =?utf-8?B?aWlSVlNnamFPVk9OWmdwbXVkNFZiYVpMTEU1S0phRUJXNlVtdlRDNTNMaUl1?=
 =?utf-8?B?MXNRanpBa2hPQnluU3ZBKzBjRm9JYU5lcmZBaGZsc1RucGg1VTZiWnN3OTZy?=
 =?utf-8?B?Z3h5QXJpb0ViL3VXaGtmdzViQmJtWEFCUXNrbjBZaGFnaC9JMmNLMjNRN1BO?=
 =?utf-8?B?clB3S1RqTi9YODdZczArQXFJWnF1OEFheGI3QjJTTEliQVRPU0hsL3RWeW14?=
 =?utf-8?B?cXVXcjJHTkVJQ2ZIOGxpaEZpZTdGZ1lMYUlYeU1vNzkxQnpHU2VqaDNTbDZO?=
 =?utf-8?B?QVZ5ejQyQ29TVW1rQ1pOTjlSRlVnL2x6QnVuN0VzMkUwdk80TWdDNmN5SmNz?=
 =?utf-8?B?WW01SDlraWtLNEVSM2UvcGMxK3hIU1Y0NEJ5cnhLWS80SXhSdEhxK0lMelEv?=
 =?utf-8?B?Q2p4cG51akR2d2pPV3BRYU5WWUlHd2taelh1WnU2VkhZa29nWkZxU05kZzRp?=
 =?utf-8?B?eGNUUXZlQlI0c21RVDVsZDAyRXdRRnp4UkRLODNaaFNscGt1T0lDaVJycUZq?=
 =?utf-8?B?OWpBQWJ1dW1YVU8yVXBGeHUvY09qSjZ1RVlaK3k3cm9iTjAyTmVEajVTd0N6?=
 =?utf-8?B?SW9zb2N4S1dlbGliWVU1cjdHeCtXcVk4d1oxRVdxTlM0WHE5STJtS1cyOE9T?=
 =?utf-8?B?cEdHNzVEWENybXF0aTFBN1Q1bjFJaVZ2ZDJadGRwNTNlRWlGZUN1Z3FtSGhQ?=
 =?utf-8?B?dHQwbmR1ditQWnJIRnlkczFNSy9xazRyYVRKL0Z1WGFqUktUcUxPWTRrdFFa?=
 =?utf-8?B?cDh0L09WdWFPV2lIa0RuVGMvU3A2cjFhdGFTTWI4c08yVnFtSnJvYWdQOEFv?=
 =?utf-8?B?eXRnWERFMnNqWHpPMlZsOTV0NnlrUUgydWMrclNqZ1VVTzl5U2hUbWd0eExN?=
 =?utf-8?B?TzRoL2tobnFZNjU4a09iZXNXazhrSXBKU3RmMlo4SFBkQlJScFhBemNYbFZ0?=
 =?utf-8?B?aStscjFLOEl5REl4UVdySG1ueWRIb0RjUjBKMnJBU002cTVFRmgvbDJSbXB4?=
 =?utf-8?B?andETmkzQWkxbXJLZ28rZWxrTU9RV3Q0NjlodzB6eFNkajlPbUpieEdoMTEx?=
 =?utf-8?B?V08rY1lyTGx0bDVQTUFJYStDOC9JanN5QWl3OGw4Q1krRUdRdHl2THVtT0Fh?=
 =?utf-8?B?TnY5eldQYnlNQlNpL0dib0trRVVUMHpGTUt3ODZvK3BUQ0srMisxdFE3NnFW?=
 =?utf-8?B?UzVMejN4SWVLUjA5dy94WkJ0WlRsZGhDaGN2S3gwVis1dkI4Zkp6b3dnLy9i?=
 =?utf-8?B?MGhHMGxDajN3eGNXQmQrbU04VUp0VmsvUkgxZWlLOEpFOHpaYjNWYUMzcmNr?=
 =?utf-8?B?aStvZjFCcGdTY3NnYWpoV245NmVPWWNuME45dlM4ZVpQY1RacnF5MHhINXhm?=
 =?utf-8?B?amQ1cjZLaTc1OEVXTHdNVFNuMGdwbXd1R1ZYQ1JEcUxRSHVSazJQL1QraVZ6?=
 =?utf-8?B?bmI2eU14UkJ5NXJGb1U1K3VaTllhSFNTdVk5SnFLRWdMaVdDYkV3NkJMM0FI?=
 =?utf-8?B?S1B0MEFoWWRRWEpjdHRyVFNFdURsQ0tydm9XL213Nzl6QUwvQXVjN09NUkNy?=
 =?utf-8?B?TUhGZktDRjU0N3hPN1IxV0VHM0kvV0krMWV2bWRqUGRWWlRJa1J0ZDhDd3Nn?=
 =?utf-8?B?UmltNUkwczl3cmNrUlJudUJScy9JblFidmlpSVlpR2duNC9raWVHQitHd241?=
 =?utf-8?B?Z0dlV1ExUkRMTjdwZXozNkNBSFBWdnJBS0NocE9WbVhmWjBRVlJFTVJBOUJT?=
 =?utf-8?B?dC9ETnExSnp4Nk12WlZMWkt3WlY0SzZFWUhiWW5TSWFMLzRLdXFtSzVPK3ky?=
 =?utf-8?B?Q1B2M2RQQW5SVTdBdyt5cmRNMm5mUmJ5TiswcDUzTDBueTVtYkhWaVA2NE1p?=
 =?utf-8?B?V2ZKRnZnMVBjSlpVY1JRU0xFVVQ4RWJyckI0NFVwYnlMK0szQ3gwaEUvQ1kz?=
 =?utf-8?B?QkcraVo2ZTF1OWpZUm9vaXNaU0M0dUVmM2t6RUNFL1RyeWVtWHM3bmVHZnJl?=
 =?utf-8?B?TS9VMHRqZ09BN3ZOc0tuQ3JXVndIY0FOSHhXWktTeUp0V0xvQ3V2T3dqVjI3?=
 =?utf-8?B?THBPdW9lYkkxdFJGZXZjUjBtdk1xS2R3Vyt6V3plS3M5REJIK3lRSmdQUDZZ?=
 =?utf-8?B?Tnc9PQ==?=
X-OriginatorOrg: raritan.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3042a3d9-03f1-4608-5b64-08dbfa4d6e03
X-MS-Exchange-CrossTenant-AuthSource: DB8PR06MB6539.eurprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 13:31:07.1235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 199686b5-bef4-4960-8786-7a6b1888fee3
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /rzybCKI60VG9cUjgOSoGXeanZJa3a3fAjUPHhH140K3HG0/zjOAfdJhZRHKSE+Lbdnc7qwHz6/jEJovcgwmiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR06MB7097
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 11 Dec 2023 05:31:21 -0800 (PST)

On 01.11.23 22:59, Linus Walleij wrote:
> [You don't often get email from linus.walleij@linaro.org. Learn why this =
is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On Mon, Oct 30, 2023 at 6:59=E2=80=AFPM Ronald Wahl <rwahl@gmx.de> wrote:
>
>> I encountered a crash on ARM32 when trying to dump the stack of some
>> zombie process. This is caused by a missing check whether the task
>> actually has a valid stack. This commit adds this check.
>>
>> Commit 214d8ca6ee85 ("stacktrace: Provide common infrastructure")
>> introduced this check for platforms that define CONFIG_ARCH_STACKWALK
>> but ARM32 is not one of them.
>>
>> Signed-off-by: Ronald Wahl <ronald.wahl@raritan.com>
>
> Looks correct to me:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Unfortunately it causes a memory leak because I forgot to call
put_task_stack(task) now. Should I post v2 or a separate patch?

- ron


________________________________

Ce message, ainsi que tous les fichiers joints =C3=A0 ce message, peuvent c=
ontenir des informations sensibles et/ ou confidentielles ne devant pas =C3=
=AAtre divulgu=C3=A9es. Si vous n'=C3=AAtes pas le destinataire de ce messa=
ge (ou que vous recevez ce message par erreur), nous vous remercions de le =
notifier imm=C3=A9diatement =C3=A0 son exp=C3=A9diteur, et de d=C3=A9truire=
 ce message. Toute copie, divulgation, modification, utilisation ou diffusi=
on, non autoris=C3=A9e, directe ou indirecte, de tout ou partie de ce messa=
ge, est strictement interdite.


This e-mail, and any document attached hereby, may contain confidential and=
/or privileged information. If you are not the intended recipient (or have =
received this e-mail in error) please notify the sender immediately and des=
troy this e-mail. Any unauthorized, direct or indirect, copying, disclosure=
, distribution or other use of the material or parts thereof is strictly fo=
rbidden.