Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3972174rdb; Mon, 11 Dec 2023 05:36:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IEgrVNPSQGFxISJdsBX/tXF7MY4un7yFh2YAUPX7vomm1/x040Kkqi+1zSq83mHUTpdtuyL X-Received: by 2002:a05:6358:ce03:b0:16d:d0e7:e7ee with SMTP id gt3-20020a056358ce0300b0016dd0e7e7eemr4798572rwb.28.1702301790224; Mon, 11 Dec 2023 05:36:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702301790; cv=none; d=google.com; s=arc-20160816; b=gw5fLeTAjBFmy6m0sVErq64W+fD5vWH51ub52E5dT04H2UMxuNDa23L/s495ZB1a81 1WYlTRalptRXjpwX7e7i2Ib9qpT7s0KJR+dxT9ojSlwoHibqY4WNibCCQuIc+sVO3gQ2 WT3Bx8l4us22Lh7zclNBsup5ZUyMeHhMh8WDktu9ZZ86RirGrC0I+JBoLAvQaMRHmiX7 YD9O/dPV1Mm/nK1D8rAN89GAAmGHsTKnXAXRYfr8ytdwjZnC5fUShZpxFx1mF7/gFdv3 Z5FEAC0PneMKGqzbTvpg4cvJhNF6ceayJ2G2rkuUGJe/3I50Zuf6pGB0i1jq2A/KZdam 88tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:dkim-signature :dkim-signature:date; bh=rUVN2ssEkdii3K08E1/98BL+0ihkfVFzlz/Q0FL4OUg=; fh=67PMiFJ+Yqkgfg9d/kBip2twZQc7U22jrG/HQhs2opE=; b=DbahWbM2ME22G1t0UNJ5KR5HbLFIWOKjJSGnX8NnVBkdrMx2D0orkyB6I3HtiVu9te d1N0ArtLPuZ0pMQfuqrhw2HooBgpEVHTv6QKuUNulUVa67J3XFuFkfL6ay4sD2PF11KT 1Z5qJ+iE0iRebO3VT71iqshN2GtDYpWJb+UYEReTP3QOUlFCuins+OFsiWQX3oKs91a/ R0OE6TfIlQ32nNNo0ntfasZ2Uzyei9zDvCOOhG8TYCKS79NXHq38vz3ALTQuOLKT72Sy VJPD4S1SF/kef0gZBq+JhPsvmuQq4mJgCANG2k3RD+jXh0poODDar0gIVte9v0L3LXX+ ZIUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=KZK07Wrh; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id 4-20020a630004000000b005c7024c42a4si4095819pga.510.2023.12.11.05.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 05:36:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=KZK07Wrh; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 6510A80966CF; Mon, 11 Dec 2023 05:36:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234925AbjLKNgK (ORCPT + 99 others); Mon, 11 Dec 2023 08:36:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234625AbjLKNgI (ORCPT ); Mon, 11 Dec 2023 08:36:08 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A97EC3 for ; Mon, 11 Dec 2023 05:36:14 -0800 (PST) Date: Mon, 11 Dec 2023 14:36:11 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1702301772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rUVN2ssEkdii3K08E1/98BL+0ihkfVFzlz/Q0FL4OUg=; b=KZK07WrhyghsvuSIfVC1Bm2il+eSi7oZjLvolLZeZ5H/S6YL2HkuWA7PVnslatpO7QWb7W fu7yvTdI8jS4avc2Z0rJ1SxTNs2wO3lSGJB/BbHwdS+JiR16OClVW6nmMJYyY+SfTlSKPg YErUYCiQE8mRsWlUUhMyiQgMrpM72LhTToDQJOUasKo66z81Ccr96S3X9jj1gz/3uZ/ilw 9iEbGfyTVmtV2FYM82DcmtUcsA7actso6CjVVJctdEpfwKVZ4fN+vUySY0s9fZJvxKzogV 7uEUHLmjy82X9QKPZvpJTC0IMC9DVuvSd+nCPFTRft62jiONOQunwNnOgphWqQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1702301772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rUVN2ssEkdii3K08E1/98BL+0ihkfVFzlz/Q0FL4OUg=; b=ea4nKht2x+grJeWHo9KkOymkLO/f67qRoaZdBmqBX4j84BGuOTpe9N2/yl964YAikRFnD5 KxDI8TwD80q96cDQ== From: Nam Cao To: Conor Dooley Cc: Jia Jie Ho , Paul Walmsley , Palmer Dabbelt , Albert Ou , , Subject: Re: [PATCH] riscv: Kconfig: Add select ARM_AMBA to SOC_STARFIVE Message-ID: <20231211143611.5d0248bf@namcao> In-Reply-To: <20231128-grandma-guru-4fc6e6950a75@wendy> References: <20230525061836.79223-1-jiajie.ho@starfivetech.com> <20231128102722.fQizGKfo@linutronix.de> <20231128-grandma-guru-4fc6e6950a75@wendy> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 11 Dec 2023 05:36:27 -0800 (PST) On Tue, 28 Nov 2023 10:59:44 +0000 Conor Dooley wrote: > On Tue, Nov 28, 2023 at 11:27:22AM +0100, Nam Cao wrote: > > On Thu, May 25, 2023 at 02:18:36PM +0800, Jia Jie Ho wrote: > > > Selects ARM_AMBA platform support for StarFive SoCs required by spi and > > > crypto dma engine. > > > > > > Signed-off-by: Jia Jie Ho > > > --- > > > arch/riscv/Kconfig.socs | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs > > > index 1cf69f958f10..381cd46e6373 100644 > > > --- a/arch/riscv/Kconfig.socs > > > +++ b/arch/riscv/Kconfig.socs > > > @@ -29,6 +29,7 @@ config SOC_STARFIVE > > > bool "StarFive SoCs" > > > select PINCTRL > > > select RESET_CONTROLLER > > > + select ARM_AMBA > > > help > > > This enables support for StarFive SoC platform hardware. > > > > I'm considering sending this to stable trees. Without this, it is not > > possible to configure the kernel with SPI driver for the starfive board. > > > > I just want to check with you first, in case I miss something obvious. > > Any objection to backporting this patch? > > Personally I would be okay with that, otherwise the driver is dead code > in those stable versions. Just be sure that the rename of some pl011 > variables (I think that's what it was) that was a pre-req for this being > merged is in said versions of stable. An allmodconfig should flag > whether that has happened pretty quickly. Thanks for the info. I think I found what you are talking about: a1a5f2c88725 ("dmaengine: pl330: rename _start to prevent build error") It's been a while and no one else said anything, so I am going forward with this. Best regards, Nam