Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Mon, 11 Dec 2023 21:40:09 +0800
From:   Jianhua Lu <lujianhua000@gmail.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Banajit Goswami <bgoswami@quicinc.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC, PATCH 1/2] ASoC: qcom: sdw: Add TDM support
Message-ID: <ZXcROf5dIpKbBMhP@Gentoo>
References: <20231211095357.4629-1-lujianhua000@gmail.com>
 <01cbe664-f344-45ee-a049-1c27b78ac9a7@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <01cbe664-f344-45ee-a049-1c27b78ac9a7@sirena.org.uk>
Precedence: bulk

On Mon, Dec 11, 2023 at 01:20:25PM +0000, Mark Brown wrote:
> On Mon, Dec 11, 2023 at 05:53:56PM +0800, Jianhua Lu wrote:
> 
> > +	}
> > +}
> > +EXPORT_SYMBOL_GPL(qcom_snd_tdm_hw_params);
> > +
> 
> Why is this exported?

Thanks for spotting it, I will drop it in patch v2.
> 
> > @@ -125,6 +186,9 @@ int qcom_snd_sdw_hw_params(struct snd_pcm_substream *substream,
> >  				*psruntime = sruntime;
> >  		}
> >  		break;
> > +	case PRIMARY_TDM_RX_0...QUINARY_TDM_TX_7:
> > +		qcom_snd_tdm_hw_params(substream, params);
> > +		break;
> >  	}
> 
> The only caller is in the same file.