Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <53374e41-d1e0-aa8f-d001-5e89783b962c@amd.com>
Date:   Mon, 11 Dec 2023 19:23:48 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 1/2] perf tool AMD: Use non-precise cycles as default
 event on certain Zen2 processors
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     acme@kernel.org, kim.phillips@amd.com, peterz@infradead.org,
        mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        irogers@google.com, adrian.hunter@intel.com,
        kan.liang@linux.intel.com, changbin.du@huawei.com,
        yangjihong1@huawei.com, zwisler@chromium.org,
        wangming01@loongson.cn, chenhuacai@kernel.org,
        kprateek.nayak@amd.com, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, sandipan.das@amd.com,
        ananth.narayan@amd.com, santosh.shukla@amd.com,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20231107083331.901-1-ravi.bangoria@amd.com>
 <CAM9d7cgs9Wk0OFoea4jOote-drHjvCimJyt7GWdO2Giw=d7Jog@mail.gmail.com>
 <f42bf6b7-75b8-124b-c79e-ad7a9b706990@amd.com>
 <CAM9d7cijrZzp=5m+BcQ77WFOSHT7e5vO-RCUTUp5Pevmz2wbtg@mail.gmail.com>
Content-Language: en-US
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <CAM9d7cijrZzp=5m+BcQ77WFOSHT7e5vO-RCUTUp5Pevmz2wbtg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFREMG4rR20wUytIMVdCazJ6TGRRdTU2YTVSUithR0x1SmVjN09ON1ZWczhw?=
 =?utf-8?B?eHJuVUwwWmxGZktkVURmQUxaalloTm1QVHNKQUR3Z3d5NVhtVUQzMWRmNVVU?=
 =?utf-8?B?THhxWDZZYTRFTm11WVJ5a3poVXpRcHRGY2pTc1JVWmlzWVBBNXhxQ1ZxOVVV?=
 =?utf-8?B?aEZiaU91UnVZaG4wRklQelNtME02ZlVoRG1NYTd2QStHMUtWc1ZtTHljQ2VV?=
 =?utf-8?B?NjZNU3J1TC9UZTJKRjR2M2tTR0tmTnVtbjJmNG4xcVZoVXY5a3lsM2JOTktZ?=
 =?utf-8?B?eWNHdG9tYUc3N2lMQjY1Z08zZG40YnliOHVRWm5KeU5pSTQvNXdqUG5rejJl?=
 =?utf-8?B?cXRNT1FPVzE5VnBXOU1vRnNva2tydE9hRG1NaUNLVVNOMCt3SyswK3lCbFVT?=
 =?utf-8?B?RWFYeWxSeXFJanR1RVV5WmE3NHJ1RndYdFA4anhmOFU4RlhKVkMveFoyK1Mv?=
 =?utf-8?B?aEEzSnE4eWFzb0Fia2I0TUR4SmMyMWJvSm80L0hCdFBhZyt0dFdqOUcyZ3dK?=
 =?utf-8?B?RmVQOXBWUlgrdkdtL1ZDM0RzdmxoQVduSGJjSzZaLzArSy96VEdwT0pZbkJD?=
 =?utf-8?B?eUdJeW9xZnNWU1VHMkFRYWt3c1RvRHkrTWlUMlBXYW1xTndCTkR3VW9uRi9o?=
 =?utf-8?B?NmdjZitRVkNCZFNyeml1MjB2d0NVZnBKL1dGWHMxM1VRYkg1YmZtTU5LWU1W?=
 =?utf-8?B?QVlUMmZwK2doY2UwazQyeHBlN3k3a0RTbTIxZ3BzVlBDUTdNeEgwcDdybGEy?=
 =?utf-8?B?QS8yVjdxNElUWXB6R0M2QVlsZlljNmVJaVlUa3RzbzlpeUJJZlhtQnAvSkNE?=
 =?utf-8?B?ZGtjN3FicmxweFdTMmozMXgzaTdqS21jZ0dEZGh1SHpDMGU1UUk1Q1JUaU56?=
 =?utf-8?B?Y1A0VzBFUDVIazNjSzFlRWV1ZzF4MFN0UmNhL3FtN1VTVVppbEhsOXZtZGxN?=
 =?utf-8?B?QnFkbHAxTDZhcXpNblhOdE9aZVJ5QnRXb1FEQ1VDYjdUVVFqSDJCblJpYnND?=
 =?utf-8?B?aElCVFYxT0F6ajk4Y0tMWDFKTm1EVUIxc1V2YkNYMFRQcW9UTG42UWg5QTFR?=
 =?utf-8?B?c0tab0YvMkhveXlOdWNPYi83aFU3WERUMzhKTFlONmwzdTZJWjFBVHFrbXpI?=
 =?utf-8?B?QXBUWnRJaDBpRkxMV20xbkxGRFZqS2FmQ1NMK09VWVdVU0tOL2h6SU13K3Y4?=
 =?utf-8?B?bmE4QzJNZW5lZmdUL3J6b0RRMEhsRUtjem9GM2I0cXdLdlhMenFVSmxaQkR4?=
 =?utf-8?B?d0p2dXcxSjdHSmMxbWtCTUdBdVlrbVpEOGVOZEZKMHdIQlYwUzg5WHc0WXly?=
 =?utf-8?B?TG9sWjF4VVpQRnluUWdNK2hDTFl3SGVFNHo2bTlYM3M2TDJtVEZYZWlwR2pO?=
 =?utf-8?B?QmpWc0F6aDlrdzZTalA5N3dzejJLS1pHM01RS2ZPallFOG9wbG4vSXJhQ3FP?=
 =?utf-8?B?U1BLNVovdElDQVY4c21rNEZSNVI4VzM1Rk9HOTNtQmlxcFk4VUliUm1BcGRH?=
 =?utf-8?B?dTM3cUlwdGcxNTJvQWhyeGVPeDRZTVFyQlFZN1I2WGJ2MlBURDdQdGUwbzJw?=
 =?utf-8?B?UklkdEgrZ21LVDY1c1c4cWhuQStIb1VVQ1k0TDJGb0VDTWkrUWNET1lXK0Ey?=
 =?utf-8?B?S2pBUDVzR2pOQUI3QWVONW9KcTNQRGNoblJlTTlPUTVjRS9YTVBvU1hVLzYz?=
 =?utf-8?B?NVROTWw1b0c3WkpmK0ZTS1hVYnJPMmFyRXlGSmJEczJPS1lna0VzQkVGYnhy?=
 =?utf-8?B?TjR4Zm1zVm1Pcitxd0VvRFRRMDdkNExhRmFwMVVrT21xczVxQ29BRjJtdGFm?=
 =?utf-8?B?dGhzVk1xbFRqdnhOeGw3TkxmdnhQNG41a3JEbFJ5My8rUWljSkw4UDRxMkNN?=
 =?utf-8?B?N1M2dGxiNUVabmJhWHN3UWx3Vm41NjZNWHNIN29sLzYrMzVpdG5GRXozeElt?=
 =?utf-8?B?eTZkTjU2dGIwWDNmYUVMNko4VEc3RzFZbjZhTzFHeGoxYlFzTWorZ2JNZ3R6?=
 =?utf-8?B?Rmlhd2x2UTBiTXA0LzQvT2hWNUNaMVJ2UnNiVFc3dk1zMzJGWk1mR2ZvcUtt?=
 =?utf-8?B?MlJXS1RzS0JSUnhBYmRlK211KzJwSURpbERYek9DK0Zlb2xkckx4SEQvQSsx?=
 =?utf-8?Q?GrhsjjdQQpJwYcjGe09D8//RT?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33805fe3-769d-45cd-540e-08dbfa509f34
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 13:53:58.2168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nQ837/kM5ggKRzOczbynkKxSWuQZpEZUq7uk5o0wPQUidwGpudAfDBL3/DH4cOYCOXtfDVKKZK1IJXRXq1ljUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8920
X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 11 Dec 2023 05:57:17 -0800 (PST)

Hi Namhyung,

>>>> By default, Perf uses precise cycles event when no explicit event is
>>>> specified by user. Precise cycles event is forwarded to ibs_op// pmu
>>>> on AMD. However, IBS has hw issue on certain Zen2 processors where
>>>> it might raise NMI without sample_valid bit set, which causes Unknown
>>>> NMI warnings. (Erratum #1215: IBS (Instruction Based Sampling) Counter
>>>> Valid Value May be Incorrect After Exit From Core C6 (CC6) State.) So,
>>>> use non-precise cycles as default event on affected processors.
>>>
>>> It seems like a kernel issue, do we have a kernel patch not to forward
>>> precise cycles or instructions events to IBS on the affected CPUs?
>>
>> I'm not sure how it's a kernel issue. User can use ibs_op// pmu directly
>> and might hit the hw bug.
> 
> Sorry for the late reply.  I know it's the user's fault when using ibs_op//
> directly but I think the kernel should not forward cycles:pp to IBS.

For all AMD zen uarchs, cycles:p is same as ibs_op// (man perf-list has
more detail). It's confusing if ibs_op// works but cycles:p fails on the
same machine.

No strong opinion though. I can prepare a kernel patch, if you want.

Thanks,
Ravi