Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Mon, 11 Dec 2023 07:15:35 -0800
In-Reply-To: <20231211030518.2722714-1-guanjun@linux.alibaba.com>
Mime-Version: 1.0
References: <20231211030518.2722714-1-guanjun@linux.alibaba.com>
Message-ID: <ZXcnlzDhcy8_CizZ@google.com>
Subject: Re: [PATCH 1/1] KVM: Move kvm_gmem_migrate_folio inside CONFIG_MIGRATION
From:   Sean Christopherson <seanjc@google.com>
To:     "'Guanjun'" <guanjun@linux.alibaba.com>
Cc:     dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org,
        kirill.shutemov@linux.intel.com, yu.c.zhang@linux.intel.com,
        tabba@google.com, xiaoyao.li@intel.com, pbonzini@redhat.com,
        x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Dec 11, 2023, 'Guanjun' wrote:
> From: Guanjun <guanjun@linux.alibaba.com>
>=20
> 'kvm_gmem_migrate_folio' is only used when CONFIG_MIGRATION
> is defined, And it will triggers the compiler warning about
> 'kvm_gmem_migrate_folio' defined but not used when CONFIG_MIGRATION
> isn't defined.
>=20
> The compiler complained like that:
> arch/x86/kvm/../../../virt/kvm/guest_memfd.c:262:12: error: =E2=80=98kvm_=
gmem_migrate_folio=E2=80=99 defined but not used [-Werror=3Dunused-function=
]
>   262 | static int kvm_gmem_migrate_folio(struct address_space *mapping,
>       |            ^~~~~~~~~~~~~~~~~~~~~~

Already fixed, commit 80583d0cfd8f ("KVM: guest-memfd: fix unused-function =
warning")
in kvm/next.

https://lore.kernel.org/all/20231208184908.2298225-1-pbonzini@redhat.com