Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Mon, 11 Dec 2023 10:18:48 -0500
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org,
        linux-mm@kvack.org
Subject: Re: [PATCH] maple_tree: fix typos/spellos etc.
Message-ID: <20231211151848.pr6xa5ksq4kwudmc@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org, linux-mm@kvack.org
References: <20231210063839.29967-1-rdunlap@infradead.org>
 <ZXYp60O0qxvPmuHu@casper.infradead.org>
 <20231210145601.177b543ca2ed28b9551575ff@linux-foundation.org>
 <f4a56419-088f-42e7-bf50-4afbe7c8f571@infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f4a56419-088f-42e7-bf50-4afbe7c8f571@infradead.org>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Qv+PseofUspfceyh8Q1w6WH2LQ18Rfj0Fl9E0ip0FZPfAua0msJZ86V7RMyA?=
 =?us-ascii?Q?mL53S0aPSdQyFPEILpv9O6CbwFqilQNW2KkaFlHdM4JWBn/mjBdnrwyWlX4p?=
 =?us-ascii?Q?ZaBEwJz5bk/Y2PoXOinIwpuOvmSeWMSnlZYUvKOP1KnwTaHLJqG16Bb87ZSe?=
 =?us-ascii?Q?iIE8KXujN48AKUu+vDyhWcA1w3oTshrc6/w2NK3y0x8DwhHHQ2YkyL12LmP3?=
 =?us-ascii?Q?kb9Ok247h3QZe38E0tv0FLBjyBJW90Qwij+cMHRat2f/Z2lu3xQhCTHWJLjt?=
 =?us-ascii?Q?hqqE1h5Q8JSrtU+P5S9B8BbiuD4PDDeOwn4IuAKdak25iJlWRXW6HNdECpuj?=
 =?us-ascii?Q?1u6kkcaunPZtyqFbeb1u6G6OoNAtgTpwZhp40adg3f20V12Vysza8Pehc44K?=
 =?us-ascii?Q?fc4vJaxqu1cj5flXvEtMe9zlagUj2tDMWj5Hf9DZi0+TmA8qF4e5ABW02vu/?=
 =?us-ascii?Q?ewr93MAUuqFM8T0M+7n9DeDTicOJoQ3aHVn+KLlb9jTCkW2Eb+xTOL1nfpOd?=
 =?us-ascii?Q?OUFr344PBCt11QXtP6mem/gQs+9xLpERhXJfFz3RzyD+QMRkBTIsQCBm83QH?=
 =?us-ascii?Q?YHWng/j3LSf0w4qDled6U4Tj/hipwthesEjznyf9MOQL97Ig/Ic6b05COAzM?=
 =?us-ascii?Q?VvrswwEJxVN6C8PGEjuoVFQFyhtJQE8LoG4F+V8jsKwP+vZwteM3cbnw32ew?=
 =?us-ascii?Q?tomTyJfBb4lkyRB8dIpQERSZ9MxG3iYHNm2sXUoSdOLHaNx8CZO6dzCQCNlc?=
 =?us-ascii?Q?UmjCDRsN0bpl2tZSq3AP8j5YGmrF0ZKpUl2EFF9vXhtEK2AFI6zOi6AfXb3d?=
 =?us-ascii?Q?BPskS0g8V1ZjSXpRmdcFj+HE0aWOshn+GslOUh5TFmf8e9+5g1jbTnfOQdX8?=
 =?us-ascii?Q?8n52vHSgnmEKyFKkj7027k4TKDiy2tZ+Db76L75vYaJvIEizqblXXnWsMV7X?=
 =?us-ascii?Q?4ihpFioerlMU5Lbb8c52kvPmQs+7kvcIJmWISSJqW2qcL6DT054N1t3mZfai?=
 =?us-ascii?Q?0yOkW1d6QnxOcFELx3VKGJvDTBt5YOVxQ++TcYkyszGO00jKYZzWAmU3Kwin?=
 =?us-ascii?Q?mtBzo4jxetidvNUVyq3gZW76WhfK4UfTqmttipR+iIdRny3/+Xy+SdJsPR0q?=
 =?us-ascii?Q?Bsex1siAjGQVBunmzxc8zb8lqPTFnVpcWN+byM8+AjvtMazkpyQMxNBGNRtm?=
 =?us-ascii?Q?5QDQg6fuxwqvu8gi7F/McUo5+uCJsVwh4Jeb6HaNoZXx1jpls73FIEj83je0?=
 =?us-ascii?Q?2cxO7vsLWqZWGXsb1RZwg47JUqjbbs9YHl8UlDNmp8jnPmxugVqNskjOtyRr?=
 =?us-ascii?Q?iXiCKD3xmyG/DnC6GEzimE3qbJLFwl9SMp/A/cwgJvfKSnTS4ULA86Rmckne?=
 =?us-ascii?Q?uAYWxgpa933nEQa9CM0SsEALvPj7dkRP+BO8nDx1MMYh1hBmiUxrnJ2Ecd9G?=
 =?us-ascii?Q?aFsKrSQKFdkG7+Y1LzrD1xDMnv4rjcHJcTw3+WvFfiGyCJY6icnOLi8WvcHe?=
 =?us-ascii?Q?gvD5G1T+y0mZgM65BaCthycqZjcnpQo5yxE6rEX2Xw/3BDXE0mswCCGwEdEu?=
 =?us-ascii?Q?jA/3sf+pbKT2O0WXduvnyRC9Y8Pvbxe38QV1ZR4z?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?BkHVXt6SyXJHV6KGwPNgAIcbd6sFzSitMTXCLl3MFGaxBfdtIDEMtWC0bMt4?=
 =?us-ascii?Q?z64DpuoLU+7TdK4USZd9oYZshbEVhfH3UMuvg57RRxWLzTw8vFkmsVTXlF6C?=
 =?us-ascii?Q?d+ZLX0TkPizndtzTH+brVQze7zUtnpoYWiPJMLDN5FbdY6eRVijyzXAQTPIP?=
 =?us-ascii?Q?C+cIh/Vnu4AvL2nOiAnAy0ngEksZgG7QUz99zu56YQf6YN027zt534oPxEF2?=
 =?us-ascii?Q?IuqpIZ7+j1ySr4ilhbL++ymJJcd55i7ElFUZEUHRJ6RW8UOmWtLqp5XKdgps?=
 =?us-ascii?Q?O85kzvwXae4fAFM1pFzJg/nHxxlQ3oEuI4L8tfEEDBZBHCjrBy8WkRyB4O1R?=
 =?us-ascii?Q?ms1SEfYtWo/OWSRIbLO7bHiIhCN98TPoaIiHnxfe9Ui5weTEnliPSpRBrYXh?=
 =?us-ascii?Q?A9SAd+7G14sH6kAawfWsuaHgwlGriFhH9Sr+aUZufYOSxkSCLNpyb03uYeVe?=
 =?us-ascii?Q?g+M2NEazf+T+PmkfXrvwMwQd9hj3TnCQ94CNoVeL151IW3sgV4plLVaq8S0s?=
 =?us-ascii?Q?282L18bEiVXnkWCcM7ctVvntoxV24i7bnYTcPDFvSNawWj1wXoR0n4IF//Cb?=
 =?us-ascii?Q?g/PdTYa3//Ivtkr/Z0sJx3me4iM4OkjcrAlozgj2/alQly5H3kw50WLOY7Jc?=
 =?us-ascii?Q?Vj9umtA5+GhHv4oRDsjjiqpUB4hWrlD5ws/gqSJKhjxWER+Btow7/fcFZEU0?=
 =?us-ascii?Q?Uzr5sl7pfhBnYxfvbVSODJJiEbpjWcYvzWj/9xMF5YDpIV/5AJt6M969wj7S?=
 =?us-ascii?Q?A91NloODWE2bVLCANIJvyHAuphWljWPWBQ9eOU3wIjqR5kbuJq1Sz7LDNkrR?=
 =?us-ascii?Q?UHGL/n5J5oHUjeQVux314+RQn95EwP5MxtBswTqqnwjAhA2Xw7y97KZ2l+On?=
 =?us-ascii?Q?umasPXhpfBYl926I8MsHWY/pU9C7wRvxokZ7y6qg2koqI6MorepGdMegVqYZ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 153b768f-7843-43c1-6d15-08dbfa5c7aa1
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 15:18:50.6226
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OMCivPHMb+gJp9BCDdGJZ9QhE/srgCo0EGzWXH/5hNhAtsNBtQ+fuxNIxNMX/dHb7o94iTdrmiDt/ATQ75/IXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7131
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-11_07,2023-12-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0
 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312110126
X-Proofpoint-GUID: WcMfs9fUZZsDR-srGgQNemJwJSKHisWs
X-Proofpoint-ORIG-GUID: WcMfs9fUZZsDR-srGgQNemJwJSKHisWs
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 11 Dec 2023 07:27:36 -0800 (PST)

* Randy Dunlap <rdunlap@infradead.org> [231210 18:54]:
> 
> 
> On 12/10/23 14:56, Andrew Morton wrote:
> > On Sun, 10 Dec 2023 21:13:15 +0000 Matthew Wilcox <willy@infradead.org> wrote:
> > 
> >> On Sat, Dec 09, 2023 at 10:38:39PM -0800, Randy Dunlap wrote:
> >>> - * mas_topiary_node() - Dispose of a singe node
> >>> + * mas_topiary_node() - Dispose of a single node
> >>
> >> That's all well and good, but how do we dispose of singed nodes now?
> > 
> > Lol, this is my all-time favorite typo!
> > 
> > 
> > hp2:/usr/src/mm> git log | grep Singed-off-by | wc -l
> > 59
> > 
> > (sounds painful)
> > 
> > hp2:/usr/src/linux-6.7-rc4> grep -ri singe .
> > 
> 
> Current linux-next shows:
> 
> $ git grep -iw  singe
> arch/x86/events/intel/pt.c:      * In case of singe-entry ToPA, always put the self-referencing END
> arch/x86/kvm/vmx/vmx.c:  * evmcs in singe VM shares same assist page.
> drivers/input/misc/yealink.c:           /* Combine up to <len> consecutive LCD bytes in a singe request
> drivers/net/ethernet/brocade/bna/bfa_defs_status.h: * NOTE: The error msgs are auto generated from the comments. Only singe line
> kernel/trace/trace_events_filter.c: * struct prog_entry - a singe entry in the filter program
> lib/maple_tree.c: * mas_topiary_node() - Dispose of a singe node
> lib/maple_tree.c:       /* New root needs a singe node */
> sound/core/seq/seq_queue.c:/* enqueue a event to singe queue */
> sound/pci/rme9652/hdspm.c:      /* Changing between Singe, Double and Quad speed is not
> 
> but there is also "unsinged", "assinged", & "singel" if the -w is omitted.
> 
> And somehow the two Chinese translations of submitting-patches.rst contain
> Singed-off-by.
> 

Nodes become singed, especially around the edges, when writes are too
fast.  We have to replace them with fresh nodes, otherwise tasks can't
find the VMAs in that area.

I will have to research how these other people were able to implement
'unsinged' - maybe there's a way to reuse these singed areas more
effectively.