Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <5581434e-92e6-4a67-a68b-1abb56bc0d99@amd.com>
Date:   Mon, 11 Dec 2023 10:28:19 -0500
User-Agent: Mozilla Thunderbird
Cc:     yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
        avadhut.naik@amd.com, john.allen@amd.com, william.roche@oracle.com,
        muralidhara.mk@amd.com
Subject: Re: [PATCH v3 1/3] RAS: Introduce AMD Address Translation Library
To:     Borislav Petkov <bp@alien8.de>
References: <20231210194932.43992-1-yazen.ghannam@amd.com>
 <20231210194932.43992-2-yazen.ghannam@amd.com>
 <20231211142055.GHZXcax0W+WD5/YBgm@fat_crate.local>
Content-Language: en-US
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20231211142055.GHZXcax0W+WD5/YBgm@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTlCZEZJdXFvTTJDN3NZaENScm1YZ05OOS9BcUFUMmh1RjBmNUNQSWFmQkl2?=
 =?utf-8?B?cmhmdlBLN05HRnBzb0txTk41cjNwbnhSZEtQUktOVmphS2NPNGpWMHppSGRl?=
 =?utf-8?B?aGxWZ2E4eUI1d3ZoYXk1M01GWW1IWE1aRUV6RGMySU00Q2NBSWhYZzlJMk96?=
 =?utf-8?B?ZFhkTTFNRWRMS0hGandXU0JQS3ROUklVVFg5WG5yZTZaNVRGMFZwbmdrelQ2?=
 =?utf-8?B?K0Y0dnZDTERhSEJKY0MyMUg0emRIbmZVK25pT2dnMGV2SU9rdkRFQjdEZEx6?=
 =?utf-8?B?WlpzZVAvOTJJaGJpTTVvNURtakpEc3hmRWtWdjdkanJXNGdKaWx6aTVsdXU1?=
 =?utf-8?B?djFLTjRSWFduMkN6L0pFQ2ZxdG1TemZsOHVKOHA3K0hocTZEN3ZjTGpBczl5?=
 =?utf-8?B?TU1xSWRQN0lBeFVEZHdDZDFzVWh3RlNGTjRpNDRQMmJVM1cxYUZQZ1V3Vyto?=
 =?utf-8?B?dGdveCs3MmVoMjVKS2lWdFoweG1qSWtmTW5kTjNlTkFrR0hQYW5DZHdhNXMr?=
 =?utf-8?B?eEhKWFh6dnhCNG5YbUROZVpGZlkwby84emM2YWtnUG9jUmRUMUVkNGNNU3N5?=
 =?utf-8?B?Nmw5SDhBWjhlUlVWeFY0d00zRG5icERmdy9ac1hLYTVkVGtuWnpZVGRoMG14?=
 =?utf-8?B?YktDL2FCNlJIVzlPWU5wTmE0NjJmSjR6c3o1UWprKzVhYzhyTHF3dWtIdUQ2?=
 =?utf-8?B?WmQwQk0xVWVDWlM4eFhxOG9sc2l5UUc5WDJNbkcwcDMvSERPQUxycHBvRW5x?=
 =?utf-8?B?ZUhVQmlkRkJLbE10RW9OZnEzTXdFWDBGdUFaakMvNEgxS2ZURklJV1VNWjdX?=
 =?utf-8?B?RXorVXZtcTBXaUhLdXdPSGNaZ1B3ZjRSMFY1dWRJU3dwaWJSSFhxSFNzNjJ3?=
 =?utf-8?B?aXVjcUNYdkExSHdTMWxZbEp2U2Vyc0xac3QxUE5uMC8wTm40YTVrNGJpeXJs?=
 =?utf-8?B?NW4zc2NCUjNVV1hKTjJ4Z2VBRmFmczY1RDNMTzZOZ1U0d2xEVW53N2RoTVVp?=
 =?utf-8?B?V1dYa2d2VEVyeW1kQTJ0VTRUVXJ4b2NCKys4OE1xcTk1WGtra0FmbFlWYjUx?=
 =?utf-8?B?K3ZzRk53MXBzNGZXbHoxbU03WjdhKytFTDk4eTFLWmZteldjVDdtRHVLTGli?=
 =?utf-8?B?ZnRjcis3NXRvWHZlL2FLLzUrdE56MlhDb2I2VVIvRDVYdXVaM1lOdW5RQ20x?=
 =?utf-8?B?bWFnL0JlSGVCaGtyd2l6cCs4c1c5TmJmU2JRNk9PdXVodWpYbnJweHcrNTNL?=
 =?utf-8?B?cnFsWUIray9pVjY4MCtLZWV6Ri9WU2xSdWZIcVRDZkJRWStBNmtKM2wxMW5k?=
 =?utf-8?B?Rnh1WTlaeDlmTTQyRitndWEzS1l2SUpGSzZpVk00QVhtSDZ6OXFHcWR1SWpO?=
 =?utf-8?B?QXlxMXViQTRXODBneWE5UjZTaGkrcDl1WWR5U0VjSE90ZVZsSG9BVFRDV215?=
 =?utf-8?B?OU1KOHUxc01KdjNYSkJOMkZLODNESzVITUsydmJHTGJpSlZaNS9pTDg0b2tN?=
 =?utf-8?B?cDRUSWNmeUlqL0JVZndjNmxLVVhxUkU2TzJjWHgza1orRFlidXRWa3ljOGZz?=
 =?utf-8?B?V1pzaDI0bmhLZHhqMUFNbVBhZkl6bjFXK2RMN2tYWUs1eWZsR1Z0WTBzc1JT?=
 =?utf-8?B?YXRzVGZ3MlRRWlRoWklFYjdHb3k4MW1MT0FCWnBCaCtyWDNUWDdManZibkVo?=
 =?utf-8?B?a1FQVDdEYTZaR1F2cFd6ZGl4Y1dGRVIxdVRNeWNlZHI1WWltRmI2T0p4ZFkz?=
 =?utf-8?B?TCs5aEhYYmNmNFQ5VnBUNkNMNVNKNGNkaXJ4N3NNalByNzM5eVpzc1pwN093?=
 =?utf-8?B?Y3FBUHJRRXlEWjlvcFFGczVJYW1nV3MrYUcxazQ2cjFEU3E3THhlNXBURHE0?=
 =?utf-8?B?ckRmTHlFM1ppWHZ4NVc3ZVBXLzBUUEQ4SzJiV25NNzE0REVDOVViNDRHWGc2?=
 =?utf-8?B?WmV5a3IrVnVXUUpDRmpuaWh0R1N5WFdhMmRpclQ0TGJ2dFYzU3ZzOTFPaTBa?=
 =?utf-8?B?b3h0cGVJT3FYWXY2c25oSGt5N0lrbTZ4VUdIRmFPNlpzWWdFcnV0dy9kM1pz?=
 =?utf-8?B?NGVXcHVjVEtRZHBnQWFQOWFBczZaaTExbUVFMUwzODZhT01BMk9iZFRnVTIw?=
 =?utf-8?Q?UIQfxhNFmYLl8qCjRbEvNiXvy?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9580a98f-16f0-4c40-dad0-08dbfa5dcf4a
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 15:28:22.2925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NZSG5KV0govBRgrozzYs3clq/YV5ohlz6THjLcnYcjHxCv+7U7QQBNSEO0CkPGbp858D5FTnzqw5Z4xVj+sPMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7362
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 11 Dec 2023 07:28:40 -0800 (PST)

On 12/11/2023 9:20 AM, Borislav Petkov wrote:
> On Sun, Dec 10, 2023 at 01:49:30PM -0600, Yazen Ghannam wrote:
>> diff --git a/drivers/ras/amd/atl/Kconfig b/drivers/ras/amd/atl/Kconfig
>> new file mode 100644
>> index 000000000000..fcff387faa33
>> --- /dev/null
>> +++ b/drivers/ras/amd/atl/Kconfig
>> @@ -0,0 +1,41 @@
>> +# SPDX-License-Identifier: GPL-2.0-or-later
>> +#
>> +# AMD Address Translation Library Kconfig
>> +#
>> +# Copyright (c) 2023, Advanced Micro Devices, Inc.
>> +# All Rights Reserved.
>> +#
>> +# Author: Yazen Ghannam <Yazen.Ghannam@amd.com>
>> +
>> +config AMD_ATL
>> +	tristate "AMD Address Translation Library"
>> +	depends on AMD_NB
>> +	imply AMD_ATL_MOD
>> +	select AMD_ATL_STUB
>> +	default N
>> +	help
>> +	  This library includes support for implementation-specific
>> +	  address translation procedures needed for various error
>> +	  handling cases.
>> +
>> +	  Enable this option if using DRAM ECC on Zen-based systems
>> +	  and OS-based error handling.
>> +
>> +config AMD_ATL_MOD
>> +	tristate "AMD Address Translation Library module"
>> +	depends on X86_64
>> +	default N
>> +	help
>> +	  This option provides the module component of the AMD Address
>> +	  Translation Library. It will be selected automatically if
>> +	  building the library. Minimal dependencies are given to avoid
>> +	  build errors for modules using the library.
>> +
>> +config AMD_ATL_STUB
>> +	bool "AMD Address Translation Library stub"
>> +	default N
>> +	help
>> +	  This option provides minimal built-in code to support the
>> +	  AMD Address Translation Library module. It will be selected
>> +	  automatically if building the library. No dependencies are given
>> +	  to avoid build errors for modules using the library.
> 
> So, provided this stub thing even makes sense (I need to continue
> looking first since this is a huge diff), you don't need the help text
> and the bool prompt: a stub is prompt-less and is selected
> automatically.
> 
> IOW:
> 
> diff --git a/drivers/ras/amd/atl/Kconfig b/drivers/ras/amd/atl/Kconfig
> index fcff387faa33..348498d49b01 100644
> --- a/drivers/ras/amd/atl/Kconfig
> +++ b/drivers/ras/amd/atl/Kconfig
> @@ -32,10 +32,4 @@ config AMD_ATL_MOD
>   	  build errors for modules using the library.
>   
>   config AMD_ATL_STUB
> -	bool "AMD Address Translation Library stub"
> -	default N
> -	help
> -	  This option provides minimal built-in code to support the
> -	  AMD Address Translation Library module. It will be selected
> -	  automatically if building the library. No dependencies are given
> -	  to avoid build errors for modules using the library.
> +	def_bool N
> 

Ah good deal. Better than padding to meet a minimum length. :)

Thanks,
Yazen