Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
To:     agross@kernel.org, andersson@kernel.org
Cc:     hardevsinh.palaniya@siliconsignals.io,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] rpmsg: glink: Fix buffer overflow
Date:   Mon, 11 Dec 2023 21:32:20 +0530
Message-Id: <20231211160221.2843339-1-hardevsinh.palaniya@siliconsignals.io>
Content-Transfer-Encoding: 7BIT
Content-Type:   text/plain; charset=US-ASCII
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oqDLGel4uYTYONAeYXmXVzD9dGmrFiZCj+mdq5GpbpLtx0RQG5VYw2mbySn5?=
 =?us-ascii?Q?neWPg7dxsACorTyFWWaVL/3h4TAPQsnBIwFiALjebcDZHcu0llUb8JCKu3St?=
 =?us-ascii?Q?l9ivv6qoz3sISC2t/gvyGxuraILyv8ejBue4VEYhfXHPkHmaP4a0obUzbNnw?=
 =?us-ascii?Q?xDnnx7OdT/iFGqSPgPSpGXfQLzUIcCIP/c2ETJLwpbemdz421Gy+G3+bzeNr?=
 =?us-ascii?Q?c4iP+ryvKNzvVHbVyyzGy845dhl0sO0h4RPFMK8hQ+doZfnp89lSTjgk02bC?=
 =?us-ascii?Q?Ioq3D7/xiZ2sB36izgqKQ/vaiMJu/GSmuQuJeZ9IgAjgTerPZC8XzXORcGpj?=
 =?us-ascii?Q?w/R1v2as07i5xbMaw4JpFaWO7pQbH2BtMLzT8ZH5H/X8iIJVpyRz5ImY532Y?=
 =?us-ascii?Q?QTeqYrgujBuOt+ufE2hv/6SZ1lTr8T59TNSQhj+FWxqonRUrzxiYgxZ15v8h?=
 =?us-ascii?Q?yIzjhma1y1MSXToRraB2Yejq9mFTP/MMnTo1nVYyDRy+3DPBdQ8/hjxn9JDj?=
 =?us-ascii?Q?KnaYnS5hOlrXeCKhR9WySZNNiZmIBk15l/m1PmAM8NDCCgLxHfSdWaM6duvo?=
 =?us-ascii?Q?bhMo9b1WE/FePkCkwLiUX513LaWR4ZJHkaagNnsZISRzcgbH+E3HKMrduFA9?=
 =?us-ascii?Q?jKmeyOmdyi2gy0rIyEUxSXccga2Hvpm/VGYkVaYpM3no3MquIjgID1vyZ+xH?=
 =?us-ascii?Q?9TYEOgM7hdBHX8P3SWqLYH4Gt5pknRmEXU3eOmdLGb5eMCsHGG1nicWht4kx?=
 =?us-ascii?Q?2k8/A+Aohqtjh2wqjRZxUGg1RYHzyzEjek6/FHZyjsAATKox45nQf3JzKfLn?=
 =?us-ascii?Q?MS+GUeipJqJQoxg+BVC8ibTvh5/uaBg8rbNyvVmXoGIJ3+D4StRTB06MLLOp?=
 =?us-ascii?Q?01koEnp21wHsA3UDSuNZbKe52JPEGEPsylPpBa2BMtMkG4xrIJNyZAQZmkdY?=
 =?us-ascii?Q?EAhXBY6DFXfdObMeeEtpatjXsjZxrbW6p+VfMAuk5+DqY6Ijvsx6cGckCJfd?=
 =?us-ascii?Q?DnEZkBagpZdDVAiZfsbqCpUMaHiu+19Q1qNp7/YTdYT9ddzEtnzbXzXuUoNo?=
 =?us-ascii?Q?+gzd5MlR9pXy7HHui6J291nEdlueqAti0psW1F+N5hrmBiEmsM4A7KJK81IH?=
 =?us-ascii?Q?7aseSdrA+uuNABpRA5Dt0sOUmWGGu0lmEA17xfa45rfK47VTADNJALjIb6rF?=
 =?us-ascii?Q?VlxZgNYKkYq57eKzkj7DwO0x/u38KyTB4t4vNal1IYgWCkEu74eH9R7dbShV?=
 =?us-ascii?Q?YD8y/tRuuuAX+iBR3gp5jXSw0S5EnwuLvxKwKDbMrCegGU5y4aEFSsZNKYlP?=
 =?us-ascii?Q?d8lcSwsaPtj3AY8J2aGw84Sew+KEEmqt8oJmD4dboGkMgGhFoiZwldY7m6LO?=
 =?us-ascii?Q?J+meLl8xmVL4MQjJdmTMNiNTkHdkk2H47mGP9pMxawDD13e3tRupGmTeKYCF?=
 =?us-ascii?Q?pN9hMylV6FgmSqN95nYZ3dGU6T8OXgT0YT0rlmSbcIu4GWTV6C6if/6riN4P?=
 =?us-ascii?Q?al0KDP9z6Q0bHgW+6QqpOmfJpEMebXeSwMJkSCzgizBT9J/pDLmWWhiFL4Kb?=
 =?us-ascii?Q?fY8p6lkY2p8yuK4JCKNRMVw28lZ+NNhlU/snuxi52akPJPdog2wYwoClyQ+J?=
 =?us-ascii?Q?qym3MF00iIZX6gTTV9fvXyA=3D?=
X-OriginatorOrg: siliconsignals.io
X-MS-Exchange-CrossTenant-Network-Message-Id: 71e6ed76-8018-4cd6-e85a-08dbfa629d59
X-MS-Exchange-CrossTenant-AuthSource: MA0PR01MB7145.INDPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 16:02:45.8270
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: djOIM3mWpYChPj84U+kQG9qQaF5g+z3i6W0uJlM3rYxEbXiIU0Ftk0Rw8ARcR8gkbyPp/TQcM2b8U0WZKZd+y/aSuJn/Ez5Zh4u3LK3uqkBFBXka8NGaxs2yWzvoF3ub
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNXPR01MB6786
X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 11 Dec 2023 08:04:25 -0800 (PST)

In qcom_glink_send_open_req() remove error: strcpy() 'channel->name'
too large for 'req.name' (1010102 vs 32)

Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>

diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 82d460ff4777..2d6a592e1c72 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -479,7 +479,7 @@ static int qcom_glink_send_open_req(struct qcom_glink *glink,
 	req.msg.cmd = cpu_to_le16(GLINK_CMD_OPEN);
 	req.msg.param1 = cpu_to_le16(channel->lcid);
 	req.msg.param2 = cpu_to_le32(name_len);
-	strcpy(req.name, channel->name);
+	strscpy_pad(req.name, channel->name, sizeof(req.name));
 
 	ret = qcom_glink_tx(glink, &req, req_len, NULL, 0, true);
 	if (ret)
-- 
2.25.1