Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4079071rdb; Mon, 11 Dec 2023 08:15:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNIHafItldTWcWl6nTrGa1HrBYxujDTFPXu2ewfA2QLaoWdIHgvl5lNBPZvVVA3yEISv4w X-Received: by 2002:a05:6a00:4b11:b0:6c3:415a:5c05 with SMTP id kq17-20020a056a004b1100b006c3415a5c05mr5062395pfb.14.1702311339466; Mon, 11 Dec 2023 08:15:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702311339; cv=none; d=google.com; s=arc-20160816; b=HTTW7dJRtHcDgoEWIRIpTqQvEiNp4O3Q1qpQdkv8g1XB61b7PkwrRYNl4Uo8DuMPzC 2Tb+/c/iyxpfS8Evf1v4fyvYi16Mo4hQnrhkBV3UHbZX2Gd/B8nwwm7VBnWEKRUmtL3d Dokq2xJ8JqfQEWfPxSj4UEUjTaVy1KlkG8JiWmOmcKM0Hteryo8KV4fjgTKFDmRQza+s aGSmtHe5p2PHUXGOEnywBjAne4iG2mypmc+CeF2g9PRxQ79Zh1uW+Qi24zM0MtZkvDKb 2TOhJugz+qwti8qUkM5urRgLuO7As2WiUH1EKRcXg01jCUbszYDnkb8Z2bokitYAY1+F W8AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gezEdtYhaIxe/fWsl459Ba6u1C7m+8fj9hdgHURkMxg=; fh=Hi5SUFq/5RGQKtkIvKz4w2xilCKoit3DBeUekAhHJMU=; b=uTBmPAMELdRKi3N9x28sR8MDTDSGYDRq0JaSJOm5jqn+DpHyGPO69HsG9ZgcEz3iV9 dlWIAUFNDfNQmof9Bp8I3UQrxOxvcTSpumPWHzjtFTbUWdmg8u8Q7fIFBPmK4vvKQcAu mh1fljfT8ZruSnnBurzfRKhXYPNXeINeiEy+SKyOzWGmAt93JujibS+EuQ6kloHgX7/T TRYTScCaU3vjUl0wxtobT8DUwuDjy2hoA/87eTFdh39aKBRyrmIqDLB5JdatdSPfUi70 CmXcwIUDnLSOlowe7v7u7D3fNMV9qSa8zr0ZemHnEQdCU5bHiPQe/yMJiLE0xiQhHNAt 34Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=TFgvBWqB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id p125-20020a634283000000b005c6676349ffsi6018320pga.613.2023.12.11.08.15.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 08:15:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=TFgvBWqB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id AFD09805D6EC; Mon, 11 Dec 2023 06:22:45 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344071AbjLKOWc (ORCPT + 99 others); Mon, 11 Dec 2023 09:22:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343935AbjLKOWO (ORCPT ); Mon, 11 Dec 2023 09:22:14 -0500 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7CFF386D; Mon, 11 Dec 2023 06:21:15 -0800 (PST) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 5903040E01AB; Mon, 11 Dec 2023 14:21:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Z2N06UjmoT9y; Mon, 11 Dec 2023 14:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1702304470; bh=gezEdtYhaIxe/fWsl459Ba6u1C7m+8fj9hdgHURkMxg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TFgvBWqBOCSqAp+bJFiNyhAooxk12oHs3vH9E9Cg3ZmHNguLYvSVhEIRD97Hvmc8o kLzfTbTOIzwHP3k2a50131kbU0dEMV/o7G8X9aK0nrfyZ8QBft/1nRoPesV4dMPVy6 nlF0zlmo9tUNHGIAlCNHaeO0OfWvwlPW+81hsK4M1nA4IuonRZIqSS2Vv44ZozrbXJ lz+QkTJbt0+qmyQvtj5WO1UvCQjmnBSOH31GrChFmwu+PR7WnlRJBWudwK0C6cc2uu gYyckDwW+XS7nXoAsnFmXl4LidAr1qoROTj0rAWKJgDM5060hNLt+W3L2EVd9bgAld BrF7EgV14xqBKdUbvYJB2KVr4wXGXb/dAZ7Gdplh2yy2MvscQBSLL8NIuqI4c9cOWp zJDocthdv5rjz1xnDxAJ4C8ggV1mJNAYERvej7IjX4uGVYC/MvP3o7wKFgcCsDHvA6 zJGs/EcX6k/9Uj2t4fYY/elzU54h6gpcOl5lykXd6BaC0UG6S/E4vzRww/9Lr24WDg 6feMSI1ob7sR2A6TQ7A6A6Evr/wZUuLhA4pDWC3UScayh7ASC7rwk6aJ4lCkPBq2X3 vAdoAd0rp/KzRVxxiZmh3ajduLm6MEkyQkyPvsYNlD2eZXJ6HZL79SAbtnGaaF552Z rdtb1vSmCQLsr1nLejEqXvzU= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4F69440E0140; Mon, 11 Dec 2023 14:21:01 +0000 (UTC) Date: Mon, 11 Dec 2023 15:20:55 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org, avadhut.naik@amd.com, john.allen@amd.com, william.roche@oracle.com, muralidhara.mk@amd.com Subject: Re: [PATCH v3 1/3] RAS: Introduce AMD Address Translation Library Message-ID: <20231211142055.GHZXcax0W+WD5/YBgm@fat_crate.local> References: <20231210194932.43992-1-yazen.ghannam@amd.com> <20231210194932.43992-2-yazen.ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231210194932.43992-2-yazen.ghannam@amd.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 11 Dec 2023 06:22:45 -0800 (PST) On Sun, Dec 10, 2023 at 01:49:30PM -0600, Yazen Ghannam wrote: > diff --git a/drivers/ras/amd/atl/Kconfig b/drivers/ras/amd/atl/Kconfig > new file mode 100644 > index 000000000000..fcff387faa33 > --- /dev/null > +++ b/drivers/ras/amd/atl/Kconfig > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later > +# > +# AMD Address Translation Library Kconfig > +# > +# Copyright (c) 2023, Advanced Micro Devices, Inc. > +# All Rights Reserved. > +# > +# Author: Yazen Ghannam > + > +config AMD_ATL > + tristate "AMD Address Translation Library" > + depends on AMD_NB > + imply AMD_ATL_MOD > + select AMD_ATL_STUB > + default N > + help > + This library includes support for implementation-specific > + address translation procedures needed for various error > + handling cases. > + > + Enable this option if using DRAM ECC on Zen-based systems > + and OS-based error handling. > + > +config AMD_ATL_MOD > + tristate "AMD Address Translation Library module" > + depends on X86_64 > + default N > + help > + This option provides the module component of the AMD Address > + Translation Library. It will be selected automatically if > + building the library. Minimal dependencies are given to avoid > + build errors for modules using the library. > + > +config AMD_ATL_STUB > + bool "AMD Address Translation Library stub" > + default N > + help > + This option provides minimal built-in code to support the > + AMD Address Translation Library module. It will be selected > + automatically if building the library. No dependencies are given > + to avoid build errors for modules using the library. So, provided this stub thing even makes sense (I need to continue looking first since this is a huge diff), you don't need the help text and the bool prompt: a stub is prompt-less and is selected automatically. IOW: diff --git a/drivers/ras/amd/atl/Kconfig b/drivers/ras/amd/atl/Kconfig index fcff387faa33..348498d49b01 100644 --- a/drivers/ras/amd/atl/Kconfig +++ b/drivers/ras/amd/atl/Kconfig @@ -32,10 +32,4 @@ config AMD_ATL_MOD build errors for modules using the library. config AMD_ATL_STUB - bool "AMD Address Translation Library stub" - default N - help - This option provides minimal built-in code to support the - AMD Address Translation Library module. It will be selected - automatically if building the library. No dependencies are given - to avoid build errors for modules using the library. + def_bool N -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette