Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 11 Dec 2023 11:29:54 -0500
From:   Kris Van Hees <kris.van.hees@oracle.com>
To:     Masami Hiramatsu <mhiramat@kernel.org>
Cc:     Kris Van Hees <kris.van.hees@oracle.com>,
        linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
        linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        Nick Alcock <nick.alcock@oracle.com>,
        Alan Maguire <alan.maguire@oracle.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Jiri Olsa <olsajiri@gmail.com>
Subject: Re: [PATCH 2/6] module: add CONFIG_BUILTIN_RANGES option
Message-ID: <ZXcntGeMdn0/1V9F@oracle.com>
References: <20231208050752.2787575-1-kris.van.hees@oracle.com>
 <20231208050752.2787575-3-kris.van.hees@oracle.com>
 <20231209075917.833c8f1ae78172dbb1d83b97@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231209075917.833c8f1ae78172dbb1d83b97@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iHyc/pEEHJrSfYWcJGhj1Cni82CUub56Vr7STKmsJXvcQQXwzRXamMEZEs8s?=
 =?us-ascii?Q?+OES8b8yYDiyUrw9tdMRjZTmWc8+M6ALJmTSKQ0R5zLO9nAG95K5fOovdc+O?=
 =?us-ascii?Q?f9ev3y3KvOmYwRqxtURy4rnEXvSpoHUzdxbyzb1vP43BxEbX8GVBbJXlOeG5?=
 =?us-ascii?Q?t4LLk9LMQcOaf1UU8vh097+jYfGgH3R46tFTTtDUSkXXMvYhoaK04qo6hXah?=
 =?us-ascii?Q?YNm8eskC+Van21HDQRyOs7y2+t1A9aU5sDUTaOkX7Dps4xwJWFcajjfVmWmc?=
 =?us-ascii?Q?rhw2A2WseR5GYRP69oQk9KpQ5w+4ausivKKpfW0RJh5o/RIHwGgOr2myhISY?=
 =?us-ascii?Q?qGnC0KAt4AFCk6YtUh8jVyU2XXDo7Z7aaou7jJNNQhMNBVnw/M8auk7PR6UQ?=
 =?us-ascii?Q?lciRooSSNYf6/6nvmRUphJgt/zY4ygnD6eYC3rhX1x6vZC8S/6TRCbBUeLou?=
 =?us-ascii?Q?pbAd/kVkFnlV7f+hAhMd6bGp12+ahcirIwuKyWJO52K2hsbX+KCwKOwALEmz?=
 =?us-ascii?Q?G066QRsLsiCAlKL1SE8SJbXT+RIx3J/mUAAdyrETAcoroouaTMUFp1iThxHm?=
 =?us-ascii?Q?+jlAR9gBK1v3wlZ3OLnVxeKBg9G/A1QQsNkwbM2wzV2wBV7TsFNS18kKDzD2?=
 =?us-ascii?Q?D4xx3hFPghgdRB9HSLrrEmE4GAJ4f/zpptFSfXG0Xe4v1MhDWjk6/zrI1n8g?=
 =?us-ascii?Q?xPt14yoLBu2MCqrCKj6JgEO45Te1afMkrYdqEFU+OonRxUWgKbbfPyOsZwTS?=
 =?us-ascii?Q?qhk0VeZQVV6k2eJcO6fi/Pq5lHZFaEuO4r0wx9hTzpgq8KrNNVQslcKJ2rU0?=
 =?us-ascii?Q?yRCMv9cZelE2F1Jhn2Fy7dSoh4lt1Ggp8SEsKp8goq+kAE0TpxULG+B+zoSc?=
 =?us-ascii?Q?8cS8h4kpAF6KK4hyKf9grmLteLTJgT9Akm5/MhtUdUyPXCUqBGpo0AQg34+k?=
 =?us-ascii?Q?aDxjgWpkJrhTEfxeMuQdGTusy9AU+SUxa4GLyEUxoQXM9vpoJ+yVOSuHnv3e?=
 =?us-ascii?Q?9FbAAGNgiHT2MjzZuu/+ZFWpV+LFt0e9YhwaSYEwxcuPxcqXBkz1cFuUdXxm?=
 =?us-ascii?Q?RiAzFxc3URiSBhDZqgbRWvONMu0HsEUueQHAwfkAuhe1aU4O7xnC0iPn2HvN?=
 =?us-ascii?Q?DgKvmqsQWQIdm2aH7nVzsus0rhAgXqe93RAUrt+Dx3c5Rd5f7Q1cIE/c4f7F?=
 =?us-ascii?Q?xYr+PXdpKpHJornXK2bL7BcNJuKoWanryRgiGHf+qcTEf4lIyt35OMac10a1?=
 =?us-ascii?Q?+WIKggizOyKfQdbzILc1ZM5/jDfcQPLYCRtLJZVxdU94YQxmFsdv8yQjgICK?=
 =?us-ascii?Q?z/L2gEa8/zmdkdMWsZzlhZAIe/2NJQbyHqricsUY1eAXcXLeRMKEIYVJANbn?=
 =?us-ascii?Q?iI2Uosv0+5kajXTj91fbDw5alwQ59YS36e0LWT2WekGvMJgtnTySc2ZDACHh?=
 =?us-ascii?Q?F1vkq/LIJldxQBgYgzAe1j61v9xNrOAw9tMFILsTZrekFahYf5LGfY92UE+2?=
 =?us-ascii?Q?7cmD0DM3ELtE4jSaA5/Lbk7NZsXoKrqX/V1aLRp1LHp48l2rgy9UyDKve+fP?=
 =?us-ascii?Q?TOh+RP9o6DeWUwUmdKhDTS6XfFuuuFBHIZjpCIczq3dVmCMQE8QWfl7raY3i?=
 =?us-ascii?Q?+g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hLkUvCxMhg7QBVTnAuuTvJ0ZZqQjyij6OMkewQodfEfNaSffs4/XzXTajDQynNUiaSUFA3++hBziA2Ty+CLS0KY24LE+Ct2zJjkG6TIbBpMLjKg5v4UV98IaEtbinB1Bsyjx/IBuAB4yGC5cxkfZLHOrUOOrEPgqrCsuJFfpKkMn38r41OyvzJ1ZpiCU/RSfupvnVU2UssAKUoDGHSYnI4SBDj5DIkmXva4MjAAjnPm7G8EyZihqbi37Uyn71CTFW9/f2Jozl6c9kdPcR9pYAiDgGOcFPTr7OUk9O4HwcnQXE6mpWo1Aa2wUquuZBy4QcTV3hbfRze2m28r+aMnwx/IGcQDWJLPyCVN1UAXBeXnY+a9L0npoHt+2N83pVLM57SFsu3F1mX0uCcPKoyGwFg0PItRx40iMB8sQwPJ0q4d2gyOlUndbduApU4s1l9K8z2Zsn50qrgxpQmLDn4E1yW/i4F3OO4TMou1Q8PCZokEQ8jRokQmJaMnuKz2zf6OJKGJWGsoat+GVoecD/etactBH8ALZYcAYKFBEYlK4iiGuZoebUqm1CM76sP6lckAunN25LHj1uJr/TBXdLzIGAzs5R6lfR2l7eA0gU3p5TKO9GqFfeoPwypAcFpXChVKpDN0Vg+t441f5q71bDyRcupTqmQkoUt3c8T1A3tjJivahTFKlpVfrYvswScOT7oXm41bUq10wh1YzD/UVCehLwl+SVxQan9b0RZGTwonyln0Ubri0OfgvkCB04GM+QJ0tsmrgkXTM43WTsDCe/BZaVDn3+Mp030mIIVui0hEM7jKy2F385liZmFOuaDt/ODSJjYLhavoti/WOBpJpe7P/8Xkt0NuiDIp96wbpgkhbe2gOd5sa9sxpDwQVXewab76h
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4288093-48c9-4ca4-1484-08dbfa6688e8
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2975.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 16:30:49.4652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bYsXol7VO2MjBqUqFuFveQxTdIQnD7QOCLuLimSvRFpmS4M/AUJRM0fYJagtY/UX40sC597f+jzDFzb6X1s7MRyn5RwOximjh3r4maDA6kQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR10MB5981
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-11_07,2023-12-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0
 suspectscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312110135
X-Proofpoint-GUID: tKQm_xSJj1ZQMTlD4cO7OKc-J1JbNssV
X-Proofpoint-ORIG-GUID: tKQm_xSJj1ZQMTlD4cO7OKc-J1JbNssV
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 11 Dec 2023 08:31:30 -0800 (PST)

On Sat, Dec 09, 2023 at 07:59:17AM +0900, Masami Hiramatsu wrote:
> On Fri,  8 Dec 2023 00:07:48 -0500
> Kris Van Hees <kris.van.hees@oracle.com> wrote:
> 
> > The CONFIG_BUILTIN_RANGES option controls whether offset range data is
> > generated for kernel modules that are built into the kernel image.
> > 
> > Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
> > Reviewed-by: Nick Alcock <nick.alcock@oracle.com>
> > Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
> > ---
> >  kernel/module/Kconfig | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/kernel/module/Kconfig b/kernel/module/Kconfig
> > index 33a2e991f608..0798439b11ac 100644
> > --- a/kernel/module/Kconfig
> > +++ b/kernel/module/Kconfig
> > @@ -389,4 +389,21 @@ config MODULES_TREE_LOOKUP
> >  	def_bool y
> >  	depends on PERF_EVENTS || TRACING || CFI_CLANG
> >  
> > +config BUILTIN_RANGES
> 
> BUILTIN_MODULE_RANGES ?

Ah yes, thank you.  Will fix in v2.

> BTW, even if CONFIG_MODULES=n, we can embed the kernel module code.
> So should this visible if the CONFIG_MODULES=n ?

That is a very good point.  And in that case, the ranges information should
still be produced when this option is set.  I will move the option to a more
appropriate location, not depending on CONFIG_MODULES.

> Thank you,

Thank you for your feedback!

> > +	bool "Generate address range information for builtin modules"
> > +	depends on VMLINUX_MAP
> > +	help
> > +	  When modules are built into the kernel, there will be no module name
> > +	  associated with its symbols in /proc/kallsyms.  Tracers may want to
> > +	  identify symbols by module name and symbol name regardless of whether
> > +	  the module is configured as loadable or not.
> > +
> > +	  This option generates modules.builtin.ranges in the build tree with
> > +	  offset ranges (per ELF section) for the module(s) they belong to.
> > +	  It also records an anchor symbol to determine the load address of the
> > +	  section.
> > +
> > +	  It is fully compatible with CONFIG_RANDOMIZE_BASE and similar late-
> > +	  address-modification options.
> > +
> >  endif # MODULES
> > -- 
> > 2.42.0
> > 
> 
> 
> -- 
> Masami Hiramatsu (Google) <mhiramat@kernel.org>