Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4099586rdb; Mon, 11 Dec 2023 08:49:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDI7Hb7PMn1PRAJkwYdG0gO1Jy5GxdKe4tn69/jAuO1em/VynD22M0wAbv9AjUwrCO19Gs X-Received: by 2002:a05:6a20:8f22:b0:191:60f5:fce4 with SMTP id b34-20020a056a208f2200b0019160f5fce4mr125100pzk.12.1702313378887; Mon, 11 Dec 2023 08:49:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702313378; cv=none; d=google.com; s=arc-20160816; b=c+r/3fNp5HVQhhMFSTcSq0lISmLZyPqUlSl58ViV2JVQQ4UKPLm7qiw+jLv/kslX8V TSzHwxosTS6ak7Zmgd8Jq3oy1Erl1gw+ng6We1X2s6OaaBbySW1luWVtokIyfRoxnQUQ BoeE05Y79wk4FqG4n2EyirInHYJCMiXMnz/i8dP5U6w63RUlkmZcH2EWY1QmTklBZurE yob3C9/m9o7MbdB5pTlL5WFGNx8EDdLlo3P7TWRWcO4gLG6hMxKWh6P/nySpVoniPLja JBY/z2Y8D9M6oAAXnn8caEr783C6IcpGD3bNShFi11/O3MSOLb46WdXp9C8UCjNW05xz l2AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KGk0p455n9Qyqg3jYMqF3nY83oslNnD+prahsS3y2tg=; fh=06bWGjK3scAu+CJyzbCfFy6xX9Eu+7T3NaAqjDgEr10=; b=Ut9mj2YSWPiSLVwK25dnpiHFxCu/nd3eBnIpUoYqe38T3eEkBtetoe+nj7cJud/nNO QuuVgLjWziQWBAHQG6AgecPn3QwAt9thE4IeeR0ct0z7M2Hvh3Lu7Qm2x4X1w7Ve8KbY rK0ekC9kbu2l/BkICgpfUBYbTa6tg9ptnXFV1jXeA6Y1dR3fMR2QuSYZ1WKYUT6ybP9C azVj23AE3vmPnJRw+ARgqU3AnkWvDwWss2938JXJ4AWcMZfSkymu9PlsSqf7ZkRZqAOn sKZPJcOEYb3NbFYbZMWVh5kkkTLYxzxSUSbrz/itSPLyr+30mp8lAThmCyQNgCdB7oOg Mkng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=rJhP3hWg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id kq8-20020a056a004b0800b006cdf93d1949si6264846pfb.84.2023.12.11.08.49.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 08:49:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=rJhP3hWg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id BC445803BF31; Mon, 11 Dec 2023 08:49:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344613AbjLKQtP (ORCPT + 99 others); Mon, 11 Dec 2023 11:49:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbjLKQtP (ORCPT ); Mon, 11 Dec 2023 11:49:15 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91A568E; Mon, 11 Dec 2023 08:49:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KGk0p455n9Qyqg3jYMqF3nY83oslNnD+prahsS3y2tg=; b=rJhP3hWgktnDzGJNYm2tJw4xI7 TDqg7sdHNEg15rTEfZGNJ8HQ0/9cuVFcZD0RzxDoqN9E3H2U4t2h0p0f1s6cuMj0fIbvlWFrtREe0 ScIHQItSJyoiH/7RD5UvqgRXQlE/MgoIQOaectiMLWiOerK2qa82ed1qeyDVR9n0vVZCTrL++gnZz m5ay27K3W+82SGtrMP2rKybQGP6h0rhma6nk3TsKnrv+H7nMYlCUfsdrcqO7bD2gua1ZPaQs/eeDK wqwZhkEnqXbYKWKF6nSJv+T2mKJTiFwscPwOeE1mh5EqSHSZPmOqHv13b5lJk2CaiSUwVq1Vs498I lGQaaG8Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rCjT4-005xZv-26; Mon, 11 Dec 2023 16:49:18 +0000 Date: Mon, 11 Dec 2023 08:49:18 -0800 From: Christoph Hellwig To: linan666@huaweicloud.com Cc: axboe@kernel.dk, akpm@linux-foundation.org, ming.lei@canonical.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH] block: Set memalloc_noio to false on device_add_disk() error path Message-ID: References: <20231211075356.1839282-1-linan666@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231211075356.1839282-1-linan666@huaweicloud.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 11 Dec 2023 08:49:36 -0800 (PST) On Mon, Dec 11, 2023 at 03:53:56PM +0800, linan666@huaweicloud.com wrote: > From: Li Nan > > On the error path of device_add_disk(), device's memalloc_noio flag was > set but not cleared. As the comment of pm_runtime_set_memalloc_noio(), > "The function should be called between device_add() and device_del()". > Clear this flag before device_del() now. Looks good: Reviewed-by: Christoph Hellwig