Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4100818rdb; Mon, 11 Dec 2023 08:51:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNPdBet2zYKMGV/JiRub1XcjrMviF9MpkMv0TrEX5AaFAl5v6R+XiecREbJNdYK8QV2LfB X-Received: by 2002:a17:902:b195:b0:1d0:75d8:6ce2 with SMTP id s21-20020a170902b19500b001d075d86ce2mr1630223plr.82.1702313512461; Mon, 11 Dec 2023 08:51:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702313512; cv=none; d=google.com; s=arc-20160816; b=TU+XX/3k5YiDO60bdlrA6c6bvvVgXlVWb2crDZr3W7ztoibNnue7wneKAa2srTmHpV a1yOasJAu8QeQ6TBlKMHMP0uxelmjexFRGjWm2VeRAW0lks0KTy1H5fnzvbrSOE4+XtN ZGhGJe6aQgJ48WttmJoVFALi4NDdpWPCF06I2FLRg6PUsqmkBjCIxCUCpZLCbP0vJ3jb +RW+eFc+fW3hk4ESLrwwtbFvY0T37R4+KLWmtspgUfNu+LC9JzgtdyYawneazdmEiGwf /4UR/DSsXCeBzAfZpGwcuIn2wqjrs+JNquQpUwgYljDECJuAJD/TtfLFNsLvdQxKOaSl ORfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=yYMlVgwJcQHefAY+jtZPxMISliU4/gkGQGQKNTs4cuY=; fh=Aem/eLo/WCLMHop33oCRY4rf3/FObq7WWOaf9lYp+7A=; b=085fjG8tvFzI41z3Yh1oM7NGrKUPmv5cF0XuHwf61+YbVBf4anpFbsT7tUQYEAMYMy IYFB2fiOPE3FzSi1ljZkweT81CsQI/OeNUVWOMiXgroTRTIlHXWpMASZskigmY7STQ8q oXWAfgi+nP0ay22Z6atUJwAlipT74O3Kq1YDbOuEnUp0NHUxbwyaobiGueqXQIRd7LgZ fvFtVzsHguUqF+zi9d/IeO0CMiLz25n+znKr4zjMbDzZZV9P+3HXRt0UU6C3GOx3zXED Y2fk0VFN+UccdoO0npnGiZxFvzu2eBocN9yqRoFt1ouCHovVViWIBvn2nAqdvA0lZPIs 7syQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XvrINhKb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id c15-20020a170903234f00b001d2eea4a7dfsi5842178plh.39.2023.12.11.08.51.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 08:51:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XvrINhKb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id A27F4808EDEE; Mon, 11 Dec 2023 08:51:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344613AbjLKQvg (ORCPT + 99 others); Mon, 11 Dec 2023 11:51:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbjLKQve (ORCPT ); Mon, 11 Dec 2023 11:51:34 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C4DC8E for ; Mon, 11 Dec 2023 08:51:41 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D840C433C8; Mon, 11 Dec 2023 16:51:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702313501; bh=jXrfnDnXSAdCkJtLjpJCKDrNg7DOIOOclITycj8SrBs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XvrINhKbpjF5SAY9B9Ur5XIGWUrWK005J4+6zhivTUVERjJN0CYBnXNG6sktJZBEa +TKtwkIzZVvPI/ygufXQWweLn+Mlqk6IeALZRk1vekCm+1e8XBBdoXTor6Yv7ivWhQ eL54cJKPGd8ozXq1KoU/98JRmzw28WQfqH+5QfPPpHimLkTDrn2qc37M5hhAd/CYgR LT1RJwRU6R4F1wu0CIRg9sztDfGXp0nQkO6lpE5eldTKmGpQmfO32z1+P/M7GeB6pF aL8ZWXSw25SVWwVnRbrBW4SgnRh5pKeQrIlqCEeUczOF1wijqzJZHLuNJgDRQirWa0 gJHZU4dYAQ6pA== Date: Mon, 11 Dec 2023 08:51:39 -0800 From: Jakub Kicinski To: Patrick Williams Cc: Ivan Mikhaylov , davem@davemloft.net, edumazet@google.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, peter@pjd.dev, sam@mendozajonas.com Subject: Re: [PATCH net-next v2 3/3] net/ncsi: Add NC-SI 1.2 Get MC MAC Address command Message-ID: <20231211085139.011f650a@kernel.org> In-Reply-To: References: <20231114160737.3209218-4-patrick@stwcx.xyz> <20231210215356.4154-1-fr0st61te@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 11 Dec 2023 08:51:49 -0800 (PST) On Sun, 10 Dec 2023 20:50:56 -0600 Patrick Williams wrote: > Either you or I can send a "Fixes: " on this commit to improve the > handling as you're proposing. While the change is likely trivial, I > have not had any chance to test it yet, so I've not sent it up myself. > If you want to refactor the code to reduce duplication, I think that should > be an entirely separate proposal. Yes, incremental change is better.