Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231211110331.359534-1-songshuaishuai@tinylab.org>
In-Reply-To: <20231211110331.359534-1-songshuaishuai@tinylab.org>
From:   Sami Tolvanen <samitolvanen@google.com>
Date:   Mon, 11 Dec 2023 09:34:13 -0800
Message-ID: <CABCJKudbwKLj-+c__Jd6Pp7PVHHBiNPYq+rhadwRO1ykoF-Erg@mail.gmail.com>
Subject: Re: [PATCH --fixes] riscv: Remove SHADOW_OVERFLOW_STACK_SIZE macro
To:     Song Shuai <songshuaishuai@tinylab.org>
Cc:     paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, guoren@kernel.org,
        conor.dooley@microchip.com, bjorn@rivosinc.com, debug@rivosinc.com,
        greentime.hu@sifive.com, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Mon, Dec 11, 2023 at 3:04=E2=80=AFAM Song Shuai <songshuaishuai@tinylab.=
org> wrote:
>
> The commit be97d0db5f44 ("riscv: VMAP_STACK overflow
> detection thread-safe") got rid of `shadow_stack`,
> so SHADOW_OVERFLOW_STACK_SIZE should be removed too.
>
> Fixes: be97d0db5f44 ("riscv: VMAP_STACK overflow detection thread-safe")
> Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
> ---
>  arch/riscv/include/asm/thread_info.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/include/asm/thread_info.h b/arch/riscv/include/as=
m/thread_info.h
> index 574779900bfb..4856697c5f25 100644
> --- a/arch/riscv/include/asm/thread_info.h
> +++ b/arch/riscv/include/asm/thread_info.h
> @@ -28,7 +28,6 @@
>
>  #define THREAD_SHIFT            (PAGE_SHIFT + THREAD_SIZE_ORDER)
>  #define OVERFLOW_STACK_SIZE     SZ_4K
> -#define SHADOW_OVERFLOW_STACK_SIZE (1024)
>
>  #define IRQ_STACK_SIZE         THREAD_SIZE

Ah, good catch. Thanks for the patch!

Reviewed-by: Sami Tolvanen <samitolvanen@google.com>

Sami