Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   Pavel.Kozlov@synopsys.com
To:     Vineet Gupta <vgupta@kernel.org>,
        linux-snps-arc@lists.infradead.org
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] ARC updates
Date:   Mon, 11 Dec 2023 21:38:20 +0400
Message-Id: <20231211173820.30330-1-kozlov@synopsys.com>
In-Reply-To: <20231209003307.480051-1-vgupta@kernel.org>
References: <20231209003307.480051-1-vgupta@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Vineet,

> A pile of accrued changes, compile tested only.
> Please test.

> Thx,
> -Vineet

I'm testing you patches. At first glance everything is fine, no obvious
regressions.

But I've found an ARC build issue with the latest upstream source
(tag: v6.7-rc5). It is not linked with your updates.
The build issue occurs when the CONFIG_TRANSPARENT_HUGEPAGE option
is enabled:

| ../fs/proc/task_mmu.c: In function ‘pagemap_scan_thp_entry’:
| ../fs/proc/task_mmu.c:2115:28: error: ‘HPAGE_SIZE’ undeclared (first use in this function); did you mean ‘PAGE_SIZE’?
|  2115 |         if (end != start + HPAGE_SIZE) {
|       |                            ^~~~~~~~~~
|       |                            PAGE_SIZE
| ../fs/proc/task_mmu.c:2115:28: note: each undeclared identifier is reported only once for each function it appears in
| make[4]: *** [../scripts/Makefile.build:243: fs/proc/task_mmu.o] Error 1
| make[3]: *** [../scripts/Makefile.build:480: fs/proc] Error 2

May be you could address this issue in your updates too?

Thanks
Pavel