Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20230601075333.14021-1-ihuguet@redhat.com> <CAMZ6RqLoRVHD_M8Jh2ELurhL8E=HWt2DZZFGQvmfFyxKjtNKhg@mail.gmail.com>
 <874jiikr6e.fsf@meer.lwn.net> <CAMZ6RqLJmTjM0dYvixMEAo+uW+zfhdL1n4rnajsHCZcq971oRA@mail.gmail.com>
 <CACT4oudYAK07+PJzJMhTazKe3LP-F4tpQf8CF0vs1pJLEE_4aA@mail.gmail.com>
In-Reply-To: <CACT4oudYAK07+PJzJMhTazKe3LP-F4tpQf8CF0vs1pJLEE_4aA@mail.gmail.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Tue, 12 Dec 2023 02:50:59 +0900
Message-ID: <CAK7LNATqNNVX8ECNoO82kY503ArfRPa9GdbYd9tOok_6tGOsew@mail.gmail.com>
Subject: Re: [PATCH v4] Add .editorconfig file for basic formatting
To:     =?UTF-8?B?w43DsWlnbyBIdWd1ZXQ=?= <ihuguet@redhat.com>
Cc:     Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        Jonathan Corbet <corbet@lwn.net>, ojeda@kernel.org,
        danny@kdrag0n.dev, jgg@nvidia.com, mic@digikod.net,
        linux-kernel@vger.kernel.org, joe@perches.com,
        linux@rasmusvillemoes.dk, willy@infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 23, 2023 at 3:26=E2=80=AFPM =C3=8D=C3=B1igo Huguet <ihuguet@red=
hat.com> wrote:
>
> On Mon, Oct 23, 2023 at 8:19=E2=80=AFAM Vincent MAILHOL
> <mailhol.vincent@wanadoo.fr> wrote:
> >
> > On Mon. 23 Oct. 2023 at 11:28, Jonathan Corbet <corbet@lwn.net> wrote:
> > > Vincent MAILHOL <mailhol.vincent@wanadoo.fr> writes:
> > >
> > > > On Thu. 1 June 2023 at 16:53, =C3=8D=C3=B1igo Huguet <ihuguet@redha=
t.com> wrote:
> > > >> EditorConfig is a specification to define the most basic code form=
atting
> > > >> stuff, and it's supported by many editors and IDEs, either directl=
y or
> > > >> via plugins, including VSCode/VSCodium, Vim, emacs and more.
> > > >>
> > > >> It allows to define formatting style related to indentation, chars=
et,
> > > >> end of lines and trailing whitespaces. It also allows to apply dif=
ferent
> > > >> formats for different files based on wildcards, so for example it =
is
> > > >> possible to apply different configs to *.{c,h}, *.py and *.rs.
> > > >>
> > > >> In linux project, defining a .editorconfig might help to those peo=
ple
> > > >> that work on different projects with different indentation styles,=
 so
> > > >> they cannot define a global style. Now they will directly see the
> > > >> correct indentation on every fresh clone of the project.
> > > >>
> > > >> See https://editorconfig.org
> > > >>
> > > >> Co-developed-by: Danny Lin <danny@kdrag0n.dev>
> > > >> Signed-off-by: Danny Lin <danny@kdrag0n.dev>
> > > >> Signed-off-by: =C3=8D=C3=B1igo Huguet <ihuguet@redhat.com>
> > > >> ---
> > > >
> > > > Is there any news for this patch? I would really love this to becom=
e mainstream.
> > >
> > > I have concerns about this patch that I have expressed in the past.
> > >
> > > I'm not going to apply it... since it's a global change that affects =
all
> > > kernel developers, I don't think I *should* apply it.  I would recomm=
end
> > > sending it directly to Linus; if you can get an ack from him, I'll ap=
ply
> > > it then.
> >
> > Hi Jonathan,
> >
> > Thanks for the comment, message taken.
> >
> > Hi =C3=8D=C3=B1igo,
> >
> > The last version of the patch being from you, would you like to bring
> > the topic to Linus yourself or shall I do it instead?
>
> I'm not doing kernel development lately, so please go ahead pushing
> this if you want.
>
> Anyway, note that, as discussed in the thread, it is incorrect to say
> that it will affect all kernel developers: most IDEs and editors only
> have "opt-in" support for editorconfig, and the few that are not
> "opt-in", are either "opt-out" or has a workaround (Kate).


Applied to linux-kbuild. Thanks.

We invested a significant amount of time in research and discussion,
and I do not want to lose our efforts.

If it turns out to be problematic, it is easy to revert it.
(although I do not think so, given the wide adoption in many projects.)


--
Best Regards
Masahiro Yamada