Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4141182rdb; Mon, 11 Dec 2023 09:57:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGbYc7Jp/OPkXwbxOW6N1REJsYLPjt27pTbdLUcJNjkG26CbfqcB3h/yb4d3lL5m1WxH5q/ X-Received: by 2002:a17:902:f807:b0:1d0:c0f4:7c1c with SMTP id ix7-20020a170902f80700b001d0c0f47c1cmr4995275plb.78.1702317455782; Mon, 11 Dec 2023 09:57:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702317455; cv=none; d=google.com; s=arc-20160816; b=Rfa6Qvrw5rpQjCWDhprTh+V8hjoeaZjgdlLX7TOPjlFXwj/5Q+xQL4tCeTS2tDk1+W VyZD314KpjQ7fjRodBFmLjgfMIooV36/1UnIe3ncuL8PkVFbV7vLkkwQr/mp6+OaGDRP Avtg0HGQ7Ew1zILY/++t7Psoi16HRqFZhKxWFW7ULjV4am2JPw6HSu9aHpUjjjtCA60M kTZc6naAGxYkZMwxro+CDD9Y20nIydw+gsB9IDRKojnhrbxfbUsyXN3qqikKN9kKDMSN 1iwzA28J3wZdyUIKS9gVAKxF32dQzm2DsbbiyUvy3caOhzL8OPHJWrQdbTsDYnCw/vte VsPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PZ+R8B3wHCuWt284dmb9Of0onfh+d3cgp76iNW/6Qqk=; fh=NBmREaXSAZFpoQahUCeDwuDc4C2pm3/orU1mjt7tsXY=; b=KaI8xBAwZ2gntIX7ZQeRAHVYl5KNJT4KxyP2lfMpElIbJNHzm3N/I3SNfVBGb2Gti6 odY3ErGLwc5XWlCJi59bP79RhNuWm3qLuOUGiCXr0eIHcsHxtxft3RIlbb1CBpzUDgWC aj2D3Z81jnk/o0alShXC3sIc+11SBSxedLjFls40X2ehNlk6p0fMf/Bg+P2s9153h8wb UVPcISCZ7S8v7RBBzctPB4iiR5o+XCuwu+qW10B5WkzJ3AKxcUEGqj8TkgnG6ThdsYEk MrJZYENKFqlEepLmjPlvpcR819LNtHoubAFm4Tx200B3GPh0n2HMyEtnjYlMn6pGlkIN PEFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@citrix.com header.s=google header.b=NBFkepOO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=citrix.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id z13-20020a170903018d00b001cfd4eb4deasi6525009plg.357.2023.12.11.09.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 09:57:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@citrix.com header.s=google header.b=NBFkepOO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=citrix.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 1C3498080D44; Mon, 11 Dec 2023 09:57:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344964AbjLKR5S (ORCPT + 99 others); Mon, 11 Dec 2023 12:57:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344578AbjLKR5Q (ORCPT ); Mon, 11 Dec 2023 12:57:16 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB10793 for ; Mon, 11 Dec 2023 09:57:21 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-333630e9e43so4915961f8f.2 for ; Mon, 11 Dec 2023 09:57:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1702317440; x=1702922240; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PZ+R8B3wHCuWt284dmb9Of0onfh+d3cgp76iNW/6Qqk=; b=NBFkepOOw19ltXFI+lrhjkoLrBMmbcPeWm3kf1KWQJk2ve9DcQrPd+5U1NnpAADeDy se1Q7rtK988ynzKIJMhhW16vsydT9Zo4lBcH5xNgImSv2blEsjsyX75IGF446+JJgIQa OSbjGH7FsBnSlMlzJpGiMOsnLzJ06BriR8pGw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702317440; x=1702922240; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PZ+R8B3wHCuWt284dmb9Of0onfh+d3cgp76iNW/6Qqk=; b=AoVOjMI9bPik/daoQHNx6RjHxe2xOIbVZ4R3g0xNTXi8CfwtvILs2+JZMitoZx8+55 iJQKCw6ENGYj049K/DRx0rCxc5oASnEfrS7K9KdPA4KRIset6tcen3uXNDrRGXI/qqdj NPpB4nmdN+cGmIcPJuGmNMXeNBAmVV2aKnIBIVEBYlhXap1m68VzGe8/+cz/ovOscGj1 8EBULgXFUKLuHZFrnFqB8/rfBH2Tj2jpVw/1jufpnC1up/0inH6xjSmunGrcyaXHsW4C SFw5/OAM658vEn1CpwB7rifMUfvGIoDreEyNtg6375ogcIvxljMsD1IswD09gJ/RnNCh ZgLg== X-Gm-Message-State: AOJu0YwrqyyU0ovyBYocWUpBVeW7eCVJVuTe+M8hpBH1NLNCeiBipQCG pQtw2OZyYf+VlBubjhkKapFytg== X-Received: by 2002:a05:600c:1ca3:b0:40c:243d:daa6 with SMTP id k35-20020a05600c1ca300b0040c243ddaa6mr1570231wms.8.1702317440373; Mon, 11 Dec 2023 09:57:20 -0800 (PST) Received: from localhost ([213.195.113.99]) by smtp.gmail.com with ESMTPSA id m3-20020a5d56c3000000b003334520e49bsm9101723wrw.53.2023.12.11.09.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 09:57:19 -0800 (PST) Date: Mon, 11 Dec 2023 18:57:19 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jiqian Chen Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Thomas Gleixner , Boris Ostrovsky , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, Alex Deucher , Christian Koenig , Stewart Hildebrand , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Huang Rui Subject: Re: [RFC KERNEL PATCH v3 3/3] PCI/sysfs: Add gsi sysfs for pci_dev Message-ID: References: <20231210161519.1550860-1-Jiqian.Chen@amd.com> <20231210161519.1550860-4-Jiqian.Chen@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231210161519.1550860-4-Jiqian.Chen@amd.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 11 Dec 2023 09:57:33 -0800 (PST) On Mon, Dec 11, 2023 at 12:15:19AM +0800, Jiqian Chen wrote: > There is a need for some scenarios to use gsi sysfs. > For example, when xen passthrough a device to dumU, it will > use gsi to map pirq, but currently userspace can't get gsi > number. > So, add gsi sysfs for that and for other potential scenarios. > > Co-developed-by: Huang Rui > Signed-off-by: Jiqian Chen > --- > drivers/acpi/pci_irq.c | 1 + > drivers/pci/pci-sysfs.c | 11 +++++++++++ > include/linux/pci.h | 2 ++ > 3 files changed, 14 insertions(+) > > diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c > index 630fe0a34bc6..739a58755df2 100644 > --- a/drivers/acpi/pci_irq.c > +++ b/drivers/acpi/pci_irq.c > @@ -449,6 +449,7 @@ int acpi_pci_irq_enable(struct pci_dev *dev) > kfree(entry); > return 0; > } > + dev->gsi = gsi; It would be better if the gsi if fetched without requiring calling acpi_pci_irq_enable(), as the gsi doesn't require the interrupt to be enabled. The gsi is known at boot time and won't change for the lifetime of the device. > > rc = acpi_register_gsi(&dev->dev, gsi, triggering, polarity); > if (rc < 0) { > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c > index 2321fdfefd7d..c51df88d079e 100644 > --- a/drivers/pci/pci-sysfs.c > +++ b/drivers/pci/pci-sysfs.c > @@ -71,6 +71,16 @@ static ssize_t irq_show(struct device *dev, > } > static DEVICE_ATTR_RO(irq); > > +static ssize_t gsi_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct pci_dev *pdev = to_pci_dev(dev); const Thanks, Roger.