Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Mon, 11 Dec 2023 14:10:28 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     Yi Liu <yi.l.liu@intel.com>, joro@8bytes.org, kevin.tian@intel.com,
        robin.murphy@arm.com, baolu.lu@linux.intel.com, cohuck@redhat.com,
        eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
        mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com,
        yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com,
        shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
        suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        zhenzhong.duan@intel.com, joao.m.martins@oracle.com,
        xin.zeng@intel.com, yan.y.zhao@intel.com
Subject: Re: [PATCH 3/3] vfio: Report PASID capability via
 VFIO_DEVICE_FEATURE ioctl
Message-ID: <20231211181028.GL2944114@nvidia.com>
References: <20231127063909.129153-1-yi.l.liu@intel.com>
 <20231127063909.129153-4-yi.l.liu@intel.com>
 <20231211110345.1b4526c6.alex.williamson@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231211110345.1b4526c6.alex.williamson@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Rbp3zue29QjY/LJbjpWdTegJ6D5DjXuxiivSSAua91WuLTUt0Mh9dPUe219M?=
 =?us-ascii?Q?y+QMVU2r7QCzfQB78nm51pqyvk6QVH7T9W4T2fHBroopfsQGjxmcRO+Izw17?=
 =?us-ascii?Q?lQ1MT4Id+R7hygfsW9fdLxEX6h4mkG74bky+fH9Lx22eaClEn+ZnPPz02A73?=
 =?us-ascii?Q?qvLqbCp7/G9OjkiKMGFS/nW83nhh4/aXswMQGvbmWIsBHUM8996ztiWC3v7f?=
 =?us-ascii?Q?CcQs+6FG5LHUMU9ALI7PKOY2qeImoGRwHrbvgla14S6Paj5O967KPcK56XpT?=
 =?us-ascii?Q?XES50bjv1CXIHE01d30I8KGa5yddmELAR5C3dkFw3M4NUzRzy254nSHKxvS3?=
 =?us-ascii?Q?HNb2nVrshFU4Hpg8DH2FQNuv9fw7lj6XuLwXM4YAJuBITfeHUPTfDhq6mF6d?=
 =?us-ascii?Q?JKDIiLs59v6lrfOqOXehCYUllM4+A5WAe7x79Vfm8buZcYp7nmudDrRlRFm+?=
 =?us-ascii?Q?buCEOzo89KlNEkxauaPtmsf5O9BOozxmY6qJRBBX2zGpYkLjIVgnBuTZz8D2?=
 =?us-ascii?Q?5cPzBymW1fghzXqQSCJgt3q1o1Qcc0cc2Tm8mkTVBK59Q3QHLkSpJTX0lTDC?=
 =?us-ascii?Q?OqSCCWI9rh6KNfnA4aVYfhRjkXji5yIO7pYAj/tjrPkoZ9ZD5WHnhZoOTZ5V?=
 =?us-ascii?Q?/5cdmhFjcT8iS6zl73fHzEOpvxqNkluvCaUo+ojhtO3vs9CRO+TASr1MOt1x?=
 =?us-ascii?Q?xyqcTMI3Dvb5BlXKWZrPJns4QCtxMjLpmCE4coHYlnLX9yqkuXv2dc+HERx2?=
 =?us-ascii?Q?bEcrCn3SWv0I9H/vNetoZ3XREdd+8G8Vd7kGLZdZe2qJyYWknPWho9UGbkX2?=
 =?us-ascii?Q?/FEIMgeAN5XHOZKrviBtIYaHsokB3Lr21C3Sedon+S0hxf9oZwlkmmiGkLd9?=
 =?us-ascii?Q?05dIxd+XkWZQjhueNazFypCS751p+Y1MN/UplfWi8W+iQ5RkWJRaLDVZt8GN?=
 =?us-ascii?Q?+aa5vs6Rr2JDXyLh8IprlOveWpN1N2QAVmKSTDi9ZGs7hHTBtQJoZNERy83n?=
 =?us-ascii?Q?p3kHZW24aqjoNJj0bwedMrSBO07tH9kzBMUDgzDDtHQFeKkJoT7N7Rdh4ZeX?=
 =?us-ascii?Q?5HCrvlgSwOySjZSn4WKChH2ISYD0O9/QBcJbfw/4gEKtQLhrt7MLqLW3D1ZY?=
 =?us-ascii?Q?bqzpGBNBn0IsLQie9hQsU0zCN01h71dtzbj/GaCc1ll7TjspO7MgliqdOvGq?=
 =?us-ascii?Q?wiQ5BoBHCj0+7Wj0F2vyf8Q86NXGMBpXS8DH+9xt3r95tYHWOPoiOXissjFo?=
 =?us-ascii?Q?E2R0ft473qHuMQwdFLtmtxwCD6DswkOlCtxSGG7UN484S3r2fHM4ij27bZct?=
 =?us-ascii?Q?NWEX0ahzjwyzL7bz4oY1d5zC8/JaAT4I5yZdOlacDI6WuzcFvYIMQfVV6x4Y?=
 =?us-ascii?Q?e7nz3GwOuqe9jBC45s1YYglvgj+JVkhTTRuJk6XSbjgs26P0umY7ok1SfucO?=
 =?us-ascii?Q?/8GMCaTQ70A8ceKhyi128JwCTxehgGO33Atuci60I0pMIec9io1FY3cjq17Q?=
 =?us-ascii?Q?eQngr49MzIkERS0fsiLo2NSo8kA4huMS64kIr6+VQ2yEl4v2ylfu9ulj16dZ?=
 =?us-ascii?Q?8YEaer2DKV1pIBz7F3eGVIIJJia3Eihw5PXERTdS?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43c517f4-0549-4137-1c2f-08dbfa747561
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 18:10:29.6905
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RZ/WO9kKQgDczZOYLqMugx7e66b9J6HX1MKwblEJSGhwitxIOXP0c+ivvkzwtMhk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4548
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 11 Dec 2023 10:10:45 -0800 (PST)

On Mon, Dec 11, 2023 at 11:03:45AM -0700, Alex Williamson wrote:
> On Sun, 26 Nov 2023 22:39:09 -0800
> Yi Liu <yi.l.liu@intel.com> wrote:
> 
> > This reports the PASID capability data to userspace via VFIO_DEVICE_FEATURE,
> > hence userspace could probe PASID capability by it. This is a bit different
> > with other capabilities which are reported to userspace when the user reads
> > the device's PCI configuration space. There are two reasons for this.
> > 
> >  - First, Qemu by default exposes all available PCI capabilities in vfio-pci
> >    config space to the guest as read-only, so adding PASID capability in the
> >    vfio-pci config space will make it exposed to the guest automatically while
> >    an old Qemu doesn't really support it.
> 
> Shouldn't we also be working on hiding the PASID capability in QEMU
> ASAP?  This feature only allows QEMU to know PASID control is actually
> available, not the guest.  Maybe we're hoping this is really only used
> by VFs where there's no capability currently exposed to the guest?

Makes sense, yes

> >    the PF). Creating a virtual PASID capability in vfio-pci config space needs
> >    to find a hole to place it, but doing so may require device specific
> >    knowledge to avoid potential conflict with device specific registers like
> >    hiden bits in VF config space. It's simpler by moving this burden to the
> >    VMM instead of maintaining a quirk system in the kernel.
> 
> This feels a bit like an incomplete solution though and we might
> already posses device specific knowledge in the form of a variant
> driver.  Should this feature structure include a flag + field that
> could serve to generically indicate to the VMM a location for
> implementing the PASID capability?  The default core implementation
> might fill this only for PFs where clearly an emualted PASID capability
> can overlap the physical capability.  Thanks,

In many ways I would perfer to solve this for good by having a way to
learn a range of available config space - I liked the suggestion to
use a DVSEC to mark empty space.

Jason