Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4151399rdb; Mon, 11 Dec 2023 10:11:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGjItyWsH9RTs1H87+EYlHS2yBkjARsl/xAGWgzXEXTrxceIoJCuZjnGcmGD2OqZz+yLHdX X-Received: by 2002:a05:6a00:3090:b0:6ce:f632:3ca4 with SMTP id bh16-20020a056a00309000b006cef6323ca4mr1567760pfb.23.1702318286674; Mon, 11 Dec 2023 10:11:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702318286; cv=none; d=google.com; s=arc-20160816; b=AB5r8IWV2DYt2zBNw6oYCuUuD36RkkHj7WcbVx/m1THV+vH11oU2qPRCELlRLb55ha 5Q2nLym25Ps5UZIOoE1lyS97pwRjAAuvVdKMb8vAOeq3+TWGGHEZ8gfalpiYDnOFLZYY zlYHQiEkQ/Okj6O0mkH30lmCblD/8CwqCk5rT5RIEeNOuFWzHndNGDj0cLwsSwPTCMF+ JF/ncsfPHOJtFtrYZYci9KgIGduIh0rhhYCglkogReuKTi7oewhgdvo27JUCAl4B3F+E Z4WkE0HtSaAiO1/4zVULQomeNWmKoY537srz7eO2L53gjKsFktBO/d8DaM0fDpCyDkct LWRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MExxPNiOFfYNnHafeaqdEzyfkCNKsTZzNYvv5wFU3Gc=; fh=jqTWrQ5bCH5SYcBidMUA87AoUf4V55L1bAZhntpQF1g=; b=tp+x7aA1SDXjM7awDY4duDrjsdb7euJvHFYCP2PNMkqWkO0YKTwRyfEWpdv7jKpwMh 1IJKsxslL2M12ZdLTAbZmYppD6Vi2ZygdQkSngcDuivZrN6euxJJ1JlZQqk2qWontOXo i6g6t1AUXNJbKhBYM2AP2fT08cccXaGds0l9SfBjBhmQEBf00L8szN96CzDs8lObRKkr UuzzFbgrKN2jmqy45A141XHQHcm+bT0TVAogrPhyX8OL3Mu+ZCu7aMpuvu5CnZ/Y6HW6 rff9eCtIs19kLCfgLd3MeiRYDkQSox/2P0grhUtquJo960LHvUjKnPmUI54ynOj6NDP2 4JUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=vaJ7Qdr6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id kp12-20020a056a00464c00b006cbb6f87036si6487393pfb.97.2023.12.11.10.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 10:11:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=vaJ7Qdr6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 58FE6807BA39; Mon, 11 Dec 2023 10:11:22 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345376AbjLKSK4 (ORCPT + 99 others); Mon, 11 Dec 2023 13:10:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345369AbjLKSKy (ORCPT ); Mon, 11 Dec 2023 13:10:54 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D69A493; Mon, 11 Dec 2023 10:11:00 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 708DF922; Mon, 11 Dec 2023 19:10:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1702318215; bh=Hkw53CbAYCaVZwFD6iEyB0w0BwlSOvyQDw30dZMGkeA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vaJ7Qdr6VFdkee/w1bOqs3IU/FcFR5GgyqCC8hF7BbQjf1JGAhASI6K5GRg4pMXde vHOxKyUaDwvp2MroRVdD1sq0w3AIgIg7jMyFQUTVrIq938i5l3AcRbyzF0RXVwNyRk CdS3M1LUZuyMsPHA86Jp3+Mdxjng5l+W3F0Wi5P4= Date: Mon, 11 Dec 2023 20:11:06 +0200 From: Laurent Pinchart To: Mikhail Rudenko Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sakari Ailus , Jacopo Mondi , Tommaso Merciai , Christophe JAILLET , Dave Stevenson , Mauro Carvalho Chehab Subject: Re: [PATCH 05/19] media: i2c: ov4689: Refactor ov4689_set_ctrl Message-ID: <20231211181106.GD27535@pendragon.ideasonboard.com> References: <20231211175023.1680247-1-mike.rudenko@gmail.com> <20231211175023.1680247-6-mike.rudenko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231211175023.1680247-6-mike.rudenko@gmail.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 11 Dec 2023 10:11:22 -0800 (PST) Hi Mikhail, Thank you for the patch. On Mon, Dec 11, 2023 at 08:50:08PM +0300, Mikhail Rudenko wrote: > Introduces local variables for regmap and the control value within the > ov4689_set_ctrl function. This adjustment eliminates repetition within > the function. > > Signed-off-by: Mikhail Rudenko > --- > drivers/media/i2c/ov4689.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c > index 8c120d7f7830..42700ecfbe0e 100644 > --- a/drivers/media/i2c/ov4689.c > +++ b/drivers/media/i2c/ov4689.c > @@ -584,7 +584,9 @@ static int ov4689_set_ctrl(struct v4l2_ctrl *ctrl) > { > struct ov4689 *ov4689 = > container_of(ctrl->handler, struct ov4689, ctrl_handler); > + struct regmap *regmap = ov4689->regmap; > struct device *dev = ov4689->dev; > + s32 val = ctrl->val; For ctrl->val, I think the code is clearer without this change. When reading the function, seeing "val", I need to look up what it is, while seeing "ctrl->val" gives me more context and makes (in my opinion) the code more readable. > int sensor_gain; > s64 max_expo; > int ret; > @@ -593,7 +595,7 @@ static int ov4689_set_ctrl(struct v4l2_ctrl *ctrl) > switch (ctrl->id) { > case V4L2_CID_VBLANK: > /* Update max exposure while meeting expected vblanking */ > - max_expo = ov4689->cur_mode->height + ctrl->val - 4; > + max_expo = ov4689->cur_mode->height + val - 4; > __v4l2_ctrl_modify_range(ov4689->exposure, > ov4689->exposure->minimum, max_expo, > ov4689->exposure->step, > @@ -607,36 +609,34 @@ static int ov4689_set_ctrl(struct v4l2_ctrl *ctrl) > switch (ctrl->id) { > case V4L2_CID_EXPOSURE: > /* 4 least significant bits of exposure are fractional part */ > - ret = cci_write(ov4689->regmap, OV4689_REG_EXPOSURE, > - ctrl->val << 4, NULL); > + cci_write(regmap, OV4689_REG_EXPOSURE, val << 4, &ret); > break; > case V4L2_CID_ANALOGUE_GAIN: > - ret = ov4689_map_gain(ov4689, ctrl->val, &sensor_gain); > + ret = ov4689_map_gain(ov4689, val, &sensor_gain); > > - cci_write(ov4689->regmap, OV4689_REG_GAIN_H, > + cci_write(regmap, OV4689_REG_GAIN_H, > (sensor_gain >> OV4689_GAIN_H_SHIFT) & > OV4689_GAIN_H_MASK, &ret); > > - cci_write(ov4689->regmap, OV4689_REG_GAIN_L, > + cci_write(regmap, OV4689_REG_GAIN_L, > sensor_gain & OV4689_GAIN_L_MASK, > &ret); > break; > case V4L2_CID_VBLANK: > - ret = cci_write(ov4689->regmap, OV4689_REG_VTS, > - ctrl->val + ov4689->cur_mode->height, NULL); > + cci_write(regmap, OV4689_REG_VTS, > + val + ov4689->cur_mode->height, &ret); > break; > case V4L2_CID_TEST_PATTERN: > - ret = ov4689_enable_test_pattern(ov4689, ctrl->val); > + ret = ov4689_enable_test_pattern(ov4689, val); > break; > default: > dev_warn(dev, "%s Unhandled id:0x%x, val:0x%x\n", > - __func__, ctrl->id, ctrl->val); > + __func__, ctrl->id, val); > ret = -EINVAL; > break; > } > > pm_runtime_put(dev); > - > return ret; > } > > -- > 2.43.0 > -- Regards, Laurent Pinchart