Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4151911rdb; Mon, 11 Dec 2023 10:12:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDU7iHBL4rwsNE7/o7jYbYt2RYGEowDaQg+P6lr1j/xkD748HfBhjECrZ9ayMY1QlowuTY X-Received: by 2002:a17:90a:bc8c:b0:286:7f04:1539 with SMTP id x12-20020a17090abc8c00b002867f041539mr1905103pjr.90.1702318328068; Mon, 11 Dec 2023 10:12:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702318328; cv=none; d=google.com; s=arc-20160816; b=t/6RFX/edo/lP3zPVighiWkCA0h7Dgv/mxuWvHPFLaOhDIEcTYbZyLwq8SB6uTQrqa iU2VXdQGNMwX+g5ubKRNf9UeUj4cIZfx48hqGC2QRyLIXXDvBdqqLEaQlzlDRMPVbodU Qoy5BJj19MQyCT9JiSGSS7CYD2Zgskr2jmKn1A7vNBDX83RKjLl/gx3IlOLFc7o6QL3w imHIFblHDrBj2HZkK84Z/Ge6drwmVkkCP20X2SO1wtXhRIQPID/pjIiHIyWqc3PcH1hJ NwUB9mmhz1UaMtrwmtx2Qm3q+UEQdGacSKe0xxR0WJM+VdRM3wnVQpllMybqxqW0tSNj Xl2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=JOeyaAUT+4DxJ942FYbAxfzdcRJ+NVwEJ/IPQMJIqpQ=; fh=6YQjj8zTY2Q9+G9clD6t+VDZpDNUxnaaKAG7ZvkLfIU=; b=ZGg/v/TAlvT9C+3RReKNHjbZc1W05+JXZpc3K3xQERliam9M8z/pgtzz7dj5URERpH zkEnt6PGJ78AWhUjK6LZX14diawN0Sfxb7Ux4xT9oEDDJ+IZWCQM3iZaZrO6JagQU0gy x6hz3xFZjkoE4cr3v2NniHZZB2dsam4ds44u/4nkJdeSR4W5at5evN8fPUUitGYSkgJS MjbWwnjpvC31KUuWqvKLIBExUi1myqjswqo5s0CHSfGUM8Y9ohQnWh0hJ5kTA+bRxslN K1oGww8KNGY6JW0xVpc25425Mq9tnJ7qxaoqOMWKJIRD9Wa5o74Yq1erCO4vYU2TXhT6 Teeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S9tGGdET; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id pi9-20020a17090b1e4900b00286a07a20b0si6573962pjb.86.2023.12.11.10.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 10:12:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S9tGGdET; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D7CF780947E9; Mon, 11 Dec 2023 10:12:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345287AbjLKSLu (ORCPT + 99 others); Mon, 11 Dec 2023 13:11:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345257AbjLKSLt (ORCPT ); Mon, 11 Dec 2023 13:11:49 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C187993 for ; Mon, 11 Dec 2023 10:11:55 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23130C433C7; Mon, 11 Dec 2023 18:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702318315; bh=d/QXMCGNkdm/FGe7jzUVoJUZiNL9n1uu27MJIv/ZnTk=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=S9tGGdET6EYJ55LzwK2/6jfxwPY+v+UcpfAbKynnvMOUhoOe2P8ilqjibT0NLSTJj QLidBZPKeGrLTGQxJEI53/xFK3DZJbUjj1SiZ4htdSipxIzQEejCKmQ03bAEu/lYH/ kjuiwJcaZM2bpjRMWAiztjJsL0kKtCc+YKeDir83oI+THSvfhgt2rTwEcll+Gz4DIV uB8QbR3AUdPlEYvgSEfIrEgyfUS8HUoEfoSpZJit2hqXYcd5XR2/ghn2EWiIo3aDiI sPPOdqERtbM1i6/ghc5OnEJMroC0rf3AhU3bIeZlAh5z4FP7fKS3hrabAahAgQ5Kvs QpxY4WJPvK/0A== Date: Mon, 11 Dec 2023 12:11:53 -0600 From: Bjorn Helgaas To: Johan Hovold Cc: Johan Hovold , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , Rob Herring , Nirmal Patel , Jonathan Derrick , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/6] PCI: Fix deadlocks when enabling ASPM Message-ID: <20231211181153.GA959586@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 11 Dec 2023 10:12:06 -0800 (PST) On Mon, Dec 11, 2023 at 06:35:46PM +0100, Johan Hovold wrote: > Hi Bjorn, > > On Fri, Dec 08, 2023 at 11:53:12AM -0600, Bjorn Helgaas wrote: > > On Tue, Nov 28, 2023 at 09:15:06AM +0100, Johan Hovold wrote: > > > > Johan Hovold (6): > > > PCI/ASPM: Add locked helper for enabling link state > > > PCI: vmd: Fix deadlock when enabling ASPM > > > PCI: qcom: Fix deadlock when enabling ASPM > > > PCI: qcom: Clean up ASPM comment > > > PCI/ASPM: Clean up disable link state parameter > > > PCI/ASPM: Add lockdep assert to link state helper > > > Applied to for-linus for v6.7, thanks, Johan! > > I've noticed that you're pretty keen on amending commit messages. > > For this series, for example, I noticed that you added an American comma > after "e.g." even though this is not expected in British English that I > (try to) use. This risks introducing inconsistencies and frankly I see no > reason for this kind of editing. British English is not an error. :) > > You also added a plus sign after the stable kernel versions in the > comments after the CC-stable tags even though this is not the right > notation for this (see the stable kernel rules). Fixed, sorry.