Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4156664rdb; Mon, 11 Dec 2023 10:20:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHbLo0fYbCgVVxR+2ZrQ0iAyU67VshxzcpnaVTSbe8bqbYHNZ5ZiZo/vy2UPufwwWfzVvLB X-Received: by 2002:a05:6a20:54a4:b0:188:1df7:9afe with SMTP id i36-20020a056a2054a400b001881df79afemr2823771pzk.30.1702318804304; Mon, 11 Dec 2023 10:20:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702318804; cv=none; d=google.com; s=arc-20160816; b=mBwZDEzCZFQ/zIJQ/8k5d73Y8bWazpbHUE6c1wm+BXYvmavgYmz3HJx6hjiVQacFjE JOY9JzyfFdyaJGdGUXrCYWEDTFSV2via7b7ZvXTZ2ktTI10ENpE93B+N+5RzL1zkA/v8 P+gb1KrUvvLcbM4kEMYIzHGZ3EkiHPaVmDBE0DTLBE9UucKYZ0aXB0YhbYm6kPPdNJ2s 4UjKcstZizM0ZcMwJEVnAVrnEOmySsLn7ggxahJ0LgXTGGKGpNBpOT6C3Xad0OEnz5Xp 5kZpaUiLwf2TIdMVPFY6GI/9A+9UXAoVzQEpXW5c2Q1LrGr92gyqx9uM7l0D9VdtgWhf j4bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wj2cm/5NG/YTnAUMUzBh3KLbEa5qQ/Eo3h5Fng3Yo8M=; fh=jqTWrQ5bCH5SYcBidMUA87AoUf4V55L1bAZhntpQF1g=; b=qoWF77Q3Y9qoGB8uuawv/OhzFe/vsFzSDlM6ul5t2KvRNh4IhHdl8+UfLq1Cb29t/+ KXhm0XzCMWbo8uMU2MhTjGt+ljwDZ+sbS8QA75v9DvmpTXsD/rWTeZKnvxx5S0YOhG1X mJrzz1HfBAsDI9REMkN+wMFPy03zW9vXYDcJxve1iPTOmYGNuXOzh8jf3jMBvvQi5NRJ XYo9MQ/gIj1X08jE9VKjQwegiqvuJLNEAviea2+NFs/T2kgZmlSCeaheLjiEoNsDfnLa fDTy0J8+sVMfyWPjrZ6+4H4tAv8rXIWOorL9on0FNsCQqKxCv+dtshxDjTbBdHLIPvgL /SYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=gj4KLWx9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id cp10-20020a17090afb8a00b00285be1801d8si6477769pjb.101.2023.12.11.10.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 10:20:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=gj4KLWx9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 2DF31809AFDB; Mon, 11 Dec 2023 10:20:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344796AbjLKSTr (ORCPT + 99 others); Mon, 11 Dec 2023 13:19:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230101AbjLKSTq (ORCPT ); Mon, 11 Dec 2023 13:19:46 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEC049D; Mon, 11 Dec 2023 10:19:52 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 47C22922; Mon, 11 Dec 2023 19:19:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1702318747; bh=zoTHZxUmnwmdkG7z8JcGiL4cI1wP6xqkF6COSkVndx4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gj4KLWx9dq3EHwfvB1+sKGhomOlOUXyYNynfHbkCJ+wVlbHkXsNiOCrAFVIDi0s6Z kiahmqLlAeEhGsWslsmakYmTKljKrI711ITXGyxoSDptiFqG8GwpmOtWpuOCKdb7k0 R2B8WFS/hsW20fn/3GAeLUqqjpquSHCTgikIiuEo= Date: Mon, 11 Dec 2023 20:19:58 +0200 From: Laurent Pinchart To: Mikhail Rudenko Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sakari Ailus , Jacopo Mondi , Tommaso Merciai , Christophe JAILLET , Dave Stevenson , Mauro Carvalho Chehab Subject: Re: [PATCH 09/19] media: i2c: ov4689: Remove max_fps field from struct ov4689_mode Message-ID: <20231211181958.GH27535@pendragon.ideasonboard.com> References: <20231211175023.1680247-1-mike.rudenko@gmail.com> <20231211175023.1680247-10-mike.rudenko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231211175023.1680247-10-mike.rudenko@gmail.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 11 Dec 2023 10:20:00 -0800 (PST) Hi Mikhail, Thank you for the patch. On Mon, Dec 11, 2023 at 08:50:12PM +0300, Mikhail Rudenko wrote: > max_fps field of struct ov4689_mode is unused in this driver, so > remove it. > > Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/ov4689.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c > index ba33b0ced532..9fa06941a0e5 100644 > --- a/drivers/media/i2c/ov4689.c > +++ b/drivers/media/i2c/ov4689.c > @@ -60,7 +60,6 @@ struct ov4689_mode { > enum ov4689_mode_id id; > u32 width; > u32 height; > - u32 max_fps; > u32 hts_def; > u32 vts_def; > u32 exp_def; > @@ -237,7 +236,6 @@ static const struct ov4689_mode supported_modes[] = { > .sensor_height = 1536, > .crop_top = 8, > .crop_left = 16, > - .max_fps = 30, > .exp_def = 1536, > .hts_def = 4 * 2574, > .vts_def = 1554, -- Regards, Laurent Pinchart