Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <cf4e9f8b-7d31-44d9-93fd-1677918b56f4@nvidia.com>
Date:   Mon, 11 Dec 2023 11:00:39 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Revert "selftests: error out if kernel header files are
 not yet built"
Content-Language: en-US
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     David Hildenbrand <david@redhat.com>, Peter Xu <peterx@redhat.com>,
        Shuah Khan <shuah@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Anders Roxell <anders.roxell@linaro.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Peter Zijlstra <peterz@infradead.org>
References: <20231209020144.244759-1-jhubbard@nvidia.com>
 <0b35fcbd-ce8c-4c12-9725-01f18ade9fc0@collabora.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <0b35fcbd-ce8c-4c12-9725-01f18ade9fc0@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkdKN1lZZzJKUHVDeGxxcEJsWkxUdFRhV2lGWVhXT1dBVlpYVzV4QlAxRGhs?=
 =?utf-8?B?TGJqc3NuVEN3UGxRWUxzck02K3lDUXU3V0l2T3g3K3FSaTdEaEdma2xldlNF?=
 =?utf-8?B?WUplWUdaQm50ZU4wSHM0Q0t1YUkwTEhqcDVMZXJqT3NMcHJZRzZMV2pPZUpQ?=
 =?utf-8?B?Y3JJOW1uSmZvSmdVb3ZRUUg5SFdzL1QrSEJRTmRHRFF2dzJ0NDBvTGl2VWJI?=
 =?utf-8?B?anY1eXM1N09nYk0yN1JQeWZmQWQxMERQUDFkUWRwUzFxZ1RUNzd4em1ON1pw?=
 =?utf-8?B?SXdWZ1ZsVHpTcExSdmt2LzJxcUFYZHVFRlFtNDZ6V2w3NmFVK2FGMWYvc2tK?=
 =?utf-8?B?MUU2Y0FsMnlSQVZUSy9yK20wWDh3aGhzcmFSenBUemk0cWNTcG5CMFJGN3FZ?=
 =?utf-8?B?bC9lMXBHMVE1TFUyMkZpZnRGWDFibXoyakxScXVFUXU4RXcvc21HdFhQMTZC?=
 =?utf-8?B?MVRtNHp6OWkrNlV3VzdieFRGU0p1M0VsWXN1SXcxVVdjUUNrQTJPOGZVTC94?=
 =?utf-8?B?WTRMMFJzRWlTRmpJK1pRaXVDS0RzUjVMTk5PQU1FVFJzNUJGQ0pVam43ODQz?=
 =?utf-8?B?RnBXTTEyTUY2U0RhZ1hCUGdsQXllRDRzRWIzNE9YN1dpbXI2TEpOT0tvQ281?=
 =?utf-8?B?SW1qeFkzd3RHOVBtd0YwOEIxU0xhQmFvNEk1WGhWSmlNZkhtaEFBVHAxMjlu?=
 =?utf-8?B?Q090dFUyRlFEYXFDMFR5VFZsNVY4K0NiVEFJdzlBTEFFVEY5NjRmN2d2ZkVr?=
 =?utf-8?B?U1U5TkJhNnRnOUxQamZFc21meGUxd1lzZUdPTWdwQ3ovTlkzVmZlWk1ocGlr?=
 =?utf-8?B?bmxSWnMvRW9KSHZ5NWlTaThwc2I0RndyQVVvSW54bWZuTnQ1Ym5IOGwvMTdO?=
 =?utf-8?B?QkpWdVBjQTBodHkxdHB4d281Tit1V0QrTGtIUlkreVdyTWFrbXczR2JzMW5E?=
 =?utf-8?B?ZnRkanJlaDdtZ1E2bG55S1NUSkc4Tyt3ZmVaOFd3d3d0RHMwOC9ZZkZJRlVm?=
 =?utf-8?B?R0hrVTFndFAvZ1RPZDNOMmNZZVRoRFpXdGRDZ3NHS2tJYmRSOXVhUmU5eTNB?=
 =?utf-8?B?akZtSWZVU09OZGNCOTF5dC9zY0dVdFhIbENCZ1VMd0ovY0YwcGlZNWs2bjNX?=
 =?utf-8?B?MG5DS3k4TmMwNXVMaTZmZCsyMUJwY2ZyRGxxcDU0Mm5RNTVnWlRzLzk3aDdC?=
 =?utf-8?B?a084YkY4ZmJqY2lnK0kzRzZKNVIwQjhoenJxK3JpS3FFV0JUOERsaVBSQ003?=
 =?utf-8?B?NlZlWU5ETUtyZS9sRndYYThvVnI5VTU1S3ZzWEU0azJWc2FyMFVscHNvVDRm?=
 =?utf-8?B?aEk1ZnZndFllZCthcmxhNloxMkdkeVJvbGlYbUp3QzBJTU5rWDdJNStMQ05D?=
 =?utf-8?B?WUd5ayszd2pDRVJFd2Uvam9rUE1hc29VVkRNYUJDSmtPR2haWm1XV2VWLzNB?=
 =?utf-8?B?MU9vVTRFZUwvbzJRVXp0MTJRM0dCTFl6L1F0YUliR2hTZ1RKQVlwOS9VVVdr?=
 =?utf-8?B?SzcyMGUrYmp3dFovbFpMcEpYOUtFcEtYRVFCYW9McXNJVmpFS2YrdjArbVlL?=
 =?utf-8?B?U2o1eDluOEJKaktsVk9UMWptN0xtM2xRRlU1bU03YXhRdXozeTdUbWNZNkRn?=
 =?utf-8?B?YTlqZ2dHMzBEN1AvNERjMStoaG9TTWRaYVNqWUd2TE9MOXE3M1VpeGhZN0Fi?=
 =?utf-8?B?bHVSQXkrcmNkUngwVjI5amdTN3krZnFEY3RqRGNZVHM3OW9KdGZDbjhHMGp2?=
 =?utf-8?B?RmM5b2VmN0FDYWJZcVpmRmppR0JFbXJzYi9UeDJOblA5NjVGZUd2cldEQnRJ?=
 =?utf-8?B?NElUY1YrMHQ1YXdCU2szV1RJV29BaS80ZDZvVk83eXZiUmZicTJmcFQrSkVH?=
 =?utf-8?B?WUg3R21oRmM3WGdTaDhJM1dNdVY3U2Y2UHdLSHowKzJjbENNeFZVbEl6NUFu?=
 =?utf-8?B?ZGk5NzVUTjUzblVNRHJlQnhZeXpGUnNHVVk0ek5WUy9VaHpRdGlQNDZHVTV2?=
 =?utf-8?B?QjJZUXJmTmZPOGd4Qnl4Wnl6elI2QUthTFI4TEZDK3E3aTgxN1dERVQzREtT?=
 =?utf-8?B?WFhsdk9LUUs2R0VLV3FWQW9qS0tUdFNWQi9JYzBBQTh5TGZUUGt5YW1wYjM0?=
 =?utf-8?B?b0xHYTh4Um9VYU1sSkhDYmcxODhPS2hzTjUxeGZUY29sSHduOTRHb2JTWEY1?=
 =?utf-8?B?b0E9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8849cc45-5c89-45f6-f62b-08dbfa7b8745
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 19:01:06.1981
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nQJt8YV0Dn/VoPotJ4BlX+c2jdhQtIbCGTwlbIvdJRfqesi4WCy3U9eG5CwDqPkl/HHerQH8JBK/bg3o4l0axw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9108
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 11 Dec 2023 11:01:26 -0800 (PST)

On 12/11/23 03:00, Muhammad Usama Anjum wrote:
> On 12/9/23 7:01 AM, John Hubbard wrote:
>> This reverts commit 9fc96c7c19df ("selftests: error out if kernel header
>> files are not yet built").
> I don't think whole of this commit needs to be reverted. Lets leave the
> warning message as it is and just remove the condition to abort the
> compilation.
> 

Hi Muhammad!

If we do decide that "make headers" or something like it is required,
then yes, this patch should be changed from a revert, to a "warn instead
of failing out" patch.

First, though, I'd like us to choose a design direction. The patch as
written is intended to put us on a design that does not require "make
headers" before building the selftests, because that approach would work
for all the cases I've seen so far.

If we want something else, then David Hildenbrand has listed several
ideas, and I've added a 4th one to the list, in [1].


[1] https://lore.kernel.org/3eadd79c-c02a-495f-92c0-0315046ef59f@nvidia.com


thanks,
-- 
John Hubbard
NVIDIA