Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 11 Dec 2023 11:16:10 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Ira Weiny <ira.weiny@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        Shiju Jose <shiju.jose@huawei.com>
CC:     Yazen Ghannam <yazen.ghannam@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ard Biesheuvel" <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH 6/6] cxl/memdev: Register for and process CPER events
Message-ID: <65775ffa7e529_a04c52941d@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230601-cxl-cper-v1-0-d19f1ac18ab6@intel.com>
 <20230601-cxl-cper-v1-6-d19f1ac18ab6@intel.com>
 <657279a68c270_b991294e@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <657371eec6ac5_1e7d272948d@iweiny-mobl.notmuch>
 <65738e9fc239a_45e0129476@dwillia2-xfh.jf.intel.com.notmuch>
 <65775c98e0b39_1f2db42944f@iweiny-mobl.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <65775c98e0b39_1f2db42944f@iweiny-mobl.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?brhrYrZ7jsIHzQD3OvQ2o3ZzV/D9eTBtmfinml70G9rt9+OxBOiFXyhDQ1bE?=
 =?us-ascii?Q?uzAiXF0Srv6+km9j9A92PzsNdUA/o8SN3mxmxLMQ5bh7hViT/NhSyAv3J0Ud?=
 =?us-ascii?Q?8rNTHWvauaV/PCqPxqf/Wf87oltyQm0eYTU3r3iV6QXO4WwUSFtftxg2UxoI?=
 =?us-ascii?Q?+dVmCFY/bnlVYgVAXAazOmQWf86yqVvE2POyz6NO8FeTl2o6j2fgZrs25IpG?=
 =?us-ascii?Q?DdwwzptLvGhFywzTPgmWo2mcn7iWS/zm9jKweCDmdjBNcNEqkOaRgDYC92ay?=
 =?us-ascii?Q?q9F0m1mQattjliTQkK6mNfU6VwOU6FzcT7nOCnMdfj3TC2FZr6UPokvW3PqH?=
 =?us-ascii?Q?EUBI1aW33orK9NUj/9U29zM5KT+Qlapdl6qwhybRYQd/lJce7NVLUFdoNs4y?=
 =?us-ascii?Q?2/PmESD32WQPH+QAbF9kMsswAdIDFBu4kFvV8birmOTS8N95Nf6Fu03NumbI?=
 =?us-ascii?Q?Mf0vzOMIeVZs9gkp2e4j0ncGT//VCAAuLDTcpCwsvYzr4SJT564YHnMtmR06?=
 =?us-ascii?Q?7WW5VwRHDaOFn3mRL3Oot7i0ZbpS8OOe/iqBa/IVWh9ozNpkkw93b6xkhrgO?=
 =?us-ascii?Q?GG8RggqmznQEF1KoAnuuawUuQ0XdzBO892D/G/6by1ZOuVfjZVB+6YB3tnWg?=
 =?us-ascii?Q?L5GBrsqwVm1Sqo0JF8LbfvVVsh1/u0fY1rf+cTCv3B/Xec2Jva5n71vXJWt1?=
 =?us-ascii?Q?VpIoQ3t0YAoQhM3PRMAPbzL28VOhwvnE5xS+4mhIIrypyy6sdBUWaPi8EUsR?=
 =?us-ascii?Q?OgH4jhwruA0m6bg/3DgbnFxATV5V3Av7R0cMdUhutCONv6Bf90ij5erexGGb?=
 =?us-ascii?Q?+iOhNCGbKtQePiQLmyfymugAqPEHOFIX8kAIBKP1j2f/E1gEZEOg5TbIIA1x?=
 =?us-ascii?Q?6ka9lstlDT9z4fmoitL1bntevlYHV2mziKDQkHeOyVe0rDqmVzSgpkZjZG3U?=
 =?us-ascii?Q?SOP1/gdwD9zQXvg+361+6l1vJcdinK4Z9POCY9zQn9oFJz3C2JxO0VyhL3kT?=
 =?us-ascii?Q?dUE4uDzQJPSVYBAPioQo+GgU3N7f5qjyEFJWWgvyv04PCwROocT5Pdm/IiZk?=
 =?us-ascii?Q?/B2a/Pgn4SfgkjeMjmV7584tq9Qk4L5fh0URhBFCwjRjYcVcqWXnmwgBd1ft?=
 =?us-ascii?Q?kXYZ5yIi4S6aAA0yOncEo++ftJ7nSFPqGPY1XffmDxjTrZBGl1JoqMTV7Atv?=
 =?us-ascii?Q?S9swmw/AkCJZXb9mbSZBeBQ6vBwBHUOrd5E8CiyKMM4Ra5TwKXMhy2FbgWzA?=
 =?us-ascii?Q?6g1Ad0BbD1oVGTDCeCRfGZVJSfOhrmSe8cxV9iMCnDgkgiTAoJYTPeupBJH3?=
 =?us-ascii?Q?p6aFDIxPMCNI4Xk1RVraKL8aPCnYnoVuZ76J0hhMX9HfpY/lI2efOXqTlQTh?=
 =?us-ascii?Q?cGUrvTGm44T9YiXLH6k6dJtz662/gtSiUO2pvOd4xWsP4lYja0ejcVuMq1Tp?=
 =?us-ascii?Q?pStRa00meMmSdyiADY3azFLooKXLwsElsIGCqXh57FPqI9WWNl3yHNJnO5NL?=
 =?us-ascii?Q?7b/XO89c0FPPcdzyd10zlSRP23MBJ4P6cM5bniJanalV9JSmKP1rHOAaqUXH?=
 =?us-ascii?Q?Fy1JnOIfXfFg7T6FP6VH+LGEz8D84mUswQOfMC1IpOZ6MWX8NoE2eDXQpWJ1?=
 =?us-ascii?Q?zg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a7323144-0ee6-4fba-67d2-08dbfa7da785
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 19:16:19.3929
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JE2P7gShV+qXW4yObM+JDMKTVmpEpm3mxWOoVsNay2GO8w6jmrZVudgcJJRO+k3Ek9mFE6FCxyLUgxySo0XtnO1zF7XTFvF5sETn1xWIPng=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7914
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 11 Dec 2023 11:16:36 -0800 (PST)

Ira Weiny wrote:
> Dan Williams wrote:
> > Ira Weiny wrote:
> > > Dan Williams wrote:
> > > > Ira Weiny wrote:
> > > 
> > 
> 
> [snip]
> 
> > 
> > > #define CXL_EVENT_HDR_FLAGS_REC_SEVERITY GENMASK(1, 0)
> > > static void cxl_cper_event_call(struct cxl_cper_notifier_data *nd)
> > 
> > Is struct cxl_cper_notifier_data needed anymore, just pass the record
> > reference?
> 
> I think so because the type of record is ID'ed by the GUID which is not
> part of the common record.  So the notifier data adds the cxl_event_type
> enum.

Ah, yup, but then I wonder if CPER can just do the GUID to type enum
lookup and keep the CXL side GUID-free? I.e. just pass the type as a
separate argument.