Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Mon, 11 Dec 2023 13:51:56 -0600
From:   Andrew Halaney <ahalaney@redhat.com>
To:     Bart Van Assche <bvanassche@acm.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Manivannan Sadhasivam <mani@kernel.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Yaniv Gardi <ygardi@codeaurora.org>,
        Dov Levenglick <dovl@codeaurora.org>,
        Will Deacon <will@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: qcom: Perform read back after writing reset
 bit
Message-ID: <oyjzluv5ldvurqzsqiwxnjtmpvvjavkdxvbetwctq7qentdjbh@r27gvlj62scq>
References: <20231208-ufs-reset-ensure-effect-before-delay-v1-1-8a0f82d7a09e@redhat.com>
 <0d59681d-2d7d-4459-b79c-c5f41f20b7a5@acm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0d59681d-2d7d-4459-b79c-c5f41f20b7a5@acm.org>
Precedence: bulk

On Mon, Dec 11, 2023 at 09:59:25AM -0800, Bart Van Assche wrote:
> 
> On 12/8/23 12:19, Andrew Halaney wrote:
> > The recommendation for ensuring this bit has taken effect on the
> > device is to perform a read back to force it to make it all the way
> > to the device. This is documented in device-io.rst  [... ]
> There are more mb()'s that need to be replaced, namely the mb() calls in
> ufshcd_system_restore() and ufshcd_init().

I'll poke at those in v2 (or in a separate series if this is scooped up
prior).

Thanks,
Andrew